Merge lp:~nigelbabu/launchpad/4595-upgrade-bug-linking into lp:launchpad

[Nigel Babu]

[r=benji,stub] [r=stub][bug=4595] Distinguish between valid and invalid bugs when autolinkifying bugs

Distinguish between valid and invalid bugs when autolinkifying bugs

[Stuart Bishop (stub)]

Per IRC, calling a private bug invalid is confusing. If you keep the method name the same, it needs a comment.

review: Approve

[Stuart Bishop (stub)]

15731 tests run in 3:56:26.265316, 7 failures, 0 errors

Failing tests
-------------
 lp.app.browser.tests.test_webservice.TestXHTMLRepresentations.test_text
 lib/lp/app/doc/displaying-paragraphs-of-text.txt
 lp.bugs.tests.test_bugs_webservice.TestBugDescriptionRepresentation.test_GET_xhtml_representation
 lp.bugs.tests.test_bugs_webservice.TestBugDescriptionRepresentation.test_PATCH_xhtml_representation
 lib/lp/soyuz/stories/soyuz/xx-sourcepackage-changelog.txt
 lp.app.browser.tests.test_stringformatter.TestLinkifyingBugs.test_explicit_bug_linkification
 lp.app.browser.tests.test_stringformatter.TestLinkifyingBugs.test_regular_bug_case_works

Look to be mainly mechanical problems with tests not coping with the new class attributes in the links.

[Stuart Bishop (stub)]

======================================================================
FAILURE: lp.app.browser.tests.test_webservice.TestXHTMLRepresentations.test_text (subunit.RemotedTestCase)
----------------------------------------------------------------------
_StringException: Text attachment: traceback
------------
Traceback (most recent call last):
_StringException: Traceback (most recent call last):
 File "/var/launchpad/test/lib/lp/app/browser/tests/test_webservice.py", line 50, in test_text
   renderer(text))
AssertionError: !=:
reference = u'<p>\u2603 <email address hidden> <a href="/bugs/1">bug 1</a></p>'
actual = u'<p>\u2603 <email address hidden> <a href="/bugs/1" class="bug-link">bug 1</a></p>'

------------

======================================================================
FAILURE: lib/lp/app/doc/displaying-paragraphs-of-text.txt (subunit.RemotedTestCase)
----------------------------------------------------------------------
_StringException: Text attachment: traceback
------------
Traceback (most recent call last):
 File "/usr/lib/python2.6/unittest.py", line 279, in run
   testMethod()
 File "/usr/lib/python2.6/doctest.py", line 2152, in runTest
   raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for displaying-paragraphs-of-text.txt
 File "lib/lp/app/doc/displaying-paragraphs-of-text.txt", line 0

----------------------------------------------------------------------
File "lib/lp/app/doc/displaying-paragraphs-of-text.txt", line 227, in displaying-paragraphs-of-text.txt
Failed example:
   print test_tales('foo/fmt:text-to-html', foo=text)
Differences (ndiff with -expected +actual):
   - <p><a href="/bugs/123">bug 123</a><br />
   + <p><a href="/bugs/123" class="bug-link">bug 123</a><br />
   ? +++++++++++++++++
   - <a href="/bugs/123">bug 123</a><br />
   + <a href="/bugs/123" class="bug-link">bug 123</a><br />
   ? +++++++++++++++++
   - <a href="/bugs/123">bug #123</a><br />
   + <a href="/bugs/123" class="bug-link">bug #123</a><br />
   ? +++++++++++++++++
   - <a href="/bugs/123">bug number 123</a><br />
   + <a href="/bugs/123" class="bug-link">bug number 123</a><br />
   ? +++++++++++++++++
     bug number. 123<br />
   - <a href="/bugs/123">bug num 123</a><br />
   + <a href="/bugs/123" class="bug-link">bug num 123</a><br />
   ? +++++++++++++++++
   - <a href="/bugs/123">bug num. 123</a><br />
   + <a href="/bugs/123" class="bug-link">bug num. 123</a><br />
   ? +++++++++++++++++
   - <a href="/bugs/123">bug no 123</a><br />
   + <a href="/bugs/123" class="bug-link">bug no 123</a><br />
   ? +++++++++++++++++
   - <a href="/bugs/123">bug report 123</a><br />
   + <a href="/bugs/123" class="bug-link">bug report 123</a><br />
   ? +++++++++++++++++
   - <a href="/bugs/123">bug no. 123</a><br />
   + <a href="/bugs/123" class="bug-link">bug no. 123</a><br />
   ? +++++++++++++++++
     bug#123<br />
   - <a href="/bugs/123">bug-123</a><br />
   + <a href="/bugs/123" class="bug-link">bug-123</a><br />
   ? ...

[Benji York (benji)]

This looks good.

review: Approve (code)

[Benji York (benji)]

There were some test failures:

Tests started at approximately 2011-08-22 15:14:33.722262
Source: bzr+ssh://bazaar.launchpad.net/~nigelbabu/launchpad/4595-upgrade-bug-linking r13583
Target: bzr+ssh://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/ r13755

15732 tests run in 4:05:03.916762, 2 failures, 10 errors

Failing tests
-------------
 lib/lp/app/doc/displaying-paragraphs-of-text.txt
 lp.app.browser.tests.test_stringformatter.TestLinkifyingBugs.test_explicit_bug_linkification

Tests with errors
-----------------
 lp.bugs.model.tests.test_bugtask.TestValidateTarget.test_new_sourcepackage_is_allowed
 lp.bugs.model.tests.test_bugtask.TestValidateTransitionToTarget.test_sourcepackage_to_sourcepackage_in_same_series_works
 lp.bugs.tests.test_structuralsubscription.TestGetStructuralSubscriptionTargets.test_sourcepackage_target
 lp.codehosting.scanner.tests.test_buglinks.TestBugLinking.test_ignoreNonExistentBug
 lp.codehosting.scanner.tests.test_buglinks.TestBugLinking.test_knownMainlineRevisionsDoesntMakeLink
 lp.codehosting.scanner.tests.test_buglinks.TestBugLinking.test_linking_bug_to_official_package_branch
 lp.codehosting.scanner.tests.test_buglinks.TestBugLinking.test_multipleBugsInProperty
 lp.codehosting.scanner.tests.test_buglinks.TestBugLinking.test_newMainlineRevisionAddsBugBranch
 lp.codehosting.scanner.tests.test_buglinks.TestBugLinking.test_nonMainlineRevisionsDontMakeBugBranches
 lp.codehosting.scanner.tests.test_buglinks.TestBugLinking.test_scanningTwiceDoesntMatter

======================================================================
FAILURE: lib/lp/app/doc/displaying-paragraphs-of-text.txt (subunit.RemotedTestCase)
----------------------------------------------------------------------
_StringException: Text attachment: traceback
------------
Traceback (most recent call last):
 File "/usr/lib/python2.6/unittest.py", line 279, in run
   testMethod()
 File "/usr/lib/python2.6/doctest.py", line 2152, in runTest
   raise self.failureException(self.format_failure(new.getvalue()))
AssertionError: Failed doctest test for displaying-paragraphs-of-text.txt
 File "lib/lp/app/doc/displaying-paragraphs-of-text.txt", line 0

----------------------------------------------------------------------
File "lib/lp/app/doc/displaying-paragraphs-of-text.txt", line 536, in displaying-paragraphs-of-text.txt
Failed example:
   FormattersAPI._linkify_substitution(matchobj)
Differences (ndiff with -expected +actual):
   - '<a href="/bugs/2000">xxxx</a>'
   + '<a href="/bugs/2000" class="bug-link">xxxx</a>'
   ? +++++++++++++++++

------------

======================================================================
FAILURE: lp.app.browser.tests.test_stringformatter.TestLinkifyingBugs.test_explicit_bug_linkification (subunit.RemotedTestCase)
----------------------------------------------------------------------
_StringException: Text attachment: traceback
------------
Traceback (most recent call last):
_StringException: Traceback (most recent call last):
 File "/var/launchpad/test/lib/lp/app/browser/tests/test_stringformatter.py", line 150, in test_explicit_bug_linkification
   'LP: <a href="/bugs/10" class="bug-links">#10</a>',...

=== modified file 'lib/lp/app/browser/linkchecker.py'
--- lib/lp/app/browser/linkchecker.py	2010-11-12 18:31:05 +0000
+++ lib/lp/app/browser/linkchecker.py	2011-08-23 01:37:40 +0000
@@ -11,6 +11,9 @@
 import simplejson
 from zope.component import getUtility
 
+from canonical.launchpad.searchbuilder import any
+from canonical.launchpad.webapp import LaunchpadView
+
 from lp.app.errors import NotFoundError
 from lp.code.errors import (
     CannotHaveLinkedBranch,
@@ -19,10 +22,12 @@
     NoSuchBranch,
     )
 from lp.code.interfaces.branchlookup import IBranchLookup
+from lp.bugs.interfaces.bugtask import BugTaskSearchParams, IBugTaskSet
+from lp.registry.interfaces.person import IPerson
 from lp.registry.interfaces.product import InvalidProductName
 
 
-class LinkCheckerAPI:
+class LinkCheckerAPI(LaunchpadView):
     """Validates Launchpad shortcut links.
 
     This class provides the endpoint of an Ajax call to .../+check-links.
@@ -47,6 +52,7 @@
         # Each link type has it's own validation method.
         self.link_checkers = dict(
             branch_links=self.check_branch_links,
+            bug_links=self.check_bug_links,
         )
 
     def __call__(self):
@@ -78,6 +84,21 @@
                 invalid_links[link] = self._error_message(e)
         return invalid_links
 
+    def check_bug_links(self, links):
+        """Checks links of the form /bugs/100"""
+        invalid_links = {}
+        user = self.user
+        bugs = [int(link[len('/bugs/'):]) for link in links]
+        if bugs:
+            params = BugTaskSearchParams(
+                user=user, status=None,
+                bug=any(*bugs))
+            bug_ids = getUtility(IBugTaskSet).searchBugIds(params)
+            invalid = set(bugs) - set(bug_ids)
+            for bug in invalid:
+                invalid_links['/bugs/' + str(bug)] = "Bug %s cannot be found" % bug
+        return invalid_links
+         
     def _error_message(self, ex):
         if hasattr(ex, 'display_message'):
             return ex.display_message

=== modified file 'lib/lp/app/browser/stringformatter.py'
--- lib/lp/app/browser/stringformatter.py	2011-07-12 10:02:51 +0000
+++ lib/lp/app/browser/stringformatter.py	2011-08-23 01:37:40 +0000
@@ -283,7 +283,7 @@
         # linkify to the general bug url.
         url = '/bugs/%s' % bugnum
         # The text will have already been cgi escaped.
-        return '<a href="%s">%s</a>%s' % (url, text, trailers)
+        return '<a href="%s" class="bug-link">%s</a>%s' % (url, text, trailers)
 
     @staticmethod
     def _handle_parens_in_trailers(url, trailers):

=== modified file 'lib/lp/app/browser/tests/test_linkchecker.py'
--- lib/lp/app/browser/tests/test_linkchecker.py	2010-11-11 23:40:36 +0000
+++ lib/lp/app/browser/tests/test_linkchecker.py	2011-08-23 01:37:40 +0000
@@ -10,6 +10,7 @@
 import simplejson
 from zope.security.proxy import removeSecurityProxy
 
+from canonical.launchpad.webapp import canonical_url
 from canonical.launchpad.webapp.servers import LaunchpadTestRequest
 from canonical.testing.layers import DatabaseFunctionalLayer
 from lp.app.browser.linkchecker import LinkCheckerAPI
@@ -28,7 +29,7 @@
         self.assertEqual(len(invalid_links), len(links_to_check))
         self.assertEqual(set(invalid_links), set(links_to_check))
 
-    def make_valid_links(self):
+    def make_valid_branch_links(self):
         branch = self.factory.makeProductBranch()
         valid_branch_url = self.BRANCH_URL_TEMPLATE % branch.unique_name
         product = self.factory.makeProduct()
@@ -41,24 +42,45 @@
             valid_product_url,
         ]
 
-    def make_invalid_links(self):
+    def make_invalid_branch_links(self):
         return [
             self.BRANCH_URL_TEMPLATE % 'foo',
             self.BRANCH_URL_TEMPLATE % 'bar',
             ]
 
-    def invoke_branch_link_checker(
-        self, valid_branch_urls=None, invalid_branch_urls=None):
+    def make_valid_bug_links(self):
+        bug = self.factory.makeBug()
+        return ['/bugs/%d' % (bug.id)]
+
+    def make_invalid_bug_links(self):
+        """
+        As far as searchBugs() is concerned, this is an invalid bug to the
+        currently authenticated user
+        """
+        bug_private = self.factory.makeBug(private=True)
+        return ['/bugs/%d' % (bug_private.id)]
+
+    def invoke_link_checker(
+        self, valid_branch_urls=None, invalid_branch_urls=None,
+        valid_bug_urls=None, invalid_bug_urls=None):
         if valid_branch_urls is None:
             valid_branch_urls = {}
         if invalid_branch_urls is None:
             invalid_branch_urls = {}
+        if valid_bug_urls is None:
+            valid_bug_urls = {}
+        if invalid_bug_urls is None:
+            invalid_bug_urls = {}
 
         branch_urls = list(valid_branch_urls)
         branch_urls.extend(invalid_branch_urls)
         shuffle(branch_urls)
+        
+        bug_urls = list(valid_bug_urls)
+        bug_urls.extend(invalid_bug_urls)
+        shuffle(bug_urls)
 
-        links_to_check = dict(branch_links=branch_urls)
+        links_to_check = dict(branch_links=branch_urls, bug_links=bug_urls)
         link_json = simplejson.dumps(links_to_check)
 
         request = LaunchpadTestRequest(link_hrefs=link_json)
@@ -74,17 +96,23 @@
         link_dict = simplejson.loads(result_json)
         self.assertEqual(link_dict, {})
 
-    def test_only_valid_branchlinks(self):
-        branch_urls = self.make_valid_links()
-        self.invoke_branch_link_checker(valid_branch_urls=branch_urls)
-
-    def test_only_invalid_branchlinks(self):
-        branch_urls = self.make_invalid_links()
-        self.invoke_branch_link_checker(invalid_branch_urls=branch_urls)
-
-    def test_valid_and_invald_branchlinks(self):
-        valid_branch_urls = self.make_valid_links()
-        invalid_branch_urls = self.make_invalid_links()
-        self.invoke_branch_link_checker(
+    def test_only_valid_links(self):
+        branch_urls = self.make_valid_branch_links()
+        bug_urls = self.make_valid_bug_links()
+        self.invoke_link_checker(valid_branch_urls=branch_urls, valid_bug_urls=bug_urls)
+
+    def test_only_invalid_links(self):
+        branch_urls = self.make_invalid_branch_links()
+        bug_urls = self.make_invalid_bug_links()
+        self.invoke_link_checker(invalid_branch_urls=branch_urls, invalid_bug_urls=bug_urls)
+
+    def test_valid_and_invald_links(self):
+        valid_branch_urls = self.make_valid_branch_links()
+        invalid_branch_urls = self.make_invalid_branch_links()
+        valid_bug_urls = self.make_valid_bug_links()
+        invalid_bug_urls = self.make_invalid_bug_links()
+        self.invoke_link_checker(
             valid_branch_urls=valid_branch_urls,
-            invalid_branch_urls=invalid_branch_urls)
+            invalid_branch_urls=invalid_branch_urls,
+            valid_bug_urls=valid_bug_urls,
+            invalid_bug_urls=invalid_bug_urls)

=== modified file 'lib/lp/app/browser/tests/test_stringformatter.py'
--- lib/lp/app/browser/tests/test_stringformatter.py	2011-06-23 13:02:23 +0000
+++ lib/lp/app/browser/tests/test_stringformatter.py	2011-08-23 01:37:40 +0000
@@ -119,9 +119,9 @@
             "bug number 34434",
             ]
         expected_html = [
-            '<p><a href="/bugs/34434">bug 34434</a></p>',
-            '<p><a href="/bugs/34434">bugnumber 34434</a></p>',
-            '<p><a href="/bugs/34434">bug number 34434</a></p>',
+            '<p><a href="/bugs/34434" class="bug-link">bug 34434</a></p>',
+            '<p><a href="/bugs/34434" class="bug-link">bugnumber 34434</a></p>',
+            '<p><a href="/bugs/34434" class="bug-link">bug number 34434</a></p>',
             ]
         self.assertEqual(
             expected_html,
@@ -147,7 +147,7 @@
     def test_explicit_bug_linkification(self):
         text = 'LP: #10'
         self.assertEqual(
-            'LP: <a href="/bugs/10">#10</a>', linkify_bug_numbers(text))
+            'LP: <a href="/bugs/10" class="bug-link">#10</a>', linkify_bug_numbers(text))
 
 
 class TestLinkifyingProtocols(TestCase):

=== modified file 'lib/lp/app/browser/tests/test_webservice.py'
--- lib/lp/app/browser/tests/test_webservice.py	2011-07-14 09:32:22 +0000
+++ lib/lp/app/browser/tests/test_webservice.py	2011-08-23 01:37:40 +0000
@@ -46,7 +46,7 @@
         # The representation is linkified html.
         self.assertEqual(
             u'<p>\N{SNOWMAN} [e-mail] '
-            '<a href="/bugs/1">bug 1</a></p>',
+            '<a href="/bugs/1" class="bug-link">bug 1</a></p>',
             renderer(text))
 
 

=== modified file 'lib/lp/app/doc/displaying-paragraphs-of-text.txt'
--- lib/lp/app/doc/displaying-paragraphs-of-text.txt	2011-06-23 13:10:40 +0000
+++ lib/lp/app/doc/displaying-paragraphs-of-text.txt	2011-08-23 01:37:40 +0000
@@ -225,40 +225,40 @@
     ...     '#123\n'
     ...     'debug #52\n')
     >>> print test_tales('foo/fmt:text-to-html', foo=text)
-    <p><a href="/bugs/123">bug 123</a><br />
-    <a href="/bugs/123">bug    123</a><br />
-    <a href="/bugs/123">bug #123</a><br />
-    <a href="/bugs/123">bug number 123</a><br />
+    <p><a href="/bugs/123" class="bug-link">bug 123</a><br />
+    <a href="/bugs/123" class="bug-link">bug    123</a><br />
+    <a href="/bugs/123" class="bug-link">bug #123</a><br />
+    <a href="/bugs/123" class="bug-link">bug number 123</a><br />
     bug number. 123<br />
-    <a href="/bugs/123">bug num 123</a><br />
-    <a href="/bugs/123">bug num. 123</a><br />
-    <a href="/bugs/123">bug no 123</a><br />
-    <a href="/bugs/123">bug report 123</a><br />
-    <a href="/bugs/123">bug no. 123</a><br />
+    <a href="/bugs/123" class="bug-link">bug num 123</a><br />
+    <a href="/bugs/123" class="bug-link">bug num. 123</a><br />
+    <a href="/bugs/123" class="bug-link">bug no 123</a><br />
+    <a href="/bugs/123" class="bug-link">bug report 123</a><br />
+    <a href="/bugs/123" class="bug-link">bug no. 123</a><br />
     bug#123<br />
-    <a href="/bugs/123">bug-123</a><br />
-    <a href="/bugs/123">bug-report-123</a><br />
-    <a href="/bugs/123">bug=123</a><br />
-    <a href="/bugs/123">bug<br /> #123</a><br />
+    <a href="/bugs/123" class="bug-link">bug-123</a><br />
+    <a href="/bugs/123" class="bug-link">bug-report-123</a><br />
+    <a href="/bugs/123" class="bug-link">bug=123</a><br />
+    <a href="/bugs/123" class="bug-link">bug<br /> #123</a><br />
     debug #52</p>
 
     >>> text = (
     ...     'bug 123\n'
     ...     'bug 123\n')
     >>> print test_tales('foo/fmt:text-to-html', foo=text)
-    <p><a href="/bugs/123">bug 123</a><br />
-    <a href="/bugs/123">bug 123</a></p>
+    <p><a href="/bugs/123" class="bug-link">bug 123</a><br />
+    <a href="/bugs/123" class="bug-link">bug 123</a></p>
 
     >>> text = (
     ...     'bug 1234\n'
     ...     'bug 123\n')
     >>> print test_tales('foo/fmt:text-to-html', foo=text)
-    <p><a href="/bugs/1234">bug 1234</a><br />
-    <a href="/bugs/123">bug 123</a></p>
+    <p><a href="/bugs/1234" class="bug-link">bug 1234</a><br />
+    <a href="/bugs/123" class="bug-link">bug 123</a></p>
 
     >>> text = 'bug 0123\n'
     >>> print test_tales('foo/fmt:text-to-html', foo=text)
-    <p><a href="/bugs/123">bug 0123</a></p>
+    <p><a href="/bugs/123" class="bug-link">bug 0123</a></p>
 
 
 We linkify bugs that are in the Ubuntu convention for referring to bugs in
@@ -266,26 +266,26 @@
 
     >>> text = 'LP: #123.\n'
     >>> print test_tales('foo/fmt:text-to-html', foo=text)
-    <p>LP: <a href="/bugs/123">#123</a>.</p>
+    <p>LP: <a href="/bugs/123" class="bug-link">#123</a>.</p>
 
 Works with multiple bugs:
 
     >>> text = 'LP: #123, #2.\n'
     >>> print test_tales('foo/fmt:text-to-html', foo=text)
-    <p>LP: <a href="/bugs/123">#123</a>, <a href="/bugs/2">#2</a>.</p>
+    <p>LP: <a href="/bugs/123" class="bug-link">#123</a>, <a href="/bugs/2" class="bug-link">#2</a>.</p>
 
 And with lower case 'lp' too:
 
     >>> text = 'lp: #123, #2.\n'
     >>> print test_tales('foo/fmt:text-to-html', foo=text)
-    <p>lp: <a href="/bugs/123">#123</a>, <a href="/bugs/2">#2</a>.</p>
+    <p>lp: <a href="/bugs/123" class="bug-link">#123</a>, <a href="/bugs/2" class="bug-link">#2</a>.</p>
 
 Even line breaks cannot stop the power of bug linking:
 
     >>> text = 'LP:  #123,\n#2.\n'
     >>> print test_tales('foo/fmt:text-to-html', foo=text)
-    <p>LP:  <a href="/bugs/123">#123</a>,<br />
-    <a href="/bugs/2">#2</a>.</p>
+    <p>LP:  <a href="/bugs/123" class="bug-link">#123</a>,<br />
+    <a href="/bugs/2" class="bug-link">#2</a>.</p>
 
 To check a private bug, we need to log in and set a bug to be private.
 
@@ -308,7 +308,7 @@
 
     >>> text = 'bug 6\n'
     >>> print test_tales('foo/fmt:text-to-html', foo=text)
-    <p><a href="/bugs/6">bug 6</a></p>
+    <p><a href="/bugs/6" class="bug-link">bug 6</a></p>
 
 
 == FAQ references ==
@@ -374,14 +374,14 @@
 
     >>> text = 'lp:1234'
     >>> print test_tales('foo/fmt:text-to-html', foo=text)
-    <p><a href="/bugs/1234">lp:1234</a></p>
+    <p><a href="/bugs/1234" class="bug-link">lp:1234</a></p>
 
 We are even smart enough to notice the trailing punctuation gunk and separate
 that from the link.
 
     >>> text = 'lp:1234,'
     >>> print test_tales('foo/fmt:text-to-html', foo=text)
-    <p><a href="/bugs/1234">lp:1234</a>,</p>
+    <p><a href="/bugs/1234" class="bug-link">lp:1234</a>,</p>
 
 
 == OOPS references ==
@@ -524,7 +524,7 @@
     >>> sorted(matchobj.groupdict().items())
     [('bug', 'xxxx'), ('bugnum', '2'), ('url', None)]
     >>> FormattersAPI._linkify_substitution(matchobj)
-    '<a href="/bugs/2">xxxx</a>'
+    '<a href="/bugs/2" class="bug-link">xxxx</a>'
 
 When the bugnum doesn't match any bug, we still get a link, but get a message
 in the link's title.
@@ -534,4 +534,4 @@
     >>> sorted(matchobj.groupdict().items())
     [('bug', 'xxxx'), ('bugnum', '2000'), ('url', None)]
     >>> FormattersAPI._linkify_substitution(matchobj)
-    '<a href="/bugs/2000">xxxx</a>'
+    '<a href="/bugs/2000" class="bug-link">xxxx</a>'

=== modified file 'lib/lp/app/javascript/lp-links.js'
--- lib/lp/app/javascript/lp-links.js	2011-02-24 00:23:04 +0000
+++ lib/lp/app/javascript/lp-links.js	2011-08-23 01:37:40 +0000
@@ -58,6 +58,7 @@
         // We get all the links with defined css classes.
         // At the moment, we just handle branch links, but in future...
         harvest_links(links_to_check, 'branch-short-link', 'branch_links');
+        harvest_links(links_to_check, 'bug-link', 'bug_links');
 
         // Do we have anything to do?
         if( Y.Object.size(links_to_check) == 0 ) {
@@ -85,6 +86,8 @@
                     // ATM, we just handle branch links, but in future...
                     process_invalid_links(link_info, 'branch-short-link',
                             'branch_links');
+                    process_invalid_links(link_info, 'bug-link',
+                            'bug_links');
                 }
             }
         }

=== modified file 'lib/lp/bugs/tests/test_bugs_webservice.py'
--- lib/lp/bugs/tests/test_bugs_webservice.py	2011-05-27 14:07:42 +0000
+++ lib/lp/bugs/tests/test_bugs_webservice.py	2011-08-23 01:37:40 +0000
@@ -108,7 +108,7 @@
         self.assertEqual(
             self.findBugDescription(response),
             u'<p>Useless bugs are useless. '
-            'See <a href="/bugs/%d">Bug %d</a>.</p>' % (
+            'See <a href="/bugs/%d" class="bug-link">Bug %d</a>.</p>' % (
             self.bug_one.id, self.bug_one.id))
 
     def test_PATCH_xhtml_representation(self):
@@ -127,7 +127,7 @@
 
         self.assertEqual(
             self.findBugDescription(response),
-            u'<p>See <a href="/bugs/%d">bug %d</a></p>' % (
+            u'<p>See <a href="/bugs/%d" class="bug-link">bug %d</a></p>' % (
             self.bug_one.id, self.bug_one.id))
 
 

=== modified file 'lib/lp/soyuz/stories/soyuz/xx-sourcepackage-changelog.txt'
--- lib/lp/soyuz/stories/soyuz/xx-sourcepackage-changelog.txt	2011-05-13 03:26:21 +0000
+++ lib/lp/soyuz/stories/soyuz/xx-sourcepackage-changelog.txt	2011-08-23 01:37:40 +0000
@@ -104,8 +104,8 @@
   <pre ... id="alsa-utils_1.0.9a-4ubuntu1">alsa-utils (1.0.9a-4ubuntu1) ...
   <BLANKLINE>
   ...
-   LP: <a href="/bugs/10">#10</a>
-   LP: <a href="/bugs/999">#999</a>
+   LP: <a href="/bugs/10" class="bug-link">#10</a>
+   LP: <a href="/bugs/999" class="bug-link">#999</a>
    LP: #badid
   ...