Code review comment for lp:~niemeyer/gozk/fix-weekly

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Reviewers: mp+93198_code.launchpad.net,

Message:
Please take a look.

Description:

https://code.launchpad.net/~niemeyer/gozk/fix-weekly/+merge/93198

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/5656063/

Affected files:
   M runserver.go

Index: runserver.go
=== <email address hidden> >
<email address hidden>
=== modified file 'runserver.go'
--- runserver.go 2011-12-05 19:15:00 +0000
+++ runserver.go 2012-02-15 13:14:05 +0000
@@ -48,7 +48,7 @@

   // try to check if the process is actually running by sending
   // it signal 0.
- err = p.Signal(os.UnixSignal(0))
+ err = p.Signal(syscall.Signal(0))
   if err == nil {
    return p, nil
   }
@@ -136,7 +136,7 @@
   // anyway or that we can't wait for it for some other reason,
   // for example because it was originally started by some other process.
   _, err = p.Wait(0)
- if e, ok := err.(*os.SyscallError); ok && e.Errno == os.ECHILD || err ==
os.ECHILD {
+ if e, ok := err.(*os.SyscallError); ok && e.Err == os.ECHILD {
    // If we can't wait for the server, it's possible that it was running
    // but not as a child of this process, so the only thing we can do
    // is to poll until it exits. If the process has taken longer than

« Back to merge proposal