Merge lp:~niemeyer/goyaml/restore-semantics into lp:goyaml

Proposed by Gustavo Niemeyer
Status: Merged
Merged at revision: 50
Proposed branch: lp:~niemeyer/goyaml/restore-semantics
Merge into: lp:goyaml
Diff against target: 12 lines (+1/-1)
1 file modified
emitterc.go (+1/-1)
To merge this branch: bzr merge lp:~niemeyer/goyaml/restore-semantics
Reviewer Review Type Date Requested Status
goyaml maintainers Pending
Review via email: mp+195212@code.launchpad.net

Description of the change

Revert semantic change in previous revision.

https://codereview.appspot.com/26480044/

To post a comment you must log in.
Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Reviewers: mp+195212_code.launchpad.net,

Message:
Please take a look.

Description:
Revert semantic change in previous revision.

https://code.launchpad.net/~niemeyer/goyaml/restore-semantics/+merge/195212

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/26480044/

Affected files (+3, -1 lines):
   A [revision details]
   M emitterc.go

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: <email address hidden>
+New revision: <email address hidden>

Index: emitterc.go
=== modified file 'emitterc.go'
--- emitterc.go 2013-11-14 02:37:06 +0000
+++ emitterc.go 2013-11-14 12:04:49 +0000
@@ -1012,7 +1012,7 @@
    return true
   }

- if len(value) == 3 && ((value[0] == '-' && value[1] == '-' && value[2]
== '-') || (value[0] == '.' && value[1] == '.' && value[2] == '.')) {
+ if len(value) >= 3 && ((value[0] == '-' && value[1] == '-' && value[2]
== '-') || (value[0] == '.' && value[1] == '.' && value[2] == '.')) {
    block_indicators = true
    flow_indicators = true
   }

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

*** Submitted:

Revert semantic change in previous revision.

R=
CC=
https://codereview.appspot.com/26480044

https://codereview.appspot.com/26480044/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'emitterc.go'
2--- emitterc.go 2013-11-14 02:37:06 +0000
3+++ emitterc.go 2013-11-14 12:06:21 +0000
4@@ -1012,7 +1012,7 @@
5 return true
6 }
7
8- if len(value) == 3 && ((value[0] == '-' && value[1] == '-' && value[2] == '-') || (value[0] == '.' && value[1] == '.' && value[2] == '.')) {
9+ if len(value) >= 3 && ((value[0] == '-' && value[1] == '-' && value[2] == '-') || (value[0] == '.' && value[1] == '.' && value[2] == '.')) {
10 block_indicators = true
11 flow_indicators = true
12 }

Subscribers

People subscribed via source and target branches