Merge lp:~niemeyer/pyjuju/no-regex-option into lp:pyjuju
Proposed by
Gustavo Niemeyer
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Kapil Thangavelu | ||||||||
Approved revision: | 337 | ||||||||
Merged at revision: | 337 | ||||||||
Proposed branch: | lp:~niemeyer/pyjuju/no-regex-option | ||||||||
Merge into: | lp:pyjuju | ||||||||
Diff against target: |
267 lines (+85/-62) 6 files modified
ensemble/formula/config.py (+31/-27) ensemble/formula/tests/repository/dummy/config.yaml (+3/-3) ensemble/formula/tests/repository/wordpress/config.yaml (+1/-1) ensemble/formula/tests/test_config.py (+48/-29) examples/php/config.yaml (+1/-1) examples/wordpress/config.yaml (+1/-1) |
||||||||
To merge this branch: | bzr merge lp:~niemeyer/pyjuju/no-regex-option | ||||||||
Related bugs: |
|
||||||||
Related blueprints: |
The Formula Store
(Undefined)
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Kapil Thangavelu (community) | Approve | ||
William Reade (community) | Approve | ||
Review via email: mp+73448@code.launchpad.net |
Description of the change
This handles the two changes suggested in the mailing list:
- Drop regex type
- Rename 'str' to 'string'
For the second change, it also introduces backwards compatibility logic
so that we can continue to work with 'str' for the moment while we warn
authors to move out of it.
To post a comment you must log in.
[0]
+ _warned_ str_is_ obsolete = False
Unused?
Otherwise +1.