Merge lp:~niels-avonds/gala/gala-fixes into lp:gala

Proposed by Niels Avonds
Status: Merged
Merged at revision: 57
Proposed branch: lp:~niels-avonds/gala/gala-fixes
Merge into: lp:gala
Diff against target: 26 lines (+9/-4)
1 file modified
src/Main.vala (+9/-4)
To merge this branch: bzr merge lp:~niels-avonds/gala/gala-fixes
Reviewer Review Type Date Requested Status
Garden Gnome (community) Approve
Review via email: mp+108608@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Garden Gnome (gardengnome85) wrote :

Patch looks good to me tested and works fine

Revision history for this message
Garden Gnome (gardengnome85) :
review: Approve
lp:~niels-avonds/gala/gala-fixes updated
54. By Garden Gnome

fixes sellected workspace alignment issue

55. By Tom Beckmann

Fix the little jump when a window is repositioned to the center

56. By Danielle Foré

smoother workspace transition with ease in out sin

57. By Niels Avonds

move_window improvements to fix bug #1008649 and bug #1008653.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Main.vala'
2--- src/Main.vala 2012-06-04 14:03:33 +0000
3+++ src/Main.vala 2012-06-04 18:34:22 +0000
4@@ -185,13 +185,18 @@
5
6 void move_window (Window? window, bool up)
7 {
8- if (window == null || window.is_on_all_workspaces ())
9+ if (window == null)
10 return;
11
12 var idx = screen.get_active_workspace ().index () + ((up)?-1:1);
13- window.change_workspace_by_index (idx, false,
14- screen.get_display ().get_current_time ());
15-
16+
17+ if (idx < 0 || idx >= screen.n_workspaces)
18+ return;
19+
20+ if (!window.is_on_all_workspaces ())
21+ window.change_workspace_by_index (idx, false,
22+ screen.get_display ().get_current_time ());
23+
24 screen.get_workspace_by_index (idx).activate_with_focus (window,
25 screen.get_display ().get_current_time ());
26 }

Subscribers

People subscribed via source and target branches