Merge ~niedbalski/ubuntu/+source/percona-xtradb-cluster-5.5:fix-ppc64build into ~paelzer/ubuntu/+source/percona-xtradb-cluster-5.5:fix-lp1657256-t

Proposed by Jorge Niedbalski
Status: Merged
Merge reported by: Christian Ehrhardt 
Merged at revision: 549a66d717b446b9002ca6133da1362e46341662
Proposed branch: ~niedbalski/ubuntu/+source/percona-xtradb-cluster-5.5:fix-ppc64build
Merge into: ~paelzer/ubuntu/+source/percona-xtradb-cluster-5.5:fix-lp1657256-t
Diff against target: 50 lines (+28/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/fix_time_collector_lock_type.patch (+20/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Christian Ehrhardt  Approve
Review via email: mp+332794@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

No need to make an extra package version of this, but I can fix that up while merging.

Thanks for finding the bug and mapping to it.
I approve the change in general and will test it now.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Builds fine now on all arches, thanks.
I'll soon ask (in the bug) for final test from the ppa.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Tests complete and working.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index a28f5fa..154edde 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,10 @@
6+percona-xtradb-cluster-5.5 (5.5.37-25.10+dfsg-0ubuntu0.14.04.6) trusty; urgency=high
7+
8+ * d/p/fix_time_collector_lock_type.patch: Changes time_collector_lock
9+ to be mutable (LP: #1002848).
10+
11+ -- Jorge Niedbalski <jorge.niedbalski@canonical.com> Wed, 25 Oct 2017 11:35:03 -0300
12+
13 percona-xtradb-cluster-5.5 (5.5.37-25.10+dfsg-0ubuntu0.14.04.5) trusty; urgency=medium
14
15 [ Mario Splivalo ]
16diff --git a/debian/patches/fix_time_collector_lock_type.patch b/debian/patches/fix_time_collector_lock_type.patch
17new file mode 100644
18index 0000000..c770eb0
19--- /dev/null
20+++ b/debian/patches/fix_time_collector_lock_type.patch
21@@ -0,0 +1,20 @@
22+Description: Changes time_collector_lock to be mutable.
23+Fixes (LP: #1002848).
24+
25+Author: Jorge Niedbalski <jorge.niedbalski@canonical.com>
26+Ubuntu-Bug: https://bugs.launchpad.net/percona-server/+bug/1002848
27+
28+
29+diff --git a/sql/query_response_time.cc b/sql/query_response_time.cc
30+index c827317..1161d6c 100644
31+--- a/sql/query_response_time.cc
32++++ b/sql/query_response_time.cc
33+@@ -198,7 +198,7 @@ private:
34+ /* The lock for atomic operations on m_count and m_total. Only actually
35+ used on architectures that do not have atomic implementation of atomic
36+ operations. */
37+- my_atomic_rwlock_t time_collector_lock;
38++ mutable my_atomic_rwlock_t time_collector_lock;
39+ uint32 m_count[OVERALL_POWER_COUNT + 1];
40+ uint64 m_total[OVERALL_POWER_COUNT + 1];
41+ };
42diff --git a/debian/patches/series b/debian/patches/series
43index 288ef29..3ec4790 100644
44--- a/debian/patches/series
45+++ b/debian/patches/series
46@@ -8,3 +8,4 @@ fix_standalone_tests.patch
47 fix_tc_log_initialization_on_ppc64.patch
48 fix_duplicate_primary_key.patch
49 fix_power8_crash_under_load.patch
50+fix_time_collector_lock_type.patch

Subscribers

People subscribed via source and target branches