Merge lp:~niedbalski/python-jujuclient/lp-1456332 into lp:python-jujuclient
Proposed by
Jorge Niedbalski
Status: | Superseded | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~niedbalski/python-jujuclient/lp-1456332 | ||||
Merge into: | lp:python-jujuclient | ||||
Diff against target: |
138 lines (+95/-5) 2 files modified
jujuclient.py (+31/-5) test_jujuclient.py (+64/-0) |
||||
To merge this branch: | bzr merge lp:~niedbalski/python-jujuclient/lp-1456332 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tim Van Steenburgh | Pending | ||
Felipe Reyes | Pending | ||
Review via email: mp+259449@code.launchpad.net |
This proposal supersedes a proposal from 2015-05-18.
This proposal has been superseded by a proposal from 2015-05-19.
Description of the change
This patch fixes LP: #1456332
To post a comment you must log in.
One minor quibble: it's not clear what happens if you call Run without providing any machines, services, or units. Is that an error from Juju, or is it the equivalent of calling RunOnAllMachines? It would be great to clarify this in the run() docstring.
Otherwise looks good, pending a successful test run.