Merge lp:~niedbalski/charms/trusty/percona-cluster/fix-default-password-grant into lp:~openstack-charmers-archive/charms/trusty/percona-cluster/trunk

[Jorge Niedbalski]

If no sst-password is specified then , a randomly generated one is created using pwgen. This
password is correctly set on the configuration file ( my.cnf ) but the replication permissions are set incorrectly.

The charm is performing:

GRANT RELOAD, LOCK TABLES, REPLICATION CLIENT ON *.* TO 'sstuser'@'localhost' IDENTIFIED BY 'None'

Replication:

$ juju deploy percona-cluster
$ juju add-unit percona-cluster
$ juju ssh 1 -e service mysql restart

This will fail due to no permissions for perform the reload on the cluster.

The linked branch , fixes this issue.

[Edward Hope-Morley (hopem)]

$ make lint
hooks/percona_hooks.py:91:41: E128 continuation line under-indented for visual indent
make: *** [lint] Error 1

[Jorge Niedbalski (niedbalski)]

Fixed.

niedbalski@theos-mobile:~/src/juju/charms/trusty/percona-cluster$ make lint
W: No icon.svg file.

[Edward Hope-Morley (hopem)]

LGTM, good catch

review: Approve

=== modified file 'hooks/percona_hooks.py'
--- hooks/percona_hooks.py	2014-08-18 15:31:29 +0000
+++ hooks/percona_hooks.py	2014-09-29 18:55:25 +0000
@@ -74,22 +74,28 @@
     elif config('source') is not None:
         add_source(config('source'))
     configure_mysql_root_password(config('root-password'))
-    render_config()  # Render base configuation (no cluster)
+    mysql_password = get_mysql_password(username='sstuser',
+                                        password=config('sst-password'))
+    render_config(mysql_password=mysql_password)
     apt_update(fatal=True)
     apt_install(PACKAGES, fatal=True)
-    configure_sstuser(config('sst-password'))
-
-
-def render_config(clustered=False, hosts=[]):
+    configure_sstuser(mysql_password)
+
+
+def render_config(clustered=False, hosts=[], mysql_password=None):
     if not os.path.exists(os.path.dirname(MY_CNF)):
         os.makedirs(os.path.dirname(MY_CNF))
+
+    if not mysql_password:
+        mysql_password = get_mysql_password(username='sstuser',
+                                            password=config('sst-password'))
+
     context = {
         'cluster_name': 'juju_cluster',
         'private_address': get_host_ip(),
         'clustered': clustered,
         'cluster_hosts': ",".join(hosts),
-        'sst_password': get_mysql_password(username='sstuser',
-                                           password=config('sst-password'))
+        'sst_password': mysql_password,
     }
     context.update(parse_config())
     write_file(path=MY_CNF,