Nux

Merge lp:~nicovdw/nux/fix-for-753083 into lp:nux

Proposed by Nico van der Walt
Status: Merged
Merged at revision: 323
Proposed branch: lp:~nicovdw/nux/fix-for-753083
Merge into: lp:nux
Diff against target: 10 lines (+1/-0)
1 file modified
Nux/StaticText.cpp (+1/-0)
To merge this branch: bzr merge lp:~nicovdw/nux/fix-for-753083
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Review via email: mp+57476@code.launchpad.net

Description of the change

Calls UpdateTextRendering() after the font is changed to prevent text to be cut off due to the geometry not being updated.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thanks Nico for the patch :)

However, it doesn't seem to fix it here (French local) on latest Nux trunk with the French local (the text is still truncated). Is your fix working 100% of the time for you or just some kind of racy?

review: Needs Information
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

ok, I was confusing this bug with another one! /me needs more sleep ;)

Looks good then, nice catch! Merging and sorry for the confusion. :-)

Again, awesome contribution from you, thanks :)

review: Approve
Revision history for this message
Nico van der Walt (nicovdw) wrote :

Thanks Didier. While working on this bug I saw that the combobox is also not resized properly after changing the font. I have opened a new bug report for this - 759763. I'll upload a patch for it soon. Hopefully you can take a nice break when Natty is released - I see you are quite busy nowadays ;-)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Nux/StaticText.cpp'
2--- Nux/StaticText.cpp 2011-04-10 18:23:20 +0000
3+++ Nux/StaticText.cpp 2011-04-13 12:12:34 +0000
4@@ -187,6 +187,7 @@
5 g_free (_font_string);
6 _font_string = g_strdup (font_name);
7
8+ UpdateTextRendering ();
9 QueueDraw ();
10 }
11

Subscribers

People subscribed via source and target branches