Code review comment for lp:~nicopace/charms/trusty/squid-reverseproxy/all-tests

Revision history for this message
Whit Morriss (whitmo) wrote :

while true, I can't recommend merging and pushing to the store while there
is this issue.

-w

On Tue, Mar 10, 2015 at 10:42 AM, nicopace <email address hidden> wrote:

> The test implementation doesn't have to fix existing issues.
> This charm already fails to install without this patch.
> --
>
> https://code.launchpad.net/~nicopace/charms/trusty/squid-reverseproxy/all-tests/+merge/251999
> You are reviewing the proposed merge of
> lp:~nicopace/charms/trusty/squid-reverseproxy/all-tests into
> lp:charms/trusty/squid-reverseproxy.
>

--
---------------
D. Whit Morriss
Developer, Juju Ecosystem
Canonical USA

« Back to merge proposal