Merge lp:~nicopace/charms/trusty/squid-reverseproxy/all-tests into lp:charms/trusty/squid-reverseproxy

[nicopace]

Battery of tests for squid-reverseproxy.
They will all fail, as there is an open bug on this charm: https://bugs.launchpad.net/charms/+source/squid-reverseproxy/+bug/1426152

[Whit Morriss (whitmo)]

Merges cleanly

[Whit Morriss (whitmo)]

https://gist.github.com/whitmo/8a30bbb4bbf9a5b01ac8

Package install and python compatibility issue.

-1 needs fixing

review: Disapprove

[nicopace (nicopace)]

The test implementation doesn't have to fix existing issues.
This charm already fails to install without this patch.

On Tuesday, March 10, 2015, Whit Morriss <email address hidden> wrote:

> Review: Disapprove
>
> https://gist.github.com/whitmo/8a30bbb4bbf9a5b01ac8
>
> Package install and python compatibility issue.
>
> -1 needs fixing
> --
>
> https://code.launchpad.net/~nicopace/charms/trusty/squid-reverseproxy/all-tests/+merge/251999
> You are the owner of
> lp:~nicopace/charms/trusty/squid-reverseproxy/all-tests.
>

--
Ing. Nicolás Pace

[nicopace (nicopace)]

The test implementation doesn't have to fix existing issues.
This charm already fails to install without this patch.

[Whit Morriss (whitmo)]

while true, I can't recommend merging and pushing to the store while there
is this issue.

-w

On Tue, Mar 10, 2015 at 10:42 AM, nicopace <email address hidden> wrote:

> The test implementation doesn't have to fix existing issues.
> This charm already fails to install without this patch.
> --
>
> https://code.launchpad.net/~nicopace/charms/trusty/squid-reverseproxy/all-tests/+merge/251999
> You are reviewing the proposed merge of
> lp:~nicopace/charms/trusty/squid-reverseproxy/all-tests into
> lp:charms/trusty/squid-reverseproxy.
>

--
---------------
D. Whit Morriss
Developer, Juju Ecosystem
Canonical USA

[Whit Morriss (whitmo)]

nico, I'm attempting to contact the maintainers to get the base issues fixed.

=== added file 'tests/00-setup'
--- tests/00-setup	1970-01-01 00:00:00 +0000
+++ tests/00-setup	2015-03-05 18:48:27 +0000
@@ -0,0 +1,16 @@
+#!/bin/bash
+
+# This script sets up the requirements for amulet tests.
+
+set -x 
+
+# Check if amulet is installed before adding the stable repository and updating apt-get.
+dpkg -s amulet
+if [ $? -ne 0 ]; then
+    sudo add-apt-repository -y ppa:juju/stable
+    sudo apt-get update -qq
+    sudo apt-get install -y amulet
+fi
+
+# Install any additional python packages and other required software.
+sudo apt-get install -y python3-requests squidclient

=== added file 'tests/12-nagios.py'
--- tests/12-nagios.py	1970-01-01 00:00:00 +0000
+++ tests/12-nagios.py	2015-03-05 18:48:27 +0000
@@ -0,0 +1,46 @@
+#!/usr/bin/python3
+import amulet
+import requests
+
+seconds = 20000
+
+d = amulet.Deployment(series='trusty')
+
+d.add('squid-reverseproxy')
+d.add('nagios')
+d.add('nrpe-external-master')
+
+d.relate('nagios:monitors', 'squid-reverseproxy:monitors')
+d.relate('nrpe-external-master:general-info', 'squid-reverseproxy:juju-info')
+d.relate('nrpe-external-master:monitors', 'nagios:monitors')
+
+d.expose('nagios')
+
+try:
+    d.setup(timeout=seconds)
+except amulet.helpers.TimeoutError:
+    amulet.raise_status(amulet.SKIP, msg="Environment wasn't stood up in time")
+except:
+    raise
+
+
+##
+# Set relationship aliases
+##
+squid_unit = d.sentry.unit['squid/0']
+nagios_unit = d.sentry.unit['nagios/0']
+
+
+def test_hosts_being_monitored():
+    nagpwd = nagios_unit.file_contents('/var/lib/juju/nagios.passwd').strip()
+    host_url = ("http://%s/cgi-bin/nagios3/status.cgi?"
+                "hostgroup=all&style=hostdetail")
+    r = requests.get(host_url % nagios_unit.info['public-address'],
+                     auth=('nagiosadmin', nagpwd))
+    if not r.text.find('squid'):
+        amulet.raise_status(amulet.ERROR,
+                            msg='Nagios is not monitoring the' +
+                            ' host it supposed to.')
+
+
+test_hosts_being_monitored()

=== added file 'tests/13-squid-apache.py'
--- tests/13-squid-apache.py	1970-01-01 00:00:00 +0000
+++ tests/13-squid-apache.py	2015-03-05 18:48:27 +0000
@@ -0,0 +1,44 @@
+#!/usr/bin/python3
+import amulet
+import requests
+
+seconds = 20000
+
+d = amulet.Deployment(series='trusty')
+
+d.add('apache2')
+d.add('squid-reverseproxy')
+
+d.relate('apache2:website-cache', 'squid-reverseproxy:cached-website')
+
+d.expose('apache2')
+d.expose('squid-reverseproxy')
+
+try:
+    d.setup(timeout=seconds)
+except amulet.helpers.TimeoutError:
+    amulet.raise_status(amulet.SKIP, msg="Environment wasn't stood up in time")
+except:
+    raise
+
+
+##
+# Set relationship aliases
+##
+squid_unit = d.sentry.unit['squid-reverseproxy/0']
+apache_unit = d.sentry.unit['apache2/0']
+
+
+def test_web_proxy():
+    url = 'http://%s/'
+    squid_request = requests.get(url % squid_unit.info['public-address'])
+    apache_request = requests.get(url % apache_unit.info['public-address'])
+    if not squid_request.ok or not apache_request.ok:
+        amulet.raise_status(amulet.FAIL,
+                            msg="Error connecting.")
+    if squid_request.text != apache_request.text:
+        amulet.raise_status(amulet.FAIL,
+                            msg="Squid response different from apache.")
+
+
+test_web_proxy()

=== added file 'tests/14-listening-port.py'
--- tests/14-listening-port.py	1970-01-01 00:00:00 +0000
+++ tests/14-listening-port.py	2015-03-05 18:48:27 +0000
@@ -0,0 +1,50 @@
+#!/usr/bin/python3
+import amulet
+import requests
+
+seconds = 20000
+PORT = 9999
+
+d = amulet.Deployment(series='trusty')
+
+d.add('apache2')
+d.add('squid-reverseproxy')
+
+d.configure('squid-reverseproxy', {
+    'port': PORT
+})
+
+d.relate('apache2:website-cache', 'squid-reverseproxy:cached-website')
+
+d.expose('apache2')
+d.expose('squid-reverseproxy')
+
+try:
+    d.setup(timeout=seconds)
+except amulet.helpers.TimeoutError:
+    amulet.raise_status(amulet.SKIP, msg="Environment wasn't stood up in time")
+except:
+    raise
+
+
+##
+# Set relationship aliases
+##
+squid_unit = d.sentry.unit['squid-reverseproxy/0']
+apache_unit = d.sentry.unit['apache2/0']
+
+
+def test_web_proxy():
+    squid_request = requests.get(
+        'http://%s:%s/' % (squid_unit.info['public-address'], PORT))
+    apache_request = requests.get(
+        'http://%s/' % apache_unit.info['public-address'])
+    if not squid_request.ok or not apache_request.ok:
+        amulet.raise_status(amulet.FAIL,
+                            msg="Error connecting.")
+    if squid_request.text != apache_request.text:
+        amulet.raise_status(amulet.FAIL,
+                            msg="Squid response different from apache.")
+
+
+test_web_proxy()

=== added file 'tests/15-port-options.py'
--- tests/15-port-options.py	1970-01-01 00:00:00 +0000
+++ tests/15-port-options.py	2015-03-05 18:48:27 +0000
@@ -0,0 +1,71 @@
+#!/usr/bin/python3
+import sys
+import time
+import json
+
+import amulet
+import requests
+
+seconds = 20000
+
+d = amulet.Deployment(series='trusty')
+
+d.add('kibana')
+d.add('elasticsearch')
+d.add('logstash-indexer', charm='cs:precise/logstash-indexer')
+
+d.add_unit('elasticsearch', 2)
+
+d.relate('logstash-indexer:cluster', 'elasticsearch:client')
+d.relate('kibana:rest', 'elasticsearch:client')
+
+d.expose('kibana')
+
+try:
+    d.setup(timeout=seconds)
+except amulet.helpers.TimeoutError:
+    amulet.raise_status(amulet.SKIP, msg="Environment wasn't stood up in time")
+except:
+    raise
+
+
+##
+# Set relationship aliases
+##
+kibana_unit = d.sentry.unit['kibana/0']
+elasticsearch_unit = d.sentry.unit['elasticsearch/1']
+
+
+def test_web_interface():
+
+    elasticsearch_unit.run("""
+        curl -X POST 'http://127.0.0.1:9200/person/1' -d '{
+        "info" : {
+                "height" : 2,
+                "width" : 20
+        }
+        }'
+    """)
+
+    time.sleep(3)
+
+    url = 'http://%s/_all/_search' % kibana_unit.info['public-address']
+    r = requests.get(url,
+                     data=json.load(open('11-scale-elastic-query.json')))
+    if not r.ok:
+        amulet.raise_status(amulet.FAIL,
+                            msg="Error connecting.")
+    try:
+        result = r.json()
+        if result['hits']['total'] != 1:
+            amulet.raise_status(amulet.FAIL,
+                                msg="Error inserting value in elasticsearch.")
+    except ValueError:
+        exc_type, value, traceback = sys.exc_info()
+        exc_text = "Exception: (%s) %s. %s" % (value, exc_type, traceback)
+        amulet.raise_status(amulet.FAIL,
+                            msg="Value returned not a valid json." + r.text +
+                            exc_text)
+
+
+test_web_interface()

=== added file 'tests/16-https.py'
--- tests/16-https.py	1970-01-01 00:00:00 +0000
+++ tests/16-https.py	2015-03-05 18:48:27 +0000
@@ -0,0 +1,59 @@
+#!/usr/bin/python3
+from base64 import b64encode
+
+import amulet
+import requests
+
+seconds = 20000
+
+d = amulet.Deployment(series='trusty')
+
+d.add('apache2')
+d.add('squid-reverseproxy')
+
+d.configure('squid-reverseproxy', {
+    'enable_https': True,
+    'ssl_key': b64encode(open('cert.key').read()),
+    'ssl_cert': b64encode(open('cert.cert').read())
+})
+
+d.relate('apache2:website-cache', 'squid-reverseproxy:cached-website')
+
+d.expose('apache2')
+d.expose('squid-reverseproxy')
+
+try:
+    d.setup(timeout=seconds)
+except amulet.helpers.TimeoutError:
+    amulet.raise_status(amulet.SKIP, msg="Environment wasn't stood up in time")
+except:
+    raise
+
+
+##
+# Set relationship aliases
+##
+squid_unit = d.sentry.unit['squid-reverseproxy/0']
+apache_unit = d.sentry.unit['apache2/0']
+
+
+def test_web_proxy():
+    try:
+        squid_request = requests.get(
+            'https://%s/' % squid_unit.info['public-address'],
+            cert=('cert.cert', 'cert.key')
+        )
+        apache_request = requests.get(
+            'http://%s/' % apache_unit.info['public-address'])
+        if not squid_request.ok or not apache_request.ok:
+            amulet.raise_status(amulet.FAIL,
+                                msg="Error connecting.")
+        if squid_request.text != apache_request.text:
+            amulet.raise_status(amulet.FAIL,
+                                msg="Squid response different from apache.")
+    except requests.exceptions.SSLError:
+        amulet.raise_status(amulet.FAIL,
+                            msg="SSL wrongly configured.")
+
+
+test_web_proxy()

=== added file 'tests/17-via.py'
--- tests/17-via.py	1970-01-01 00:00:00 +0000
+++ tests/17-via.py	2015-03-05 18:48:27 +0000
@@ -0,0 +1,52 @@
+#!/usr/bin/python3
+import amulet
+import requests
+
+seconds = 20000
+
+d = amulet.Deployment(series='trusty')
+
+d.add('apache2')
+d.add('squid-reverseproxy')
+
+d.relate('apache2:website-cache', 'squid-reverseproxy:cached-website')
+
+d.expose('apache2')
+d.expose('squid-reverseproxy')
+
+try:
+    d.setup(timeout=seconds)
+except amulet.helpers.TimeoutError:
+    amulet.raise_status(amulet.SKIP, msg="Environment wasn't stood up in time")
+except:
+    raise
+
+
+##
+# Set relationship aliases
+##
+squid_unit = d.sentry.unit['squid-reverseproxy/0']
+apache_unit = d.sentry.unit['apache2/0']
+
+
+def test_via_header():
+    url = 'http://%s/'
+    squid_request = requests.get(url % squid_unit.info['public-address'])
+    # check headers
+    if 'Via' not in squid_request.headers:
+        amulet.raise_status(amulet.FAIL,
+                            msg="Environment wasn't stood up in time")
+
+    # config via off
+    d.configure('squid-reverseproxy', {
+        'via': 'off'
+    })
+    d.sentry.wait()
+
+    # check headers again
+    if 'Via' in squid_request.headers:
+        amulet.raise_status(amulet.FAIL,
+                            msg="Environment wasn't stood up in time")
+
+
+test_via_header()

=== added file 'tests/19-snmp.py'
--- tests/19-snmp.py	1970-01-01 00:00:00 +0000
+++ tests/19-snmp.py	2015-03-05 18:48:27 +0000
@@ -0,0 +1,45 @@
+#!/usr/bin/python3
+import subprocess
+
+import amulet
+
+seconds = 20000
+
+d = amulet.Deployment(series='trusty')
+
+d.add('apache2')
+d.add('squid-reverseproxy')
+
+d.configure('squid-reverseproxy', {
+    'snmp_community': 'juju',
+    'snmp_allowed_ips': '0.0.0.0/0'
+})
+
+d.relate('apache2:website-cache', 'squid-reverseproxy:cached-website')
+
+d.expose('squid-reverseproxy')
+
+try:
+    d.setup(timeout=seconds)
+except amulet.helpers.TimeoutError:
+    amulet.raise_status(amulet.SKIP, msg="Environment wasn't stood up in time")
+except:
+    raise
+
+
+##
+# Set relationship aliases
+##
+squid_unit = d.sentry.unit['squid-reverseproxy/0']
+
+
+def test_snmp():
+    try:
+        subprocess.check_output(
+            "squidclient -h %s mgr:info" % squid_unit.info['public-address'])
+    except subprocess.CalledProcessError:
+        amulet.raise_status(amulet.FAIL,
+                            msg="Wasn't able to connect via SNMP.")
+
+
+test_snmp()

=== added file 'tests/cert.cert'
--- tests/cert.cert	1970-01-01 00:00:00 +0000
+++ tests/cert.cert	2015-03-05 18:48:27 +0000
@@ -0,0 +1,21 @@
+-----BEGIN CERTIFICATE-----
+MIIDXTCCAkWgAwIBAgIJAP8/lbMbA1l3MA0GCSqGSIb3DQEBBQUAMEUxCzAJBgNV
+BAYTAkFVMRMwEQYDVQQIDApTb21lLVN0YXRlMSEwHwYDVQQKDBhJbnRlcm5ldCBX
+aWRnaXRzIFB0eSBMdGQwHhcNMTUwMjI2MTkyMzQ0WhcNMTUwMzI4MTkyMzQ0WjBF
+MQswCQYDVQQGEwJBVTETMBEGA1UECAwKU29tZS1TdGF0ZTEhMB8GA1UECgwYSW50
+ZXJuZXQgV2lkZ2l0cyBQdHkgTHRkMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIB
+CgKCAQEA784hdl+HE5Ud8SHfTtaQj2H9QFpBdFb8iNbtJ1v1GG31wiV0fgV6Gkk1
+fyxaaZk4BqJyw59m2nFaF9IqPcXArJ8ZRrz29ZNrL+m7mLJDKBSA4rlpR7ieJew/
+qzyj4cGWWqGtQZQW7KaF+qVrHCZV3WWtyGhe+u8TG72AW02utucwlHmtHz5W6jKk
+VTVfGv0kMvoWCbsdS0YWm6J3Zg25zNEzg+38fOTuZPJ21lM8z5KfvJ5Ee/hmM9qO
+GPJhzAoXRY9OXTCnESrJFg3GY8hkzog7eoQcDh05u7ymkmLnuYJAMOOyZky4lPdk
+L2U78o9XoXpf0FhjsOJZ/Rxex8q/xQIDAQABo1AwTjAdBgNVHQ4EFgQUR/QwCSZo
+j+OSEop1WSLQ0qZe0cEwHwYDVR0jBBgwFoAUR/QwCSZoj+OSEop1WSLQ0qZe0cEw
+DAYDVR0TBAUwAwEB/zANBgkqhkiG9w0BAQUFAAOCAQEAPbp7oHahP3h4Yz9oZwYJ
+gMIZUizqs8ifOTTBmpYFCeaG53sGpTsKBRR9NWPkvvMTwLQFlia/qDBrule51+1t
+HOFIMUg9SE8pzwhmhX4+ASav6ylew8ZTBdmsyUq+04srLW3IK4FEfYFJkUl739QG
+7Xe1WtWp4BQ0wnhXTq+XayENup07M4eEtM2RRRI0tsyEgzsp2IXTskIZaKGkm/mj
+FbSOITNFnjrAC4ojs+usC3+3k6ZYZif2xEDnyHjPg4CxH16vJguerR2HH1qPQ+Up
+yBNAMRkkPLv3d90wGVrknvEGn/Pjde+mZN/9tXs3zMZVOOl+KU11tEoyOFbTxU64
+SA==
+-----END CERTIFICATE-----

=== added file 'tests/cert.key'
--- tests/cert.key	1970-01-01 00:00:00 +0000
+++ tests/cert.key	2015-03-05 18:48:27 +0000
@@ -0,0 +1,28 @@
+-----BEGIN PRIVATE KEY-----
+MIIEvgIBADANBgkqhkiG9w0BAQEFAASCBKgwggSkAgEAAoIBAQDvziF2X4cTlR3x
+Id9O1pCPYf1AWkF0VvyI1u0nW/UYbfXCJXR+BXoaSTV/LFppmTgGonLDn2bacVoX
+0io9xcCsnxlGvPb1k2sv6buYskMoFIDiuWlHuJ4l7D+rPKPhwZZaoa1BlBbspoX6
+pWscJlXdZa3IaF767xMbvYBbTa625zCUea0fPlbqMqRVNV8a/SQy+hYJux1LRhab
+ondmDbnM0TOD7fx85O5k8nbWUzzPkp+8nkR7+GYz2o4Y8mHMChdFj05dMKcRKskW
+DcZjyGTOiDt6hBwOHTm7vKaSYue5gkAw47JmTLiU92QvZTvyj1ehel/QWGOw4ln9
+HF7Hyr/FAgMBAAECggEBAJ4a8LMD7qH5mcEmzP1EuBDg0UFBgJA83ck2sytVFLZj
+oTm8yh5gbA2yoOPVEVM4Itk096eEjCKPw4+bECCkJhFp4BdkdQqahHwVhYr6VQ6y
+3fsdtY0E6rgkGCJFG+O3Z/MfT4TCJ48lh4Ym1AS+PbR32mkcbyrQv291tI/+GqgZ
+ZGw1EWcILqVaH1VCfV0ApbIdiWK5jT571mqTcp6I55RQC3gzFGU6jNnGY7A8Rp4X
+Nouhwta+eAU6bTNRzFi9skB9YGrsCYz9pWK6BMKbRMZHUiNcshAg8qH+HMVj9U+z
+ufLid4XmTdA4JsAWkUT39v3F4hjudGDaE7Q9OGY/BKECgYEA/6h98O/aQv8C+NWT
+Nr0G/PdXtI5Ka1Je+HCPn4vHQf/g0Y0xwIgSgKXexhSgJm/aqvZvP4KsptjGDTdW
+oQ9kxDfc27zXlb5zaJAHSzm7KQud9K97lm1a4kImfEtyVNx99dNHp6K7jxYfa6XP
+fch9A0U5jD8227yLGzbOMkmc5u0CgYEA8CA2Z1lPgloObCM9KWUf2l+SdUr1dji3
+mLNFbtZrzgDmmKvEVGlg9uatFv7Omj/bSYihVujILeN8z583YPSD8FdTTb5Ob5vF
+xBFoP1tSPfNFm+7Ls9dzLWj1HZttbS2rW2VBf51M7FZ0iXQ39vYQMmbOTAdicjJ5
+7NEGCXIRCTkCgYAjqKewVHQYBiOu+3MmHmV8IS+9gl9E6t9OPbz6nu9y+DKuZ8g5
+t4EFKp2Q+U2BLvbMA8VukVZtiyzMqRxPKKuAZt5KU+OqAj9spTIvPuUpC3LDrzpI
+uAYGKv3dNlTDG2ICSK7k5eDNS2OkiyMOw0kUjLJDKooHShwI9rL59qSI3QKBgC9Y
+iqGSEIVJMHLN9+9DiyZJld0erItk335ySoxyJst1jgIoTAvAw2erUBGqqB3t3VUA
+ZZ93QpEZu7BMWmT5kVJARaKclWaYNkRUklN7tBmW7/CxAuUw4/reKQZvcQIH8TOS
+IXoCD/rBiTTY/3foSIVHlAGVqymNHlE9XY1bOlSxAoGBAMB5I+aa7r8e9R3b7hT4
+dBGg/mlF0GVQFYJWrye3UWmxzM92pRH1FpIJgm1V0jGO3EAYWnxVcvaPsWmh2S01
+ZlYNnSkRMtAynTHDQktW78/xgNWthqMG3HRLMfZM+WkQfWz3lygLViB2l+JSsSS8
+MVvnClZPQ386RtYBxVlPQL2A
+-----END PRIVATE KEY-----