Code review comment for lp:~nicopace/charms/trusty/python-django/allowed_host_patch

Revision history for this message
Kevin W Monroe (kwmonroe) wrote :

I was able to verify the 400 errors without your changes, and I saw the default hostname/fqdn/ip were not being set in ./juju-settings/30-allowed.py.

I then applied your changes and verified successful page requests as well as correct defaults in 30-allowed.py when django_allowed_hosts is empty.

We'll get an official ~charmer ack soon, but until then, +1 LGTM. Thanks for the fix!

review: Approve

« Back to merge proposal