Merge lp:~nicolas-doffay/ubuntu-ui-toolkit/ubuntu-shape-option-selector into lp:ubuntu-ui-toolkit

[Nicolas d'Offay]

Themed UbuntuShape OptionSelector.

Added UbuntuShape OptionSelector to components with Ambiance, SuruDark and SuruGradient themes.

[Cris Dywan (kalikiana)]

selectedIndex needs "\qmlproperty int selectedIndex" to make it show the type in the docs.

"scrollContainer" seems a little magic - I'm seeing this for the first time and there's no type check. I have a "flickable" property elsewhere… does this expect a flickable? Or some other component?

How about documenting that "values" is indeed a list model? One might not expect that it's supported.

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:633
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/391/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1478/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/248/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/248/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1482/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/391/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:634
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/394/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1489/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/251/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/251/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1493/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/394/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:635
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/405/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1526
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/262
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/262
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/262/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1530
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1530/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1291

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/405/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:636
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/414/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1551
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/271
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/271
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/271/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1555
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1555/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1312

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/414/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:639
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/418/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1582
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/275
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/275
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/275/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1586
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1586/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1339

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/418/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:640
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/420/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1589/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/277/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/277/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1593/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/420/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:641
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/421/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1594
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/278
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/278
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/278/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1598
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1598/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1348

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/421/rebuild

review: Needs Fixing (continuous-integration)

[Michał Sawicz (saviq)]

There are a few visual issues - compare the two images:

http://ubuntuone.com/6OMAdfdJG4nACLEbqJJTYj
http://ubuntuone.com/3RBKZ3CYARvYRk0QN0JqGZ

* the only change there is expanding the list, but text shifts
* grey highlight overlays the borders (are you using an UbuntuShape with a ShaderEffectSource for this?)
* the border shape changes weird when expanding (like at the top it gets pretty thick)
* the chevron and "downward caret" signs are replaced in one frame - do we have design guidance on what the transition should be?
* same for the selected item hightlight - shouldn't there be a transition when you change the selection in the "expanded" OptionSelector?
* where is the full-width OptionSelector? And is it desired that ValueSelector isn't there in the gallery any more?

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:642
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/422/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1599
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/279
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/279
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/279/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1603
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1603/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1353

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/422/rebuild

review: Needs Fixing (continuous-integration)

[Nicolas d'Offay (nicolas-doffay)]

Good points Saviq. Design's guidance is certainly required. The grey highlight was dealt with in a separate branch for the SDK. It was totally removed since it wasn't required in any components. Unsure as to why this is still here, going to do some digging.

Regarding the full width Option Selector, that will be landed immediatly after this is. They have been split into two separate components as per Florian's request.

The value selector is going to be deprecated, so I figured it would be a good idea to remove it from the gallery.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:643
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/423/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1603
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/280
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/280
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/280/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1607
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1607/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1357

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/423/rebuild

review: Needs Fixing (continuous-integration)

[Cris Dywan (kalikiana)]

Which branch are you referring to wrt the grey highlight? Can you merge the changes here now?

And to re-cap, these design questions need to be resolved:
* the only change there is expanding the list, but text shifts
* the border shape changes weird when expanding (like at the top it gets pretty thick)
* the chevron and "downward caret" signs are replaced in one frame
* shouldn't there be a transition when you change the selection in the "expanded" OptionSelector?

review: Needs Information

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:644
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/457/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1869
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/314
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/314
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/314/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1874
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1874/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1599

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/457/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:645
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/458/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1877
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/315
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/315
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/315/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1882
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1882/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1606

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/458/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:646
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/459/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1879/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/316/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/316/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1884/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/459/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:647
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/460/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1881/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/317/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/317/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1886/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/460/rebuild

review: Needs Fixing (continuous-integration)

[Nicolas d'Offay (nicolas-doffay)]

The issue with the UbuntuShape will hopefully be addressed by Loic's refactoring of it. Holding off on that 'til then.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:648
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/466/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1904/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/323/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/323/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1909/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/466/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:649
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/467/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1905/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/324/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/324/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1910/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/467/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:651
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/468/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1943/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/325/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/325/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1948/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/468/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:652
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/475/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1978/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/332/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/332/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1983/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/475/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:653
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/476/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1981/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/333/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/333/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1986/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/476/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:653
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/478/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1983/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/335/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/335/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1988/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/478/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:654
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/479/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1987/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/336/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/336/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1992/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/479/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:655
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/483/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2011/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/340/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/340/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2016/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/483/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:657
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/484/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2013/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/341/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/341/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2018/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/484/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:658
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/485/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2023/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/342/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/342/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2028/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/485/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:659
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/486/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2028/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/343/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/343/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2033/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/486/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:660
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/491/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2059/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/348/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/348/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2064/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/491/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:661
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/492/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2065/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/349/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/349/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2070/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/492/rebuild

review: Needs Fixing (continuous-integration)

[Cris Dywan (kalikiana)]

listItemClicked is missing from components.api.

Shouldn't listItemClicked() come after changing the values? Otherwise a callback handling this would see the old state with no easy way to see what will happen.

review: Needs Fixing

[Nicolas d'Offay (nicolas-doffay)]

I named it incorrectly! Good point about the state checking too. Moved it to the end.

[Cris Dywan (kalikiana)]

Nice stuff.

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:662
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/493/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2072/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/350/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/350/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2077/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/493/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:663
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/494/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2084/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/351/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/351/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2089/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/494/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:665
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/495/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2087/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/352/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/352/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2092/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/495/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:666
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/496/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2103/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/353/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/353/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2108/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/496/rebuild

review: Needs Fixing (continuous-integration)

[Michał Sawicz (saviq)]

The animations are incorrect:
* when expanding, there should be no pause before the tick replaces the chevron - according to design, the chevron should finish fading out when the expansion finished, and that's when the tick is supposed to fade in
* ticks and chevrons should not cross-fade, but fade-out and fade-in in sequence
* ticks should fade-out/fade-in when changing positions

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:668
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/497/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2104/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/354/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/354/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2109/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/497/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:669
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/499/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2109/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/356/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/356/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2114/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/499/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:672
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/500/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2146/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/357/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/357/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2152/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/500/rebuild

review: Needs Fixing (continuous-integration)

[Michał Sawicz (saviq)]

* the first divider does not fade-out / in, the design says that all of them should.
* the chevron/tick fade-out/fade-in is only started *after* the expansion happened, the chevron fade-out should finish with the expansion and then the tick fade-in should start

Something is wrong with first item's tick animation, in gallery:
* expand the expandable selector
* observe the first item's tick
* select a different option - the first item's tick flickers

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:676
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/501/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2152/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/358/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/358/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2158/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/501/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:678
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/503/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2159/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/360/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/360/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2165/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/503/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:681
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/505/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2173/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/362/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/362/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2179/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/505/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:685
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/507/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2183/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/364/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/364/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2189/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/507/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:686
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/511/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2219/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/368/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/368/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2225/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/511/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:687
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/512/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2225/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/369/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/369/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2231/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/512/rebuild

review: Needs Fixing (continuous-integration)

[Michał Sawicz (saviq)]

This looks good now!

review: Approve (functional)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:690
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/513/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2227/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/370/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/370/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2233/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/513/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:692
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/514/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2230/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/371/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/371/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2236/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/514/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:693
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/518/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2276
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/375
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/375
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/375/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2282
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2282/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1938

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/518/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:694
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/522/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2286
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/379
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/379
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/379/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2292
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2292/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1947

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/522/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:695
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/526/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2305/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/383/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/383/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2311/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/526/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:697
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/536/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2443/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/393/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/393/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2449/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/536/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:698
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/544/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2467/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/401/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/401/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2473/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/544/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:699
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/548/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2482/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/405/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/405/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2488/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/548/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:700
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/549/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2490/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/406/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/406/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2496/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/549/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:701
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/550/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2498
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/407
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/407
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/407/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2504
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2504/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2123

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/550/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:700
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/551/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2499/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/408/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/408/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2505/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/551/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:702
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/552/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2500/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/409/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/409/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2506/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/552/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:703
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/553/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2502
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/410
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/410
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/410/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2508
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2508/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2125

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/553/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:704
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/556/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2539/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/413/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/413/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2545/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/556/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:705
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/557/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2542/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/414/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/414/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2548/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/557/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:706
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/558/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2545
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/415
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/415
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/415/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2551
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2551/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2148

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/558/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:710
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/559/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2548
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/416
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/416
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/416/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2554
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2554/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2151

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/559/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:711
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/560/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2550
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/417
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/417
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/417/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2556
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2556/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2153

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/560/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:712
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/563/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2556
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/420
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/420
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/420/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2562
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2562/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2158

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/563/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:713
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/564/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2558
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/421
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/421
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/421/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2564
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2564/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2160

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/564/rebuild

review: Approve (continuous-integration)

[Cris Dywan (kalikiana)]

I'll be damned, r711 looks so dead simple just to fix Jenkins. For record, we need to get better ways to locally test and find such problems.

Love the delegate, nice and simple on the app side. A style we should consider in other places when it makes sense.

There's one problem theming-wise I see: with SuruGradient the icon used in the gallery won't change color. It should be supporting the colorizing done in eg. Icon. It would be nice to move the Image/ShaderEffect of Icon into a component like ColorizedIcon and re-use the code. This could also be used for the chevron.

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:714
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/566/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2569
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/423
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/423
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/423/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2575
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2575/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2170

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/566/rebuild

review: Approve (continuous-integration)

[Nicolas d'Offay (nicolas-doffay)]

I think for this case it would be best to leave ColourizeIcon as it as, instead move the tick and chevron assets to where the "Icon" assets live and use an Image for that component. As for the image, I think the shader should be used in this case.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:717
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/568/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2680
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/425
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/425
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/425/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2686
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2686/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2271

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/568/rebuild

review: Approve (continuous-integration)

[Cris Dywan (kalikiana)]

> I think for this case it would be best to leave ColourizeIcon as it as,
> instead move the tick and chevron assets to where the "Icon" assets live and
> use an Image for that component. As for the image, I think the shader should
> be used in this case.

*nod* I'm fine with leaving that for a separate branch/ discussion. Theming works fine now with the shader.

review: Approve

[lp:~nicolas-doffay/ubuntu-ui-toolkit/ubuntu-shape-option-selector]

716. By Zsombor Egri on 2013-08-28

Fixing Unity8 crash with the latest SDK release. (LP: #1217650)

[Zsombor Egri (zsombi)]

Guys, you made the PopoverForegroundStyle as internal, and that breaks Unity8. So I had to remove this from the trunk and set back for review. Please push it again once fixed.

Thx!

review: Needs Fixing

[lp:~nicolas-doffay/ubuntu-ui-toolkit/ubuntu-shape-option-selector]

717. By Timo Jyrinki on 2013-08-28

Sync changelog.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:718
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/569/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2710/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/426/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/426/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2716/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/569/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:720
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/570/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2711/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/427/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/427/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2717/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/570/rebuild

review: Needs Fixing (continuous-integration)

[lp:~nicolas-doffay/ubuntu-ui-toolkit/ubuntu-shape-option-selector]

718. By PS Jenkins bot on 2013-08-28

Releasing 0.1.46+13.10.20130828-0ubuntu1 (revision 717 from lp:ubuntu-ui-toolkit).

Approved by PS Jenkins bot.

719. By Nicolas d'Offay on 2013-08-28

Comitted revert

720. By Nicolas d'Offay on 2013-08-28

Bazaar seemed to be confused, redid changes.

721. By Nicolas d'Offay on 2013-08-28

Merged trunk.

722. By Nicolas d'Offay on 2013-08-28

Updated docs.

723. By Nicolas d'Offay on 2013-08-28

Removed some text from the OptionSelectorDelegate.

724. By Nicolas d'Offay on 2013-08-28

Changed documentation again, OptionSelector is a component, not a ListItem.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:721
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/573/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2722
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/430
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/430
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/430/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2728
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2728/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2311

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/573/rebuild

review: Approve (continuous-integration)

[Zsombor Egri (zsombi)]

good to go now :)

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:724
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/574/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2726
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/431
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/431
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/431/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2732
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2732/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/2315

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/574/rebuild

review: Approve (continuous-integration)

=== modified file 'CHANGES'
--- CHANGES	2013-08-28 08:06:11 +0000
+++ CHANGES	2013-08-28 12:13:08 +0000
@@ -9,7 +9,7 @@
 
 API Changes
 ***********
-
+* ADDED IN: Empty: property alias divider
 * REMOVED IN ALL: attached property ItemStyle
 * ADDED IN OrientationHelper: property alias rotating
 * ADDED IN OrientationHelper: property alias __orientationHelper

=== modified file 'components.api'
--- components.api	2013-08-28 08:06:11 +0000
+++ components.api	2013-08-28 12:13:08 +0000
@@ -99,6 +99,23 @@
 modules/Ubuntu/Components/Object.qml
 QtObject
     default property internal children
+modules/Ubuntu/Components/OptionSelector.qml
+ListItem.Empty
+    property var model
+    property bool expanded
+    property bool colourImage
+    readonly property int selectedIndex
+    property real containerHeight
+    signal scroll()
+modules/Ubuntu/Components/OptionSelectorDelegate.qml
+ListItem.Standard
+    property string text
+    property string subText
+    property url icon
+    property ListView listView
+    property color assetColour
+    property bool colourImage
+    property string fragColourShader
 modules/Ubuntu/Components/OrientationHelper.qml
 Item
     property bool automaticOrientation

=== modified file 'examples/ubuntu-ui-toolkit-gallery/ListItems.qml'
--- examples/ubuntu-ui-toolkit-gallery/ListItems.qml	2013-08-28 08:06:11 +0000
+++ examples/ubuntu-ui-toolkit-gallery/ListItems.qml	2013-08-28 12:13:08 +0000
@@ -77,18 +77,6 @@
     }
 
     ListItemsSection {
-        title: i18n.tr("Value selector")
-        className: "ValueSelector"
-        delegate: ListItem.ValueSelector {
-            text: i18n.tr("Label")
-            values: [i18n.tr("Value 1"),
-                     i18n.tr("Value 2"),
-                     i18n.tr("Value 3"),
-                     i18n.tr("Value 4")]
-        }
-    }
-
-    ListItemsSection {
         title: i18n.tr("Control")
         className: "Standard"
         delegate: ListItem.Standard {

=== added file 'examples/ubuntu-ui-toolkit-gallery/OptionSelectors.qml'
--- examples/ubuntu-ui-toolkit-gallery/OptionSelectors.qml	1970-01-01 00:00:00 +0000
+++ examples/ubuntu-ui-toolkit-gallery/OptionSelectors.qml	2013-08-28 12:13:08 +0000
@@ -0,0 +1,73 @@
+/*
+ * Copyright 2013 Canonical Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import QtQuick 2.0
+import Ubuntu.Components 0.1
+
+Template {
+    TemplateSection {
+        id: section
+
+        title: i18n.tr("Option Selector")
+        className: "Option Selector"
+
+        Column {
+            id: column
+            anchors.left: parent.left
+            anchors.right: parent.right
+            spacing: units.gu(3)
+
+           OptionSelector {
+                text: i18n.tr("Label")
+                model: [i18n.tr("Value 1"),
+                         i18n.tr("Value 2"),
+                         i18n.tr("Value 3"),
+                         i18n.tr("Value 4")]
+           }
+
+           OptionSelector {
+                text: i18n.tr("Label")
+                expanded: true
+                model: [i18n.tr("Value 1"),
+                         i18n.tr("Value 2"),
+                         i18n.tr("Value 3"),
+                         i18n.tr("Value 4")]
+           }
+
+           OptionSelector {
+               text: i18n.tr("Label")
+               model: customModel
+               expanded: true
+               colourImage: true
+               delegate: selectorDelegate
+           }
+
+           Component {
+               id: selectorDelegate
+
+               OptionSelectorDelegate { text: name; subText: description; icon: image }
+           }
+
+           ListModel {
+               id: customModel
+               ListElement { name: "Name 1"; description: "Description 1"; image: "images.png" }
+               ListElement { name: "Name 2"; description: "Description 2"; image: "images.png" }
+               ListElement { name: "Name 3"; description: "Description 3"; image: "images.png" }
+               ListElement { name: "Name 4"; description: "Description 4"; image: "images.png" }
+           }
+        }
+    }
+}

=== modified file 'examples/ubuntu-ui-toolkit-gallery/WidgetsModel.qml'
--- examples/ubuntu-ui-toolkit-gallery/WidgetsModel.qml	2013-08-28 08:06:11 +0000
+++ examples/ubuntu-ui-toolkit-gallery/WidgetsModel.qml	2013-08-28 12:13:08 +0000
@@ -40,6 +40,11 @@
         source: "TextInputs.qml"
     }
 
+    ListElement {
+        label: "Option Selector"
+        source: "OptionSelectors.qml"
+    }
+
     // Not in design guidelines yet
     ListElement {
         label: "Progress and activity"

=== added file 'examples/ubuntu-ui-toolkit-gallery/images.png'
Binary files examples/ubuntu-ui-toolkit-gallery/images.png	1970-01-01 00:00:00 +0000 and examples/ubuntu-ui-toolkit-gallery/images.png	2013-08-28 12:13:08 +0000 differ
=== modified file 'modules/Ubuntu/Components/ListItems/Empty.qml'
--- modules/Ubuntu/Components/ListItems/Empty.qml	2013-08-28 08:06:11 +0000
+++ modules/Ubuntu/Components/ListItems/Empty.qml	2013-08-28 12:13:08 +0000
@@ -120,34 +120,7 @@
       Set to show or hide the thin bottom divider line (drawn by the \l ThinDivider component).
       This line is shown by default except in cases where this item is the delegate of a ListView.
      */
-    property bool showDivider: __showDivider()
-
-    /*!
-      \internal
-      Method to automatically determine if the bottom divider line should be drawn.
-      This always returns true, unless item is a delegate in a ListView. If in a ListView
-      it will return false only when:
-       + if there is a section.delegate below this item (as thin divider line and section
-         delegate should not both appear)
-       + if this is the final item in the list, and ListView.footer is set (again as thin
-         divider line won't look well with footer below it)
-     */
-    // FIXME: The new design shows dividers everywhere, so if it does not change anymore,
-    //  the __showDivider() function may be removed.
-    function __showDivider() {
-        // if we're not in ListView, always show a thin dividing line at the bottom
-        //if (ListView.view !== null) {
-
-            // if we're last item in ListView, show divider if no footer is defined
-            // and hide it if footer defined
-            //if (index === ListView.view.model.count - 1) return !ListView.footer;
-
-            // if section.delegate is positioned between this item and the next
-            //else if (ListView.section !== ListView.nextSection) return true;
-            //else return false;
-        //}
-        return true;
-    }
+    property bool showDivider: true
 
     /*!
       \internal
@@ -169,6 +142,13 @@
      */
     property alias backgroundIndicator: backgroundIndicator.children
 
+    /*!
+      \preliminary
+      \qmlproperty ThinDivider bottomDividerLine
+      Exposes our the bottom line divider.
+     */
+    property alias divider: bottomDividerLine
+
     /*! \internal
       The spacing inside the list item.
      */
@@ -272,21 +252,6 @@
         }
     }
 
-    Rectangle {
-        id: highlight
-
-        z: -1
-        visible: !priv.removed && emptyListItem.swipingState === "" ? emptyListItem.selected || (emptyListItem.highlightWhenPressed && emptyListItem.pressed) : false
-        anchors {
-            left: parent.left
-            right: parent.right
-            top: parent.top
-        }
-        height: emptyListItem.height - bottomDividerLine.height
-        color: Theme.palette.selected.background
-    }
-
-
     ThinDivider {
         id: bottomDividerLine
         anchors.bottom: parent.bottom
@@ -302,7 +267,7 @@
             left: parent.left
             right: parent.right
             top: parent.top
-            bottom: bottomDividerLine.top
+            bottom: parent.bottom
         }
 
         Item {

=== added file 'modules/Ubuntu/Components/OptionSelector.qml'
--- modules/Ubuntu/Components/OptionSelector.qml	1970-01-01 00:00:00 +0000
+++ modules/Ubuntu/Components/OptionSelector.qml	2013-08-28 12:13:08 +0000
@@ -0,0 +1,198 @@
+/*
+ * Copyright 2012 Canonical Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import QtQuick 2.0
+import "ListItems" as ListItem
+import Ubuntu.Components 0.1 as Components
+
+/*!
+    \qmltype OptionSelector
+    \inqmlmodule Components.Components 0.1
+    \ingroup ubuntu-components
+    \brief Component displaying a single selected value with and optional image and subtext when not expanded, where expanding
+    it opens a listing of all the possible values for selection with an additional option of always being expanded.
+
+    \b{This component is under heavy development.}
+
+    Examples:
+    \qml
+        import Components.Components 0.1
+        Column {
+            width: 250
+            OptionSelector {
+                text: "Standard"
+                model: ["Value 1", "Value 2", "Value 3", "Value 4"]
+            }
+            OptionSelector {
+                text: "Disabled"
+                model: ["Value 1", "Value 2", "Value 3", "Value 4"]
+                enabled: false
+            }
+            OptionSelector {
+                text: "Expanded"
+                model: ["Value 1", "Value 2", "Value 3", "Value 4"]
+                expanded: true
+            }
+            OptionSelector {
+                text: "Icon"
+                icon: Qt.resolvedUrl("icon.png")
+                values: ["Value 1", "Value 2", "Value 3", "Value 4"]
+                selectedIndex: 2
+            }
+            OptionSelector {
+                text: i18n.tr("Label")
+                model: customModel
+                expanded: true
+                colourImage: true
+                delegate: OptionSelectorDelegate { text: name; subText: description; icon: image }
+            }
+            ListModel {
+                id: customModel
+                ListElement { name: "Name 1"; description: "Description 1"; image: "images.png" }
+                ListElement { name: "Name 2"; description: "Description 2"; image: "images.png" }
+                ListElement { name: "Name 3"; description: "Description 3"; image: "images.png" }
+                ListElement { name: "Name 4"; description: "Description 4"; image: "images.png" }
+            }
+        }
+    \endqml
+*/
+
+ListItem.Empty {
+    id: optionSelector
+    __height: column.height
+
+    /*!
+      \preliminary
+      The list of values that will be shown under the label text. This is a model.
+     */
+    property var model
+
+    /*!
+      \preliminary
+      Specifies whether the list is always expanded.
+     */
+    property bool expanded: false
+
+    /*!
+      \preliminary
+      Colours image according to the fieldText colour of the theme, otherwise source colour is maintained.
+     */
+    property bool colourImage: false
+
+    /*!
+      \preliminary
+      ListView delegate.
+     */
+    property Component delegate: OptionSelectorDelegate {}
+
+    /*!
+      \qmlproperty int selectedIndex
+      The index of the currently selected element in our list.
+     */
+    readonly property alias selectedIndex: list.currentIndex
+
+    /*!
+      \qmlproperty real containerHeight
+      Custom height for list container which allows scrolling inside the selector.
+     */
+    property real containerHeight: list.contentHeight
+
+    /*!
+      Called when the optionSelector is either expanded or collapsed.
+     */
+    signal scroll()
+
+    showDivider: false
+
+    Column {
+        id: column
+
+        spacing: units.gu(2)
+        anchors {
+            left: parent.left
+            right: parent.right
+        }
+
+        Label {
+            text: optionSelector.text
+            height: units.gu(2)
+        }
+
+        StyledItem {
+            id: listContainer
+            objectName: "listContainer"
+
+            readonly property url chevron: __styleInstance.chevron
+            readonly property url tick: __styleInstance.tick
+            readonly property color themeColour: Theme.palette.selected.fieldText
+            property bool isExpanded: expanded
+            property bool isFullyExpanded: expanded
+            property bool colourImage: optionSelector.colourImage
+
+            anchors {
+                left: parent.left
+                right: parent.right
+            }
+            state: optionSelector.expanded ? state = "expanded" : state = "collapsed"
+            style: Theme.createStyleComponent("OptionSelectorStyle.qml", listContainer)
+
+            onHeightChanged: scroll()
+
+            states: [ State {
+                    name: "expanded"
+                    when: listContainer.isExpanded
+                    PropertyChanges {
+                        target: listContainer
+                        height: containerHeight
+                    }
+                }, State {
+                    name: "collapsed"
+                    when: !listContainer.isExpanded
+                    PropertyChanges {
+                        target: listContainer
+                        height: list.itemHeight
+                    }
+                }
+            ]
+
+            transitions: [ Transition {
+                UbuntuNumberAnimation {
+                        properties: "height"
+                        duration: Components.UbuntuAnimation.BriskDuration
+                    }
+                }
+            ]
+
+            ListView {
+                id: list
+
+                property int previousIndex: -1
+                readonly property alias expanded: optionSelector.expanded
+                readonly property alias container: listContainer
+                property real itemHeight
+
+                boundsBehavior: Flickable.StopAtBounds
+                interactive: listContainer.height !== list.contentHeight && listContainer.isExpanded ? true : false
+                clip: true
+                currentIndex: 0
+                model: optionSelector.model
+                anchors.fill: parent
+
+                delegate: optionSelector.delegate
+            }
+        }
+    }
+}

=== added file 'modules/Ubuntu/Components/OptionSelectorDelegate.qml'
--- modules/Ubuntu/Components/OptionSelectorDelegate.qml	1970-01-01 00:00:00 +0000
+++ modules/Ubuntu/Components/OptionSelectorDelegate.qml	2013-08-28 12:13:08 +0000
@@ -0,0 +1,324 @@
+/*
+ * Copyright 2012 Canonical Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+/*!
+    \qmltype OptionSelectorDelegate
+    \inqmlmodule Components.Components 0.1
+    \ingroup ubuntu-components
+    \brief OptionSelector delegate which can display text, subtext and an image from a custom model.
+
+    \b{This component is under heavy development.}
+
+    Examples:
+    \qml
+        import Components.Components 0.1
+        Column {
+            width: 250
+            OptionSelector {
+                text: i18n.tr("Label")
+                model: customModel
+                delegate: OptionSelectorDelegate { text: name; subText: description; icon: image }
+            }
+            ListModel {
+                id: customModel
+                ListElement { name: "Name 1"; description: "Description 1"; image: "images.png" }
+                ListElement { name: "Name 2"; description: "Description 2"; image: "images.png" }
+                ListElement { name: "Name 3"; description: "Description 3"; image: "images.png" }
+                ListElement { name: "Name 4"; description: "Description 4"; image: "images.png" }
+            }
+        }
+    \endqml
+*/
+
+import QtQuick 2.0
+import "ListItems" as ListItem
+import Ubuntu.Components 0.1 as Components
+
+ListItem.Standard {
+    id: option
+
+    property string text
+    property string subText
+    property url icon
+    property ListView listView: ListView.view
+    property color assetColour: listView.container.themeColour
+    property bool colourImage: listView.container.colourImage
+    property string fragColourShader:
+        "varying highp vec2 qt_TexCoord0;
+         uniform sampler2D source;
+         uniform lowp vec4 colour;
+         uniform lowp float qt_Opacity;
+
+         void main() {
+            lowp vec4 sourceColour = texture2D(source, qt_TexCoord0);
+            gl_FragColor = colour * sourceColour.a * qt_Opacity;
+        }"
+
+    width: parent.width + units.gu(2)
+    showDivider: index !== listView.count - 1 ? 1 : 0
+    highlightWhenPressed: false
+    selected: ListView.isCurrentItem
+    anchors {
+        left: parent.left
+        leftMargin: units.gu(-2)
+    }
+    onClicked: {
+        if (listView.container.isExpanded) {
+            listView.previousIndex = listView.currentIndex;
+            listView.currentIndex = index;
+        }
+
+        if (!listView.expanded) {
+            listView.container.isExpanded = !listView.container.isExpanded;
+        }
+    }
+
+    Component.onCompleted: {
+        height = listView.itemHeight = childrenRect.height;
+    }
+
+    //Since we don't want to add states to our divider, we use the exposed alias provided in Empty to access it and alter it's opacity from here.
+    states: [ State {
+            name: "dividerExpanded"
+            when: listView.container.state === "expanded" && index === listView.currentIndex
+            PropertyChanges {
+                target: option.divider
+                opacity: 1
+            }
+        }, State {
+            name: "dividerCollapsed"
+            when: listView.container.state === "collapsed" && index === listView.currentIndex
+            PropertyChanges {
+                target: option.divider
+                opacity: 0
+            }
+        }
+    ]
+
+    //As with our states, we apply the transition with our divider as the target.
+    transitions: [ Transition {
+            from: "dividerExpanded"
+            to: "dividerCollapsed"
+            UbuntuNumberAnimation {
+                target: option.divider
+                properties: "opacity"
+                duration: Components.UbuntuAnimation.SlowDuration
+            }
+        }
+    ]
+
+    resources: [
+        Connections {
+            target: listView.container
+            onIsExpandedChanged: {
+                optionExpansion.stop();
+                imageExpansion.stop();
+                optionCollapse.stop();
+                selectedImageCollapse.stop();
+                deselectedImageCollapse.stop();
+
+                if (listView.container.isExpanded === true) {
+                    if (!option.selected) {
+                        optionExpansion.start();
+
+                        //Ensure a source change. This solves a bug which happens occasionaly when source is switched correctly. Probably related to the image.source binding.
+                        image.source = listView.container.tick
+                    } else {
+                        imageExpansion.start();
+                    }
+                } else {
+                    if (!option.selected) {
+                        optionCollapse.start();
+                    } else {
+                        if (listView.previousIndex !== listView.currentIndex)
+                            selectedImageCollapse.start();
+                        else {
+                            deselectedImageCollapse.start();
+                        }
+                    }
+                }
+            }
+        }, SequentialAnimation {
+            id: imageExpansion
+
+            PropertyAnimation {
+                target: image
+                properties: "opacity"
+                from : 1.0
+                to: 0.0
+                duration: Components.UbuntuAnimation.FastDuration
+            }
+            PauseAnimation { duration: Components.UbuntuAnimation.BriskDuration - Components.UbuntuAnimation.FastDuration }
+            PropertyAction {
+                target: image
+                property: "source"
+                value: listView.container.tick
+            }
+            PropertyAnimation {
+                target: image
+                properties: "opacity"
+                from : 0.0
+                to: 1.0
+                duration: Components.UbuntuAnimation.FastDuration
+            }
+        }, PropertyAnimation {
+            id: optionExpansion
+
+            target: option
+            properties: "opacity"
+            from : 0.0
+            to: 1.0
+            duration: Components.UbuntuAnimation.SlowDuration
+        }, SequentialAnimation {
+            id: deselectedImageCollapse
+
+            PauseAnimation { duration: Components.UbuntuAnimation.BriskDuration }
+            PropertyAnimation {
+                target: image
+                properties: "opacity"
+                from : 1.0
+                to: 0.0
+                duration: Components.UbuntuAnimation.FastDuration
+            }
+            PauseAnimation { duration: Components.UbuntuAnimation.FastDuration }
+            PropertyAction {
+                target: image
+                property: "source"
+                value: listView.container.chevron
+            }
+            PropertyAnimation {
+                target: image
+                properties: "opacity"
+                from : 0.0
+                to: 1.0
+                duration: Components.UbuntuAnimation.FastDuration
+            }
+        }, SequentialAnimation {
+            id: selectedImageCollapse
+
+            PropertyAnimation {
+                target: image
+                properties: "opacity"
+                from : 0.0
+                to: 1.0
+                duration: Components.UbuntuAnimation.FastDuration
+            }
+            PauseAnimation { duration: Components.UbuntuAnimation.BriskDuration - Components.UbuntuAnimation.FastDuration }
+            PropertyAnimation {
+                target: image
+                properties: "opacity"
+                from : 1.0
+                to: 0.0
+                duration: Components.UbuntuAnimation.FastDuration
+            }
+            PauseAnimation { duration: Components.UbuntuAnimation.FastDuration }
+            PropertyAction {
+                target: image
+                property: "source"
+                value: listView.container.chevron
+            }
+            PropertyAnimation {
+                target: image
+                properties: "opacity"
+                from : 0.0
+                to: 1.0
+                duration: Components.UbuntuAnimation.FastDuration
+            }
+        }, PropertyAnimation {
+                id: optionCollapse
+                target: option
+                properties: "opacity"
+                from : 1.0
+                to: 0.0
+                duration: Components.UbuntuAnimation.SlowDuration
+        }
+    ]
+
+    Row {
+        spacing: units.gu(1)
+
+        anchors {
+            left: parent.left
+            leftMargin: units.gu(3)
+            verticalCenter: parent.verticalCenter
+        }
+
+        Image {
+            id: leftIcon
+
+            source: icon
+
+            ShaderEffect {
+                property color colour: assetColour
+                property Image source: parent
+
+                width: source.width
+                height: source.height
+                visible: colourImage
+
+                fragmentShader: fragColourShader
+             }
+        }
+
+        Column {
+            anchors {
+                verticalCenter: parent.verticalCenter
+            }
+            Label {
+                text: option.text === "" ? modelData : option.text
+            }
+            Label {
+                text: option.subText
+                visible: option.subText !== "" ? true : false
+                fontSize: "small"
+            }
+        }
+    }
+
+    Image {
+        id: image
+
+        width: units.gu(2)
+        height: units.gu(2)
+        source: listView.expanded ? listView.container.tick : listView.container.chevron
+        opacity: option.selected ? 1.0 : 0.0
+        anchors {
+            right: parent.right
+            rightMargin: units.gu(2)
+            verticalCenter: parent.verticalCenter
+        }
+
+        //Our behaviour is only enabled for our expanded list due to flickering bugs in relation to all this other animations running on the expanding version.
+        Behavior on opacity {
+            enabled: listView.expanded
+
+            UbuntuNumberAnimation {
+                properties: "opacity"
+                duration: Components.UbuntuAnimation.FastDuration
+            }
+        }
+
+        ShaderEffect {
+            property color colour: assetColour
+            property Image source: parent
+
+            width: source.width
+            height: source.height
+
+            fragmentShader: fragColourShader
+         }
+    }
+}

=== added file 'modules/Ubuntu/Components/Themes/Ambiance/OptionSelectorStyle.qml'
--- modules/Ubuntu/Components/Themes/Ambiance/OptionSelectorStyle.qml	1970-01-01 00:00:00 +0000
+++ modules/Ubuntu/Components/Themes/Ambiance/OptionSelectorStyle.qml	2013-08-28 12:13:08 +0000
@@ -0,0 +1,35 @@
+/*
+ * Copyright 2013 Canonical Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+import QtQuick 2.0
+import Ubuntu.Components 0.1
+
+Item {
+    id: ambianceStyle
+
+    property url chevron: "../../artwork/[e-mail]"
+    property url tick: "../../artwork/[e-mail]"
+    property bool colourComponent: true
+
+    UbuntuShape {
+        id: background
+
+        width: styledItem.width
+        height: styledItem.height
+        radius: "medium"
+    }
+}

=== removed file 'modules/Ubuntu/Components/Themes/Ambiance/artwork/[e-mail]'
Binary files modules/Ubuntu/Components/Themes/Ambiance/artwork/[e-mail]	2013-08-28 08:06:11 +0000 and modules/Ubuntu/Components/Themes/Ambiance/artwork/[e-mail]	1970-01-01 00:00:00 +0000 differ
=== modified file 'modules/Ubuntu/Components/Themes/Ambiance/qmldir'
--- modules/Ubuntu/Components/Themes/Ambiance/qmldir	2013-08-28 08:06:11 +0000
+++ modules/Ubuntu/Components/Themes/Ambiance/qmldir	2013-08-28 12:13:08 +0000
@@ -5,6 +5,7 @@
 internal DialogForegroundStyle DialogForegroundStyle.qml
 internal HeaderStyle HeaderStyle.qml
 MainViewStyle 0.1 MainViewStyle.qml
+OptionSelectorStyle 0.1 OptionSelectorStyle.qml
 PopoverForegroundStyle 0.1 PopoverForegroundStyle.qml
 internal ScrollbarStyle ScrollbarStyle.qml
 internal SelectionCursorStyle SelectionCursorStyle.qml

=== added file 'modules/Ubuntu/Components/Themes/SuruDark/OptionSelectorStyle.qml'
--- modules/Ubuntu/Components/Themes/SuruDark/OptionSelectorStyle.qml	1970-01-01 00:00:00 +0000
+++ modules/Ubuntu/Components/Themes/SuruDark/OptionSelectorStyle.qml	2013-08-28 12:13:08 +0000
@@ -0,0 +1,23 @@
+/*
+ * Copyright 2013 Canonical Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+import QtQuick 2.0
+import Ubuntu.Components.Themes.Ambiance 0.1
+
+OptionSelectorStyle {
+    id: suruDarkStyle
+}

=== added file 'modules/Ubuntu/Components/Themes/SuruGradient/OptionSelectorStyle.qml'
--- modules/Ubuntu/Components/Themes/SuruGradient/OptionSelectorStyle.qml	1970-01-01 00:00:00 +0000
+++ modules/Ubuntu/Components/Themes/SuruGradient/OptionSelectorStyle.qml	2013-08-28 12:13:08 +0000
@@ -0,0 +1,27 @@
+/*
+ * Copyright 2013 Canonical Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+import QtQuick 2.0
+import Ubuntu.Components.Themes.Ambiance 0.1
+
+OptionSelectorStyle {
+    id: suruGradientStyle
+
+    chevron: "artwork/[e-mail]"
+    tick: "artwork/[e-mail]"
+    colourComponent: false
+}

=== added directory 'modules/Ubuntu/Components/Themes/SuruGradient/artwork'
=== added file 'modules/Ubuntu/Components/Themes/SuruGradient/artwork/[e-mail]'
Binary files modules/Ubuntu/Components/Themes/SuruGradient/artwork/[e-mail]	1970-01-01 00:00:00 +0000 and modules/Ubuntu/Components/Themes/SuruGradient/artwork/[e-mail]	2013-08-28 12:13:08 +0000 differ
=== added file 'modules/Ubuntu/Components/Themes/SuruGradient/artwork/[e-mail]'
Binary files modules/Ubuntu/Components/Themes/SuruGradient/artwork/[e-mail]	1970-01-01 00:00:00 +0000 and modules/Ubuntu/Components/Themes/SuruGradient/artwork/[e-mail]	2013-08-28 12:13:08 +0000 differ
=== added file 'modules/Ubuntu/Components/artwork/[e-mail]'
Binary files modules/Ubuntu/Components/artwork/[e-mail]	1970-01-01 00:00:00 +0000 and modules/Ubuntu/Components/artwork/[e-mail]	2013-08-28 12:13:08 +0000 differ
=== added file 'modules/Ubuntu/Components/artwork/[e-mail]'
Binary files modules/Ubuntu/Components/artwork/[e-mail]	1970-01-01 00:00:00 +0000 and modules/Ubuntu/Components/artwork/[e-mail]	2013-08-28 12:13:08 +0000 differ
=== modified file 'modules/Ubuntu/Components/qmldir'
--- modules/Ubuntu/Components/qmldir	2013-08-28 08:06:11 +0000
+++ modules/Ubuntu/Components/qmldir	2013-08-28 12:13:08 +0000
@@ -25,6 +25,8 @@
 Scrollbar 0.1 Scrollbar.qml
 internal ModelSectionCounter ModelSectionCounter.qml
 Object 0.1 Object.qml
+OptionSelector 0.1 OptionSelector.qml
+OptionSelectorDelegate 0.1 OptionSelectorDelegate.qml
 Page 0.1 Page.qml
 internal PageTreeNode PageTreeNode.qml
 PageStack 0.1 PageStack.qml

=== modified file 'tests/autopilot/ubuntuuitoolkit/tests/gallery/test_gallery.py'
--- tests/autopilot/ubuntuuitoolkit/tests/gallery/test_gallery.py	2013-08-28 08:06:11 +0000
+++ tests/autopilot/ubuntuuitoolkit/tests/gallery/test_gallery.py	2013-08-28 12:13:08 +0000
@@ -69,11 +69,11 @@
             "Buttons",
             "Slider",
             "Text Field",
+            "Option Selector",
             "Progress and activity",
             "Ubuntu Shape",
             "Icons",
             "Label",
-            "List Items",
         ]
 
         for item in items:
@@ -91,6 +91,7 @@
 
         # now that we have more items, lets continue
         items = [
+            "List Items",
             "Dialog",
             "Popover",
             "Sheet",

=== added file 'tests/unit/tst_components/tst_optionselector.qml'
--- tests/unit/tst_components/tst_optionselector.qml	1970-01-01 00:00:00 +0000
+++ tests/unit/tst_components/tst_optionselector.qml	2013-08-28 12:13:08 +0000
@@ -0,0 +1,107 @@
+/*
+ * Copyright 2012 Canonical Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import QtQuick 2.0
+import QtTest 1.0
+import Ubuntu.Components 0.1
+import Ubuntu.Test 0.1
+
+UbuntuTestCase {
+     name: "OptionSelectorAPI"
+
+     function test_expanded() {
+         var listContainer = findChild(optionSelector, "listContainer");
+
+         optionSelector.expanded = false;
+         compare(listContainer.isExpanded, false, "isExpanded should be true if list is an expanded one");
+
+         optionSelector.expanded = true;
+         compare(listContainer.isExpanded, true, "isExpanded should be false if list is an expanded one");
+     }
+
+     function test_states_and_signal() {
+         var listContainer = findChild(optionSelector, "listContainer");
+
+         signalSpy.signalName = "scroll";
+         compare(signalSpy.count, 0);
+
+         optionSelector.expanded = false;
+         compare(listContainer.state, "collapsed", "state should be collapsed");
+
+         optionSelector.expanded = true;
+         compare(listContainer.state, "expanded", "state should be expanded");
+
+         //Check if scroll signal was fired after expansion.
+         compare(signalSpy.count, 2);
+     }
+
+     function test_text() {
+         compare(optionSelector.text,"","text is '' by default")
+         var newText = "Hello World!";
+         optionSelector.text = newText;
+         compare(optionSelector.text, newText, "set/get");
+     }
+
+     function test_selectedIndex() {
+        compare(optionSelector.selectedIndex, 0, "selectedIndex is 0 by default");
+     }
+
+     function test_values() {
+         compare(optionSelector.values,undefined,"values is undefined by default")
+         var newValues = ["value1","value2","value3"];
+         optionSelector.model = newValues;
+         compare(optionSelector.model, newValues, "set/get");
+     }
+
+     function test_custom_model_delegate() {
+         compare(optionSelector.model, undefined, "model is undefined by default");
+         optionSelector.model = customModel;
+         optionSelector.delegate = selectorDelegate;
+         compare(optionSelector.model, customModel, "Model wasn't set correctly.");
+         compare(optionSelector.delegate, selectorDelegate, "Delegate hasn't been set correctly");
+     }
+
+     Rectangle {
+         id: testItem
+     }
+
+     OptionSelector {
+         id: optionSelector
+
+         SignalSpy {
+             id: signalSpy
+             target: optionSelector
+         }
+     }
+
+     OptionSelector {
+         id: optionSelectorCustomModel
+     }
+
+     Component {
+         id: selectorDelegate
+
+         OptionSelectorDelegate { text: name; subText: description }
+     }
+
+     ListModel {
+         id: customModel
+         ListElement { name: "Name 1"; description: "Description 1" }
+         ListElement { name: "Name 2"; description: "Description 2" }
+         ListElement { name: "Name 3"; description: "Description 3" }
+         ListElement { name: "Name 4"; description: "Description 4" }
+     }
+}