Merge lp:~nicolariolini/openobject-italia/save_fiscalcode_data into lp:~openobject-italia-core-devs/openobject-italia/italian-addons-7.0

[Nicola Riolini - Micronaet]

Modificato l10n_it_fiscalcode:
Creato in res.partner i campi che accolgono i dati per il calcolo del CF, non li faccio vedere però nelle viste, vengono solamente caricati come default se apro il wizard per il calcolo.
Alla chiusura del wizard, con il "calcola", vengono salvati assieme al valore del CF

La modifica è fatta nel caso avessi sbagliato dei dati: cancello il CF, richiamo il wizard e non devo riscriverli per forza tutti

[lp:~nicolariolini/openobject-italia/save_fiscalcode_data]

230. By Nicola Riolini - Micronaet on 2013-11-08

Cambiato un commento errato

[Lorenzo Battistini (elbati)]

riga 86 del diff:
anche senza mettere
context="{'partner_id':active_id,}"
poi non riusciresti comunque a recuperare il partner tramite
context.get('active_id')
?

Inoltre sarebbe una buona cosa (wishlist) se riuscissi a dare una ripassata al codice con PEP8
https://pypi.python.org/pypi/pep8
e pyflakes
https://pypi.python.org/pypi/pyflakes

Così iniziamo a usare codice migliore anche per i moduli italiani.

review: Needs Information

[lp:~nicolariolini/openobject-italia/save_fiscalcode_data]

231. By Nicola Riolini - Micronaet on 2013-11-08

Tolto partner_id nel context non necessario leggendo active_id

[Nicola Riolini - Micronaet (nicolariolini)]

Come al solito hai ragione Lorenzo :), errore mio, ho messo active_id (ho erroneamente visto i valori differenti nel debug pensando che active_id fosse l'id del wizard, non devo più lavorare dopo le 19 :) )

Sto ripassando in questi giorni la PEP8, non fa mai male, a tal proposito, ho visto che è commentato molto spesso in italiano, che facciamo per i commenti?
Anche se non voglio mettere l'inglese dappertutto credo sia più corretto per aiutare anche quelli che prendono spunto dai moduli l10n_it

[Lorenzo Battistini (elbati)]

On 11/08/2013 09:49 AM, Nicola Riolini - Micronaet wrote:
> Sto ripassando in questi giorni la PEP8, non fa mai male, a tal proposito, ho visto che è commentato molto spesso in italiano, che facciamo per i commenti?
> Anche se non voglio mettere l'inglese dappertutto credo sia più corretto per aiutare anche quelli che prendono spunto dai moduli l10n_it

In generale, e quando possibile, sì, sarebbe bene usare l'inglese anche
nei commenti.

[lp:~nicolariolini/openobject-italia/save_fiscalcode_data]

232. By Nicola Riolini - Micronaet on 2013-11-08

Normalizzazione file py in PEP8
Non finito compunte_fc perche' devo ancora capire bene come vuole
l'intentazione :)

[Nicola Riolini - Micronaet (nicolariolini)]

Ho rivisto un po' i moduli py in pep8... che tribulata!!! :)
mancano un paio di indentazioni da correggere nel py del wizard

[Lorenzo Battistini (elbati)]

On 11/08/2013 10:46 AM, Nicola Riolini - Micronaet wrote:
> Ho rivisto un po' i moduli py in pep8... che tribulata!!! :)
> mancano un paio di indentazioni da correggere nel py del wizard

Ecco:
https://code.launchpad.net/~agilebg/openobject-italia/imp_save_fiscalcode_data/+merge/194477
<https://code.launchpad.net/%7Eagilebg/openobject-italia/imp_save_fiscalcode_data/+merge/194477>

[lp:~nicolariolini/openobject-italia/save_fiscalcode_data]

233. By Nicola Riolini - Micronaet on 2013-11-08

Merge (spero) delle modifiche fatte da Lorenzo

234. By Nicola Riolini - Micronaet on 2013-11-13

Impostato orm al posto di osv
data al posto di update_xml

[Nicola Riolini - Micronaet (nicolariolini)]

Lorenzo ciao, ho finito le migliori/correzioni, ho attualizzato anche: orm al posto di osv e osv_memory, il raise e 'data' al posto di 'update_xml'
Dimmi se ti viene in mente altro.
ciao

[Lorenzo Battistini (elbati)]

Thanks!

review: Approve (code review)

[Nicola Riolini - Micronaet (nicolariolini)]

> Thanks!
To you :)

[Lorenzo Battistini (elbati)]

This project is now hosted on https://github.com/OCA/l10n-italy. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

Unmerged revisions

234. By Nicola Riolini - Micronaet on 2013-11-13

Impostato orm al posto di osv
data al posto di update_xml

233. By Nicola Riolini - Micronaet on 2013-11-08

Merge (spero) delle modifiche fatte da Lorenzo

232. By Nicola Riolini - Micronaet on 2013-11-08

Normalizzazione file py in PEP8
Non finito compunte_fc perche' devo ancora capire bene come vuole
l'intentazione :)

231. By Nicola Riolini - Micronaet on 2013-11-08

Tolto partner_id nel context non necessario leggendo active_id

230. By Nicola Riolini - Micronaet on 2013-11-08

Cambiato un commento errato

229. By Nicola Riolini - Micronaet on 2013-11-08

Finito debug iniziale

228. By Nicola Riolini - Micronaet on 2013-11-07

Correggere errori JSON durante l'attribuzione dei valori default

227. By Nicola Riolini - Micronaet on 2013-11-07

Aggiunta dei campi a res.partner
Aggiunta dei defaults nel wizard
Scrittura dei valori in uscita del wizard per storicizzare
Inizio debug

=== modified file 'l10n_it_fiscalcode/__init__.py'
--- l10n_it_fiscalcode/__init__.py	2013-02-05 16:15:05 +0000
+++ l10n_it_fiscalcode/__init__.py	2013-11-13 12:56:08 +0000
@@ -1,24 +1,23 @@
 # -*- coding: utf-8 -*-
 ##############################################################################
 #
-#    Copyright (C) 2012 Associazione OpenERP Italia
-#    (<http://www.openerp-italia.org>).
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as published by
-#    the Free Software Foundation, either version 3 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#   Copyright (C) 2012 Associazione OpenERP Italia
+#   (<http://www.openerp-italia.org>).
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as published by
+#   the Free Software Foundation, either version 3 of the License, or
+#   (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 ##############################################################################
 
 import fiscalcode
 import wizard
-

=== modified file 'l10n_it_fiscalcode/__openerp__.py'
--- l10n_it_fiscalcode/__openerp__.py	2013-02-05 16:15:05 +0000
+++ l10n_it_fiscalcode/__openerp__.py	2013-11-13 12:56:08 +0000
@@ -23,23 +23,22 @@
     'version': '0.1',
     'category': 'Localisation/Italy',
     'description': """
-This module customizes OpenERP in order to fit italian laws and mores - Account version
-
-Functionalities:
-
-- Fiscal code computation for partner
-
-""",
+        This module customizes OpenERP in order to fit italian laws and mores
+        - Account version
+
+        Functionalities:
+        - Fiscal code computation for partner
+        """,
     'author': 'OpenERP Italian Community',
     'website': 'http://www.openerp-italia.org',
     'license': 'AGPL-3',
-    "depends" : ['base', 'l10n_it_base'],
-    "init_xml" : [
+    "depends": ['base', 'l10n_it_base'],
+    "init_xml": [
         'fiscalcode_view.xml',
         'wizard/compute_fc_view.xml'
         ],
-    "update_xml" : [],
-    "demo_xml" : [],
+    "data": [],
+    "demo_xml": [],
     'test': [
         'test/fiscalcode.yml',
         ],

=== modified file 'l10n_it_fiscalcode/fiscalcode.py'
--- l10n_it_fiscalcode/fiscalcode.py	2013-02-05 16:15:05 +0000
+++ l10n_it_fiscalcode/fiscalcode.py	2013-11-13 12:56:08 +0000
@@ -1,31 +1,32 @@
 # -*- coding: utf-8 -*-
 ##############################################################################
 #
-#    Copyright (C) 2010-2012 Associazione OpenERP Italia
-#    (<http://www.openerp-italia.org>).
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as published by
-#    the Free Software Foundation, either version 3 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#   Copyright (C) 2010-2012 Associazione OpenERP Italia
+#   (<http://www.openerp-italia.org>).
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as published by
+#   the Free Software Foundation, either version 3 of the License, or
+#   (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 ##############################################################################
 
-from osv import fields, osv
-import tools
-import pooler
-from tools.translate import _
-import datetime
-
-class res_partner(osv.osv):
+from openerp.osv import fields, orm
+
+
+class res_partner(orm.Model):
+    ''' Add extra fields in res.partner
+        Add also fiscal code check function
+    '''
+
     _inherit = 'res.partner'
 
     def check_fiscalcode(self, cr, uid, ids, context={}):
@@ -39,13 +40,31 @@
                 return True
 
     _columns = {
-        'fiscalcode': fields.char('Fiscal Code', size=16, help="Italian Fiscal Code"),
-        'individual': fields.boolean('Individual', help="If checked the C.F. is referred to a Individual Person"),
+        'fiscalcode': fields.char(
+            'Fiscal Code', size=16,
+            help="Italian Fiscal Code"),
+        'individual': fields.boolean(
+            'Individual',
+            help="If checked the C.F. is referred to a Individual Person"),
+
+        # Field for save fiscalcode calculation data:
+        'fiscalcode_surname': fields.char('Surname', size=64),
+        'fiscalcode_firstname': fields.char('First name', size=64),
+        'birth_date': fields.date('Date of birth'),
+        'birth_city': fields.many2one('res.city', 'City of birth'),
+        'sex': fields.selection(
+            [('M', 'Male'), ('F', 'Female'), ],
+            "Sex"),
     }
+
     _defaults = {
         'individual': False,
     }
-    _constraints = [(check_fiscalcode, "The fiscal code doesn't seem to be correct.", ["fiscalcode"])]
+
+    _constraints = [
+        (check_fiscalcode, "The fiscal code doesn't seem to be correct.",
+            ["fiscalcode"],)]
+
     _sql_constraints = [
-        ('fiscalcode_uniq', 'unique (fiscalcode, company_id)', 'The fiscal code must be unique per company !'),
-        ]
+        ('fiscalcode_uniq', 'unique (fiscalcode, company_id)',
+         'The fiscal code must be unique per company !'), ]

=== modified file 'l10n_it_fiscalcode/wizard/__init__.py'
--- l10n_it_fiscalcode/wizard/__init__.py	2013-02-05 16:15:05 +0000
+++ l10n_it_fiscalcode/wizard/__init__.py	2013-11-13 12:56:08 +0000
@@ -1,23 +1,22 @@
 # -*- coding: utf-8 -*-
 ##############################################################################
 #
-#    Copyright (C) 2012 Associazione OpenERP Italia
-#    (<http://www.openerp-italia.org>).
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as published by
-#    the Free Software Foundation, either version 3 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#   Copyright (C) 2012 Associazione OpenERP Italia
+#   (<http://www.openerp-italia.org>).
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as published by
+#   the Free Software Foundation, either version 3 of the License, or
+#   (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 ##############################################################################
 
 import compute_fc
-

=== modified file 'l10n_it_fiscalcode/wizard/compute_fc.py'
--- l10n_it_fiscalcode/wizard/compute_fc.py	2013-03-01 11:07:49 +0000
+++ l10n_it_fiscalcode/wizard/compute_fc.py	2013-11-13 12:56:08 +0000
@@ -1,47 +1,92 @@
 # -*- coding: utf-8 -*-
 ##############################################################################
 #
-#    Copyright (C) 2010-2012 Associazione OpenERP Italia
-#    (<http://www.openerp-italia.org>).
-#
-#    This program is free software: you can redistribute it and/or modify
-#    it under the terms of the GNU Affero General Public License as published by
-#    the Free Software Foundation, either version 3 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU Affero General Public License
-#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#   Copyright (C) 2010-2012 Associazione OpenERP Italia
+#   (<http://www.openerp-italia.org>).
+#
+#   This program is free software: you can redistribute it and/or modify
+#   it under the terms of the GNU Affero General Public License as published by
+#   the Free Software Foundation, either version 3 of the License, or
+#   (at your option) any later version.
+#
+#   This program is distributed in the hope that it will be useful,
+#   but WITHOUT ANY WARRANTY; without even the implied warranty of
+#   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#   GNU General Public License for more details.
+#
+#   You should have received a copy of the GNU Affero General Public License
+#   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #
 ##############################################################################
 
-from osv import fields, osv
-import tools
-import pooler
+from openerp.osv import fields, orm
 from tools.translate import _
-
 import datetime
 
-class wizard_compute_fc(osv.osv_memory):
+
+class wizard_compute_fc(orm.TransientModel):
+    ''' Wizard for calculation of fiscalcode
+    '''
 
     _name = "wizard.compute.fc"
     _description = "Compute Fiscal Code"
+
     _columns = {
         'fiscalcode_surname': fields.char('Surname', size=64),
         'fiscalcode_firstname': fields.char('First name', size=64),
         'birth_date': fields.date('Date of birth'),
         'birth_city': fields.many2one('res.city', 'City of birth'),
-        'sex': fields.selection([('M','Male'),
-                                 ('F', 'Female'),
-                                ], "Sex"),
-    }
-
-
-    def _codicefiscale(self, cognome, nome, giornonascita, mesenascita, annonascita, sesso, cittanascita):
+        'sex': fields.selection([('M', 'Male'),
+                                 ('F', 'Female'), ], 'Sex'),
+    }
+
+    _defaults = {
+        # Leggo da res.partner i dati se presenti per impostarli come default:
+        'fiscalcode_surname': (
+            lambda s, cr, uid, c: s.get_default_from_partner(
+                cr, uid, 'fiscalcode_surname', context=c)
+            ),
+        'fiscalcode_firstname': (
+            lambda s, cr, uid, c: s.get_default_from_partner(
+                cr, uid, 'fiscalcode_firstname', context=c)
+            ),
+        'birth_date': (
+            lambda s, cr, uid, c: s.get_default_from_partner(
+                cr, uid, 'birth_date', context=c)
+            ),
+        'birth_city': (
+            lambda s, cr, uid, c: s.get_default_from_partner(
+                cr, uid, 'birth_city', context=c)
+            ),
+        'sex': (
+            lambda s, cr, uid, c: s.get_default_from_partner(
+                cr, uid, 'sex', context=c)
+            ),
+    }
+
+    def get_default_from_partner(self, cr, uid, field, context=None):
+        ''' Legge il valore del campo richiesto da res_partner per proporre
+            il valore di default nel wizard
+        '''
+        if context is None:
+            context = {}
+
+        try:
+            partner_id = context.get('active_id', 0)
+            if not partner_id:
+                return False
+            partner_proxy = self.pool.get('res.partner').browse(
+                cr, uid, partner_id, context=context)
+            res = partner_proxy.__getattr__(field)
+
+            if field == 'birth_city':  # many2one
+                return res.id
+            return res
+        except:  # in caso di errore il campo rimane vuoto
+            return False
+
+    def _codicefiscale(self, cognome, nome, giornonascita, mesenascita,
+                       annonascita, sesso, cittanascita):
 
         MESI = 'ABCDEHLMPRST'
         CONSONANTI = 'BCDFGHJKLMNPQRSTVWXYZ'
@@ -49,48 +94,50 @@
         LETTERE = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ'
 
         REGOLECONTROLLO = {
-            'A':(0,1),   'B':(1,0),   'C':(2,5),   'D':(3,7),   'E':(4,9),
-            'F':(5,13),  'G':(6,15),  'H':(7,17),  'I':(8,19),  'J':(9,21),
-            'K':(10,2),  'L':(11,4),  'M':(12,18), 'N':(13,20), 'O':(14,11),
-            'P':(15,3),  'Q':(16,6),  'R':(17,8),  'S':(18,12), 'T':(19,14),
-            'U':(20,16), 'V':(21,10), 'W':(22,22), 'X':(23,25), 'Y':(24,24),
-            'Z':(25,23),
-            '0':(0,1),   '1':(1,0),   '2':(2,5),   '3':(3,7),   '4':(4,9),
-            '5':(5,13),  '6':(6,15),  '7':(7,17),  '8':(8,19),  '9':(9,21)
+            'A': (0, 1), 'B': (1, 0), 'C': (2, 5), 'D': (3, 7), 'E': (4, 9),
+            'F': (5, 13), 'G': (6, 15), 'H': (7, 17), 'I': (8, 19),
+            'J': (9, 21), 'K': (10, 2), 'L': (11, 4), 'M': (12, 18),
+            'N': (13, 20), 'O': (14, 11), 'P': (15, 3), 'Q': (16, 6),
+            'R': (17, 8), 'S': (18, 12), 'T': (19, 14), 'U': (20, 16),
+            'V': (21, 10), 'W': (22, 22), 'X': (23, 25), 'Y': (24, 24),
+            'Z': (25, 23),
+            '0': (0, 1), '1': (1, 0), '2': (2, 5), '3': (3, 7), '4': (4, 9),
+            '5': (5, 13), '6': (6, 15), '7': (7, 17), '8': (8, 19),
+            '9': (9, 21),
         }
 
         """Funzioni per il calcolo del C.F."""
         def _surname(stringa):
-            """Ricava, da stringa, 3 lettere in base alla convenzione dei C.F."""
+            """Ricava da stringa 3 lettere in base alla convenzione dei C.F."""
             cons = [c for c in stringa if c in CONSONANTI]
             voc = [c for c in stringa if c in VOCALI]
-            chars=cons+voc
-            if len(chars)<3:
-                chars+=['X', 'X']
+            chars = cons + voc
+            if len(chars) < 3:
+                chars += ['X', 'X']
             return chars[:3]
 
         def _name(stringa):
-            """Ricava, da stringa, 3 lettere in base alla convenzione dei C.F."""
+            """Ricava da stringa 3 lettere in base alla convenzione dei C.F."""
             cons = [c for c in stringa if c in CONSONANTI]
             voc = [c for c in stringa if c in VOCALI]
-            if len(cons)>3:
-                cons = [cons[0]] +[cons[2]] + [cons[3]]
-            chars=cons+voc
-            if len(chars)<3:
-                chars+=['X', 'X']
+            if len(cons) > 3:
+                cons = [cons[0]] + [cons[2]] + [cons[3]]
+            chars = cons + voc
+            if len(chars) < 3:
+                chars += ['X', 'X']
             return chars[:3]
 
         def _datan(giorno, mese, anno, sesso):
             """Restituisce il campo data del CF."""
-            chars = (list(anno[-2:]) + [MESI[int(mese)-1]])
-            gn=int(giorno)
-            if sesso=='F':
-                gn+=40
+            chars = (list(anno[-2:]) + [MESI[int(mese) - 1]])
+            gn = int(giorno)
+            if sesso == 'F':
+                gn += 40
             chars += list("%02d" % gn)
             return chars
 
         def _codicecontrollo(c):
-            """Restituisce il codice di controllo, l'ultimo carattere del C.F."""
+            """Restituisce il codice di controllo l'ultimo carat. del C.F."""
             sommone = 0
             for i, car in enumerate(c):
                 j = 1 - i % 2
@@ -99,9 +146,9 @@
             return [LETTERE[resto]]
 
         """Restituisce il C.F costruito sulla base degli argomenti."""
-        nome=nome.upper()
-        cognome=cognome.upper()
-        sesso=sesso.upper()
+        nome = nome.upper()
+        cognome = cognome.upper()
+        sesso = sesso.upper()
         cittanascita = cittanascita.upper()
         chars = (_surname(cognome) +
                  _name(nome) +
@@ -112,18 +159,48 @@
 
     def compute_fc(self, cr, uid, ids, context):
         active_id = context.get('active_id', [])
-        partner = self.pool.get('res.partner').browse(cr, uid, active_id, context)
+        partner = self.pool.get('res.partner').browse(cr,
+                                                      uid,
+                                                      active_id,
+                                                      context)
         form_obj = self.browse(cr, uid, ids, context)
         for fields in form_obj:
-            if not fields.fiscalcode_surname or not fields.fiscalcode_firstname or not fields.birth_date or not fields.birth_city or not fields.sex:
-                raise osv.except_osv(_('Error'), _('One or more fields are missing'))
+            if (
+                not fields.fiscalcode_surname or
+                not fields.fiscalcode_firstname or
+                not fields.birth_date or
+                not fields.birth_city or not fields.sex
+            ):
+                raise orm.except_orm(_('Error'),
+                                     _('One or more fields are missing'))
             if not fields.birth_city.cadaster_code:
-                raise osv.except_osv(_('Error'), _('Cataster code is missing'))
-            birth_date = datetime.datetime.strptime(fields.birth_date, "%Y-%m-%d")
-            CF = self._codicefiscale(fields.fiscalcode_surname, fields.fiscalcode_firstname, str(birth_date.day),
+                raise orm.except_orm(_('Error'),
+                                     _('Cataster code is missing'))
+            birth_date = datetime.datetime.strptime(fields.birth_date,
+                                                    "%Y-%m-%d")
+            CF = self._codicefiscale(
+                fields.fiscalcode_surname,
+                fields.fiscalcode_firstname,
+                str(birth_date.day),
                 str(birth_date.month), str(birth_date.year), fields.sex,
                 fields.birth_city.cadaster_code)
             if partner.fiscalcode and partner.fiscalcode != CF:
-                raise osv.except_osv(_('Error'), _('Existing fiscal code %s is different from the computed one (%s). If you want to use the computed one, remove the existing one') % (partner.fiscalcode, CF))
-            self.pool.get('res.partner').write(cr, uid, active_id, {'fiscalcode': CF, 'individual': True})
+                raise orm.except_orm(
+                    _('Error'),
+                    _("""Existing fiscal code %s is different from the computed
+                         one (%s). If you want to use the computed one, remove
+                         the existing one') % (partner.fiscalcode, CF"""))
+            self.pool.get('res.partner').write(
+                cr, uid, active_id,
+                {'fiscalcode': CF,
+                 'individual': True,
+                 # Storicizzo in res.partner i dati usati dal wizard
+                 'fiscalcode_surname': fields.fiscalcode_surname,
+                 'fiscalcode_firstname': fields.fiscalcode_firstname,
+                 'birth_date': fields.birth_date,
+                 'birth_city': (
+                     fields.birth_city.id if fields.birth_city
+                     else False
+                     ),
+                 'sex': fields.sex, })
         return {}

=== modified file 'l10n_it_fiscalcode/wizard/compute_fc_view.xml'
--- l10n_it_fiscalcode/wizard/compute_fc_view.xml	2013-02-05 16:15:05 +0000
+++ l10n_it_fiscalcode/wizard/compute_fc_view.xml	2013-11-13 12:56:08 +0000
@@ -41,7 +41,7 @@
             <field name="inherit_id" ref="l10n_it_fiscalcode.view_partner_form_fiscalcode_data"/>
             <field name="arch" type="xml">
                 <field name="fiscalcode" position="after">
-                    <button name="%(l10n_it_fiscalcode.action_compute_fc)d" string="Compute F.C." type="action" icon="gtk-execute" colspan="2"/>
+                    <button name="%(l10n_it_fiscalcode.action_compute_fc)d" string="Compute F.C." type="action" icon="gtk-execute" colspan="2" />
                 </field>
             </field>
         </record>