Code review comment for lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month

In everyway, I overwritten the function (instead of overriden) and cover
the case of 'days' too (for other purposes).

2014-06-04 8:12 GMT+02:00 Sergio Corato <email address hidden>:

> Ciao Lorenzo,
> they aren't mutually exclusive, in this way only one of them is needed.
> But it would be better to set field days invisibile if months are set.
>
>
> 2014-06-04 8:03 GMT+02:00 Lorenzo Battistini - Agile BG <
> <email address hidden>>:
>
> On 06/03/2014 10:35 PM, Sergio Corato wrote:
>> > Hi Nicola, Lorenzo, Holger,
>> > what about delete "commercial_month" field and put this code instead?
>> > "if line.months != 0:"
>> >
>> > And in the view set the field "days" required if "months" if false and
>> viceversa:
>> >
>> > <field name="months" attrs="{'required':[('days','=',False)]}"/>
>> >
>> > and
>> >
>> > <xpath expr="/form/group/group/field[@name='days']"
>> position="attributes">
>> > <attribute
>> name="attrs">{'required':[('months','=',False)]}</attribute>
>> > </xpath>
>>
>> Ciao Sergio,
>>
>> this means a user could fill both the 'months' and 'days' fields at the
>> same time, despite they are mutually exclusive.
>>
>>
>> --
>>
>> https://code.launchpad.net/~nicolariolini/account-invoicing/add_module_account_payment_term_month/+merge/212400
>> Your team OpenERP Italia core devs is subscribed to branch
>> lp:~nicolariolini/account-invoicing/add_module_account_payment_term_month.
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~openobject-italia-core-devs
>> Post to : <email address hidden>
>> Unsubscribe : https://launchpad.net/~openobject-italia-core-devs
>> More help : https://help.launchpad.net/ListHelp
>>
>
>