Merge lp:~nickpapior/siesta/4.0-json-time into lp:~albertog/siesta/4.0-json-time
Proposed by
Nick Papior
Status: | Merged |
---|---|
Approved by: | Alberto Garcia |
Approved revision: | 559 |
Merged at revision: | 559 |
Proposed branch: | lp:~nickpapior/siesta/4.0-json-time |
Merge into: | lp:~albertog/siesta/4.0-json-time |
Diff against target: |
136 lines (+29/-40) 2 files modified
Src/timer_tree.f90 (+28/-39) version.info (+1/-1) |
To merge this branch: | bzr merge lp:~nickpapior/siesta/4.0-json-time |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alberto Garcia | Approve | ||
Review via email: mp+337934@code.launchpad.net |
Description of the change
Small changes and removed unnecessary arguments.
These are merely suggestions to remove some of the logic.
I.e. before two (optional) flags where passed, one to decide whether JSON should be written, and another to specify the unit.
It may make more sense to:
If JSON unit is passed, then write. Else, don't write JSON.
Also, used m_io for unit retrieval.
To post a comment you must log in.
Approved, but you were too quick about the border cases, and you had extra braces.
We avoid the m_io dependency for now.