Merge lp:~nickpapior/siesta/4.0-fdf into lp:siesta/4.0
Proposed by
Nick Papior
Status: | Merged |
---|---|
Approved by: | Alberto Garcia |
Approved revision: | 544 |
Merged at revision: | 544 |
Proposed branch: | lp:~nickpapior/siesta/4.0-fdf |
Merge into: | lp:siesta/4.0 |
Diff against target: |
108 lines (+28/-10) 3 files modified
Src/fdf/fdf.F90 (+4/-2) Src/fdf/parse.F90 (+23/-7) version.info (+1/-1) |
To merge this branch: | bzr merge lp:~nickpapior/siesta/4.0-fdf |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alberto Garcia | Approve | ||
Review via email: mp+332964@code.launchpad.net |
Description of the change
Fixed bug, however, I am mainly concerned whether anything will be broken by this.
I can't see why, but good to get a new view on this.
To post a comment you must log in.
I cannot see any downsides.
For the next iteration, we might make the 'line' component of the parsed-line object into
an allocatable character variable, and the token markers into allocatable arrays.