Ubuntu Mirror Charm

Merge ~nick-moffitt/ubuntu-mirror-charm:rt155655 into ubuntu-mirror-charm:master

  1. Git
  2. lp:~nick-moffitt/ubuntu-mirror-charm
  3. rt155655
  4. Merge into master
Proposed by Nick Moffitt
Status: Merged
Approved by: Nick Moffitt
Approved revision: df5b350af59fa482633eeaf284c07842c6edc217
Merged at revision: 37ce6b8e26595f9fe828eeed9bf26494882ca3e4
Proposed branch: ~nick-moffitt/ubuntu-mirror-charm:rt155655
Merge into: ubuntu-mirror-charm:master
Diff against target: 12 lines (+1/-0)
1 file modified
templates/apache-ubuntu.tmpl (+1/-0)
Reviewer Review Type Date Requested Status
Simon Déziel (community) Approve
Laurent Sesquès Approve
Canonical IS Reviewers Pending
Review via email: mp+436434@code.launchpad.net

Commit message

RT#155655 Set max age for caching proxies to a little under an hour

To post a comment you must log in.
Revision history for this message
Canonical IS Mergebot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Nick Moffitt (nick-moffitt) wrote :

This is something we already do on security.ubuntu.com and it apparently helps prevent thundering-herd problems with load behind caching proxies.

Revision history for this message
Laurent Sesquès (sajoupa) :
review: Approve
Revision history for this message
Simon Déziel (sdeziel) wrote :

LGTM but maybe you'd want to have a single appending, like that:

Header append Cache-Control "s-maxage=3300, proxy-revalidate"

Revision history for this message
Simon Déziel (sdeziel) :
review: Approve
Revision history for this message
Canonical IS Mergebot (canonical-is-mergebot) wrote :

Change successfully merged at revision 37ce6b8e26595f9fe828eeed9bf26494882ca3e4

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/templates/apache-ubuntu.tmpl b/templates/apache-ubuntu.tmpl
2index be7c7fd..4cccf42 100644
3--- a/templates/apache-ubuntu.tmpl
4+++ b/templates/apache-ubuntu.tmpl
5@@ -32,6 +32,7 @@
6 ExpiresActive On
7 ExpiresDefault "modification plus 1800 seconds"
8 Header append Cache-Control "proxy-revalidate"
9+ Header append Cache-Control "s-maxage=3300"
10 </Files>
11 # Allow intermediate caches to cache .deb|.udeb|.ddeb files for a day.
12 # This could be increased in the future since deb files are the perfect

Subscribers

People subscribed via source and target branches