Merge ~nick-moffitt/squid-reverseproxy-charm:squid4 into squid-reverseproxy-charm:master

Proposed by Nick Moffitt
Status: Merged
Approved by: 🤖 Canonical IS Review Bot
Approved revision: 514e7adecdcb3b55029f67ab57cf8ca6057e7f48
Merged at revision: d28106987d1900383012a840b9c411d02fb41b95
Proposed branch: ~nick-moffitt/squid-reverseproxy-charm:squid4
Merge into: squid-reverseproxy-charm:master
Diff against target: 13 lines (+1/-1)
1 file modified
templates/main_config.template (+1/-1)
Reviewer Review Type Date Requested Status
🤖 Canonical IS Review Bot Approve
Canonical IS Reviewers Pending
Review via email: mp+444742@code.launchpad.net

Commit message

Make the https_port line squid4-compatible

The only https-capable version of squid before this was a series of
custom builds in PPAs. Thus it makes sense for the charm to now focus
on HTTPS capabilities that exist only in currently-maintained
Debian/Ubuntu packages of squid.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Unable to determine commit message from repository - please click "Set commit message" and enter the commit message manually.

Revision history for this message
🤖 Canonical IS Review Bot (canonical-is-reviewbot) wrote :

Proxy approval for alejdg

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision d28106987d1900383012a840b9c411d02fb41b95

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/templates/main_config.template b/templates/main_config.template
2index b331488..d4a807d 100644
3--- a/templates/main_config.template
4+++ b/templates/main_config.template
5@@ -1,7 +1,7 @@
6 visible_hostname {{ visible_hostname }}
7 http_port {{ config.port }} {{ config.port_options }}
8 {% if config.enable_https -%}
9-https_port {{ config.https_port }} {{ config.https_options }} cert={{ config.ssl_certfile }} key={{ config.ssl_keyfile }} options={{ config.ssl_options }} cipher={{ config.ssl_cipher_suite }} dhparams={{ dhparams_file }}
10+https_port {{ config.https_port }} {{ config.https_options }} tls-cert={{ config.ssl_certfile }} tls-key={{ config.ssl_keyfile }}
11 {% endif -%}
12
13 {% if need_localacl_defs < 0 -%}

Subscribers

People subscribed via source and target branches

to all changes: