Unity

Merge lp:~nick-dedekind/unity/lp1119487.category-redraw into lp:unity

  1. lp1119487.category-redraw
  2. Merge into trunk
Proposed by Nick Dedekind
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 3142
Proposed branch: lp:~nick-dedekind/unity/lp1119487.category-redraw
Merge into: lp:unity
Diff against target: 16 lines (+3/-1)
1 file modified
dash/PlacesGroup.cpp (+3/-1)
To merge this branch: bzr merge lp:~nick-dedekind/unity/lp1119487.category-redraw
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+147391@code.launchpad.net

Commit message

PlacesGroup: Fixed category redrawing

Description of the change

= Problem description =

Dash categories will sometimes redraw without clearing their background.

= The fix =

Clean the background on a full redraw of a dash category.

= Test coverage =

No Test. Visual change only.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Bug is fixed, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dash/PlacesGroup.cpp'
2--- dash/PlacesGroup.cpp 2012-12-17 21:30:27 +0000
3+++ dash/PlacesGroup.cpp 2013-02-08 15:18:26 +0000
4@@ -425,9 +425,11 @@
5 bool forceDraw)
6 {
7 nux::Geometry const& base(GetGeometry());
8-
9 graphics_engine.PushClippingRectangle(base);
10
11+ if (RedirectedAncestor())
12+ graphics::ClearGeometry(GetGeometry());
13+
14 if (ShouldBeHighlighted() && _focus_layer)
15 {
16 nux::Geometry geo(_header_layout->GetGeometry());