Merge lp:~nick-dedekind/unity/lp1054219.home-lens-search into lp:unity

Proposed by Nick Dedekind
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 2779
Proposed branch: lp:~nick-dedekind/unity/lp1054219.home-lens-search
Merge into: lp:unity
Diff against target: 12 lines (+1/-1)
1 file modified
UnityCore/HomeLens.cpp (+1/-1)
To merge this branch: bzr merge lp:~nick-dedekind/unity/lp1054219.home-lens-search
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Michal Hruby (community) Approve
Review via email: mp+127277@code.launchpad.net

Commit message

Fixed re-ordering of shopping lens category in home lens. (LP#1054219)

Description of the change

Fixed re-ordering of shopping lens category in home lens. (LP#1054219)

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

Silly me... +1

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1428/console reported an error when processing this lp:~nick-dedekind/unity/lp1054219.home-lens-search branch.
Not merging it.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Well, it's already landed in lp:unity/6.0 so we better make sure it's in lp:unity too.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'UnityCore/HomeLens.cpp'
2--- UnityCore/HomeLens.cpp 2012-08-31 14:36:57 +0000
3+++ UnityCore/HomeLens.cpp 2012-10-01 13:35:31 +0000
4@@ -986,7 +986,7 @@
5 {
6 unsigned shopping_cat_num = order_vector.at(shopping_index);
7 order_vector.erase(order_vector.begin() + shopping_index);
8- order_vector.insert(order_vector.begin() + 2, shopping_cat_num);
9+ order_vector.insert(order_vector.size() > 2 ? order_vector.begin() + 2 : order_vector.end(), shopping_cat_num);
10 }
11
12 if (cached_categories_order_ != order_vector)