Merge lp:~nick-dedekind/unity/lp1052582.remove-source-manager into lp:unity

Proposed by Nick Dedekind
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 2845
Proposed branch: lp:~nick-dedekind/unity/lp1052582.remove-source-manager
Merge into: lp:unity
Diff against target: 35 lines (+2/-4)
2 files modified
launcher/SoftwareCenterLauncherIcon.cpp (+2/-2)
launcher/SoftwareCenterLauncherIcon.h (+0/-2)
To merge this branch: bzr merge lp:~nick-dedekind/unity/lp1052582.remove-source-manager
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+129943@code.launchpad.net

Commit message

Removed source manager instance from SoftwareCenterLauncherIcon in favour of LauncherIcon instance.

Description of the change

Removed source manager instance from SoftwareCenterLauncherIcon in favour of LauncherIcon instance.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Thanks a lot ;)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'launcher/SoftwareCenterLauncherIcon.cpp'
2--- launcher/SoftwareCenterLauncherIcon.cpp 2012-10-10 16:38:42 +0000
3+++ launcher/SoftwareCenterLauncherIcon.cpp 2012-10-16 16:47:20 +0000
4@@ -130,10 +130,10 @@
5 finished_ = true;
6 needs_urgent_ = true;
7
8- sources_.AddIdle([this]()
9+ _source_manager.AddIdle([this]()
10 {
11 ShowTooltip();
12- sources_.AddTimeout(INSTALL_TIP_DURATION, [this]()
13+ _source_manager.AddTimeout(INSTALL_TIP_DURATION, [this]()
14 {
15 HideTooltip();
16 return false;
17
18=== modified file 'launcher/SoftwareCenterLauncherIcon.h'
19--- launcher/SoftwareCenterLauncherIcon.h 2012-10-10 16:38:42 +0000
20+++ launcher/SoftwareCenterLauncherIcon.h 2012-10-16 16:47:20 +0000
21@@ -23,7 +23,6 @@
22
23 #include <string>
24 #include <UnityCore/GLibDBusProxy.h>
25-#include <UnityCore/GLibSource.h>
26 #include "ApplicationLauncherIcon.h"
27 #include "LauncherDragWindow.h"
28
29@@ -60,7 +59,6 @@
30 nux::ObjectPtr<nux::IOpenGLBaseTexture> icon_texture_;
31 nux::ObjectPtr<LauncherDragWindow> drag_window_;
32 nux::ObjectPtr<Launcher> launcher_;
33- glib::SourceManager sources_;
34 bool finished_;
35 bool needs_urgent_;
36