Merge lp:~nick-dedekind/unity/lp1045298.dash-hide-preview-close into lp:unity

Proposed by Nick Dedekind
Status: Merged
Approved by: Timo Jyrinki
Approved revision: no longer in the source branch.
Merged at revision: 2658
Proposed branch: lp:~nick-dedekind/unity/lp1045298.dash-hide-preview-close
Merge into: lp:unity
Diff against target: 16 lines (+6/-0)
1 file modified
dash/DashView.cpp (+6/-0)
To merge this branch: bzr merge lp:~nick-dedekind/unity/lp1045298.dash-hide-preview-close
Reviewer Review Type Date Requested Status
Nick Dedekind (community) Approve
Omer Akram (community) Approve
Gord Allott (community) Approve
Review via email: mp+122823@code.launchpad.net

Commit message

Close preview when dash is hidden. (LP#1045298)

Description of the change

Close preview when dash is hidden. (LP#1045298)
This causes a preview close to be emitted to the lens (stops music preview daemon).

To post a comment you must log in.
Revision history for this message
Gord Allott (gordallott) wrote :

+1

review: Approve
Revision history for this message
Omer Akram (om26er) wrote :

I have written an autopilot test case for this one, so I guess this one can be allowed to go into trunk and i'll propose the AP test with my other branch.

Revision history for this message
Omer Akram (om26er) wrote :

looks fine to me.

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1211/console reported an error when processing this lp:~nick-dedekind/unity/lp1045298.dash-hide-preview-close branch.
Not merging it.

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

bumping after failed merge.

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1213/console reported an error when processing this lp:~nick-dedekind/unity/lp1045298.dash-hide-preview-close branch.
Not merging it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dash/DashView.cpp'
2--- dash/DashView.cpp 2012-08-22 13:14:18 +0000
3+++ dash/DashView.cpp 2012-09-05 09:25:29 +0000
4@@ -247,6 +247,12 @@
5 home_lens_->view_type = ViewType::HIDDEN;
6 LOG_DEBUG(logger) << "Setting ViewType " << ViewType::HIDDEN
7 << " on '" << home_lens_->id() << "'";
8+
9+ // if a preview is open, close it
10+ if (preview_displaying_)
11+ {
12+ ClosePreview();
13+ }
14 }
15
16 void DashView::SetupViews()