Merge lp:~nick-dedekind/unity/lp1039462.preview-track-scrolling into lp:unity

Proposed by Nick Dedekind
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 2628
Proposed branch: lp:~nick-dedekind/unity/lp1039462.preview-track-scrolling
Merge into: lp:unity
Diff against target: 53 lines (+1/-24)
2 files modified
dash/previews/Tracks.cpp (+1/-21)
dash/previews/Tracks.h (+0/-3)
To merge this branch: bzr merge lp:~nick-dedekind/unity/lp1039462.preview-track-scrolling
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
Review via email: mp+120545@code.launchpad.net

Commit message

Fixed no vertical scrollbar in music preview tracks view. (LP#1039462)

Description of the change

Fixed no vertical scrollbar in music preview tracks view. (LP#1039462)

- Removed drawing override for Tracks view.

To post a comment you must log in.
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Confirmed fix, and code changes look good. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dash/previews/Tracks.cpp'
2--- dash/previews/Tracks.cpp 2012-08-20 14:21:31 +0000
3+++ dash/previews/Tracks.cpp 2012-08-22 12:19:12 +0000
4@@ -81,6 +81,7 @@
5 void Tracks::SetupViews()
6 {
7 SetVScrollBar(new dash::PlacesVScrollBar(NUX_TRACKER_LOCATION));
8+ EnableHorizontalScrollBar(false);
9 layout_ = new nux::VLayout();
10 layout_->SetPadding(0, previews::Style::Instance().GetDetailsRightMargin(), 0, 0);
11 layout_->SetSpaceBetweenChildren(1);
12@@ -131,27 +132,6 @@
13 layout_->RemoveChildObject(pos->second.GetPointer());
14 }
15
16-void Tracks::Draw(nux::GraphicsEngine& gfx_engine, bool force_draw)
17-{
18- nux::Geometry const& base = GetGeometry();
19-
20- gfx_engine.PushClippingRectangle(base);
21- nux::GetPainter().PaintBackground(gfx_engine, base);
22-
23- gfx_engine.PopClippingRectangle();
24-}
25-
26-void Tracks::DrawContent(nux::GraphicsEngine& gfx_engine, bool force_draw)
27-{
28- nux::Geometry const& base = GetGeometry();
29- gfx_engine.PushClippingRectangle(base);
30-
31- if (GetCompositionLayout())
32- GetCompositionLayout()->ProcessDraw(gfx_engine, force_draw);
33-
34- gfx_engine.PopClippingRectangle();
35-}
36-
37 } // namespace previews
38 } // namespace dash
39 } // namespace unity
40
41=== modified file 'dash/previews/Tracks.h'
42--- dash/previews/Tracks.h 2012-08-22 10:03:52 +0000
43+++ dash/previews/Tracks.h 2012-08-22 12:19:12 +0000
44@@ -60,9 +60,6 @@
45 sigc::signal<void, std::string const&> pause;
46
47 protected:
48- virtual void Draw(nux::GraphicsEngine& gfx_engine, bool force_draw);
49- virtual void DrawContent(nux::GraphicsEngine& gfx_engine, bool force_draw);
50-
51 virtual bool AcceptKeyNavFocus() { return false; }
52
53 void SetupViews();