Merge lp:~nick-dedekind/unity-api/lp1475678.surface-occlude into lp:unity-api

[Nick Dedekind]

Support server->client visibility change to stop rendering (lp:#1475678)

Support server->client visibility change to stop rendering (lp:#1475678)

Related MPS:
https://code.launchpad.net/~nick-dedekind/qtubuntu/lp1475678.surface-occlude/+merge/273424
https://code.launchpad.net/~nick-dedekind/unity8/lp1475678.surface-occlude/+merge/273427
https://code.launchpad.net/~nick-dedekind/qtmir/lp1475678.surface-occlude/+merge/273426

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:190
http://jenkins.qa.ubuntu.com/job/unity-api-ci/347/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-amd64-ci/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-armhf-ci/36
        deb: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-armhf-ci/36/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-i386-ci/35
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-amd64-ci/46
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-armhf-ci/46
        deb: http://jenkins.qa.ubuntu.com/job/unity-api-wily-armhf-ci/46/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-i386-ci/46

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-api-ci/347/rebuild

review: Approve (continuous-integration)

[Daniel d'Andrada (dandrader)]

In include/unity/shell/application/Mir.h:

"""
+ Q_ENUMS(Visibility)
"""

Looks like a leftover from a previous version.

review: Needs Fixing

[Nick Dedekind (nick-dedekind)]

> In include/unity/shell/application/Mir.h:
>
> """
> + Q_ENUMS(Visibility)
> """
>
> Looks like a leftover from a previous version.

Removed.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:191
http://jenkins.qa.ubuntu.com/job/unity-api-ci/349/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-amd64-ci/37
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-armhf-ci/38
        deb: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-armhf-ci/38/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-i386-ci/37
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-amd64-ci/48
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-armhf-ci/48
        deb: http://jenkins.qa.ubuntu.com/job/unity-api-wily-armhf-ci/48/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-i386-ci/48

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-api-ci/349/rebuild

review: Approve (continuous-integration)

[Daniel d'Andrada (dandrader)]

Code looks ok.

Will have to bump "set(VERSION 8)" in include/unity/shell/application/CMakeLists.txt before merging. No point in doing so now as that's being changed already by MPs on the queue for landing.

review: Approve

[Michał Sawicz (saviq)]

This needs a version bump in application API CMakeLists.txt

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:193
http://jenkins.qa.ubuntu.com/job/unity-api-ci/356/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-amd64-ci/44
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-armhf-ci/45
        deb: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-armhf-ci/45/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-vivid-i386-ci/44
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-amd64-ci/55
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-armhf-ci/55
        deb: http://jenkins.qa.ubuntu.com/job/unity-api-wily-armhf-ci/55/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-api-wily-i386-ci/55

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-api-ci/356/rebuild

review: Approve (continuous-integration)

[Michał Sawicz (saviq)]

Approving as per superseded.

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2015-10-27 16:33:08 +0000
+++ debian/changelog	2015-10-27 16:33:09 +0000
@@ -1,8 +1,12 @@
 unity-api (7.102) UNRELEASED; urgency=medium
 
+  [ Nick Dedekind ]
+  * Added visibility to surface interface. 
+
+  [ Michael Terry ]
   * Add isTouchApp to ApplicationInfoInterface
 
- -- Michael Terry <[e-mail]>  Tue, 29 Sep 2015 13:36:51 -0400
+ -- Nick Dedekind <[e-mail]>  Tue, 22 Sep 2015 14:43:33 +0100
 
 unity-api (7.101+15.10.20151021-0ubuntu1) wily; urgency=medium
 

=== modified file 'include/unity/shell/application/MirSurfaceInterface.h'
--- include/unity/shell/application/MirSurfaceInterface.h	2015-09-29 11:34:31 +0000
+++ include/unity/shell/application/MirSurfaceInterface.h	2015-10-27 16:33:09 +0000
@@ -66,6 +66,11 @@
     Q_PROPERTY(bool live READ live NOTIFY liveChanged)
 
     /**
+     * @brief Visibility of the surface
+     */
+    Q_PROPERTY(bool visible READ visible NOTIFY visibleChanged)
+
+    /**
      * @brief Orientation angle of the surface
      *
      * How many degrees, clockwise, the UI in the surface has to rotate to match shell's UI orientation
@@ -91,6 +96,8 @@
 
     virtual bool live() const = 0;
 
+    virtual bool visible() const = 0;
+
     virtual Mir::OrientationAngle orientationAngle() const = 0;
     virtual void setOrientationAngle(Mir::OrientationAngle angle) = 0;
     /// @endcond
@@ -99,6 +106,7 @@
     /// @cond
     void typeChanged(Mir::Type value);
     void liveChanged(bool value);
+    void visibleChanged(bool visible);
     void stateChanged(Mir::State value);
     void orientationAngleChanged(Mir::OrientationAngle value);
     void sizeChanged(const QSize &value);