Merge lp:~nick-dedekind/ubuntu-ui-toolkit/tabbar-clipping into lp:ubuntu-ui-toolkit

Proposed by Nick Dedekind
Status: Merged
Approved by: Tim Peeters
Approved revision: 751
Merged at revision: 765
Proposed branch: lp:~nick-dedekind/ubuntu-ui-toolkit/tabbar-clipping
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 11 lines (+1/-0)
1 file modified
modules/Ubuntu/Components/Themes/Ambiance/TabBarStyle.qml (+1/-0)
To merge this branch: bzr merge lp:~nick-dedekind/ubuntu-ui-toolkit/tabbar-clipping
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Tim Peeters Approve
Review via email: mp+186748@code.launchpad.net

Commit message

Added clipping to tab bar.

Description of the change

Added clipping to tab bar.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Tim Peeters (tpeeters) wrote :

Could you please see if any of these bugs are fixed by this also, and if yes, link them here? thanks.

https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1202277
https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1202403

We have some problems with jenkins tests, as you can see, which we need to solve before we can merge this (or anything else).

Revision history for this message
Tim Peeters (tpeeters) wrote :

sorry ignore my previous comment about the other bugs. I was not reading properly; they are not related.

Revision history for this message
Tim Peeters (tpeeters) wrote :

still need to wait for CI fixes before we can merge this.

Revision history for this message
Tim Peeters (tpeeters) wrote :

note that each Item that clips can slow down the app, so we did not add clip here on purpose. Is this clipping also needed for apps, or are they clipped automatically? (I don't have a tablet for testing right now, I test on the phone where this is not an issue).

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> note that each Item that clips can slow down the app, so we did not add clip
> here on purpose. Is this clipping also needed for apps, or are they clipped
> automatically? (I don't have a tablet for testing right now, I test on the
> phone where this is not an issue).

I'm not sure if the stages are clipped so I can't comment on the apps, but I don't think we can really rely on the parent of the tab to clip as it won't necessarily know if it needs to be.
I could directly clip the indicator tabs, but didn't think it was the right place.

Revision history for this message
Tim Peeters (tpeeters) wrote :

sounds fair.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/Themes/Ambiance/TabBarStyle.qml'
2--- modules/Ubuntu/Components/Themes/Ambiance/TabBarStyle.qml 2013-08-01 13:08:32 +0000
3+++ modules/Ubuntu/Components/Themes/Ambiance/TabBarStyle.qml 2013-09-20 11:22:26 +0000
4@@ -235,6 +235,7 @@
5 property bool needsScrolling: buttonRowWidth > tabBar.width
6 interactive: needsScrolling
7 width: needsScrolling ? tabBar.width : buttonRowWidth
8+ clip: needsScrolling
9
10 highlightRangeMode: PathView.NoHighlightRange
11 offset: 0

Subscribers

People subscribed via source and target branches

to status/vote changes: