Merge lp:~nick-dedekind/ubuntu-settings-components/icon-aspect-ratio-crop into lp:~registry/ubuntu-settings-components/trunk
Proposed by
Nick Dedekind
Status: | Superseded | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~nick-dedekind/ubuntu-settings-components/icon-aspect-ratio-crop | ||||
Merge into: | lp:~registry/ubuntu-settings-components/trunk | ||||
Diff against target: |
605 lines (+57/-61) 31 files modified
examples/MessageComponents.qml (+1/-1) examples/OtherComponents.qml (+1/-1) examples/SettingsComponents.qml (+2/-2) examples/TransferComponents.qml (+1/-1) plugins/Ubuntu/Settings/Components/ActionTextField.qml (+1/-1) plugins/Ubuntu/Settings/Components/Calendar.qml (+3/-3) plugins/Ubuntu/Settings/Components/MessageHeader.qml (+3/-4) plugins/Ubuntu/Settings/Components/QuickReply.qml (+1/-1) plugins/Ubuntu/Settings/Components/UbuntuShapeForItem.qml (+5/-7) plugins/Ubuntu/Settings/Menus/AccessPointMenu.qml (+4/-4) plugins/Ubuntu/Settings/Menus/ButtonMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/CalendarMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/CheckableMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/EventMenu.qml (+2/-2) plugins/Ubuntu/Settings/Menus/GroupedMessageMenu.qml (+3/-3) plugins/Ubuntu/Settings/Menus/MediaPlayerMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/PlaybackItemMenu.qml (+7/-7) plugins/Ubuntu/Settings/Menus/ProgressBarMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/ProgressValueMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/SectionMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/SimpleMessageMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/SliderMenu.qml (+3/-3) plugins/Ubuntu/Settings/Menus/SnapDecisionMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/StandardMenu.qml (+2/-2) plugins/Ubuntu/Settings/Menus/SwitchMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/TextMessageMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/TimeZoneMenu.qml (+1/-1) plugins/Ubuntu/Settings/Menus/TransferMenu.qml (+2/-3) plugins/Ubuntu/Settings/Menus/UserSessionMenu.qml (+2/-2) tests/qmltests/Components/tst_ServerPropertySynchroniser.qml (+1/-1) tests/utils/modules/Ubuntu/Test/UbuntuTestCase.qml (+1/-1) |
||||
To merge this branch: | bzr merge lp:~nick-dedekind/ubuntu-settings-components/icon-aspect-ratio-crop | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Albert Astals Cid (community) | Abstain | ||
Sebastien Bacher (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email:
|
This proposal has been superseded by a proposal from 2015-09-15.
Commit message
Crop icons to aspect ratio inside UbuntuShapes.
Description of the change
Crop icons to aspect ratio inside UbuntuShapes.
* Are there any related MPs required for this MP to build/function as expected? Please list.
no
* Did you perform an exploratory manual test run of your code change and any related functionality?
yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
* If you changed the UI, has there been a design review?
yes
To post a comment you must log in.
PASSED: Continuous integration, rev:90 jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- ci/116/ jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- qmltests- vivid/41 jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- vivid-amd64- ci/23 jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- vivid-armhf- ci/23 jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- vivid-armhf- ci/23/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- settings- components- ci/116/ rebuild
http://