Code review comment for lp:~nick-dedekind/qtubuntu/menuTheme

Gerry Boland (gerboland) wrote :

Only 1 thing missed:

=== added file 'src/ubuntuappmenu/menuregistrar.cpp'
+bool isMirClient() {
+ return qgetenv("QT_QPA_PLATFORM") == "ubuntumirclient";
+}
qGuiApp->platformName() would be a safer thing to check.

You've addressed everything else

review: Needs Fixing

« Back to merge proposal