Code review comment for lp:~nick-dedekind/qtmir/polite-close

Daniel d'Andrada (dandrader) wrote :

Code looks good. Didn't try it out on a device yet.

Two problems in the tests though:

1 - ApplicationManagerTests.shellStopsAppCorrectlyBeforeSurfaceCreated is failing:
http://paste.ubuntu.com/12418245/

2 - ApplicationManagerTests::failedApplicationCloseEventualyDeletesApplication test description (the comment above it) doesn't match with what the test does. Probably a copy-and-paste left over.

review: Needs Fixing

« Back to merge proposal