Merge lp:~nick-dedekind/qtmir/fix-dropFrame-before-draw into lp:qtmir
Proposed by
Nick Dedekind
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Gerry Boland | ||||
Approved revision: | 409 | ||||
Merged at revision: | 416 | ||||
Proposed branch: | lp:~nick-dedekind/qtmir/fix-dropFrame-before-draw | ||||
Merge into: | lp:qtmir | ||||
Diff against target: |
144 lines (+46/-5) 5 files modified
src/modules/Unity/Application/mirsurface.cpp (+14/-4) src/modules/Unity/Application/mirsurface.h (+1/-1) src/modules/Unity/Application/mirsurfaceinterface.h (+1/-0) tests/modules/SurfaceManager/CMakeLists.txt (+1/-0) tests/modules/SurfaceManager/mirsurface_test.cpp (+29/-0) |
||||
To merge this branch: | bzr merge lp:~nick-dedekind/qtmir/fix-dropFrame-before-draw | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gerry Boland (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Review via email:
|
Commit message
Fix a crash when dropping a surface frame before Qt draws a surface item.
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
To post a comment you must log in.
To reproduce this you need to make sure the items don't get drawn before a frame is dropped. PhoneStage. qml' PhoneStage. qml 2015-11-04 14:58:05 +0000 PhoneStage. qml 2015-11-17 15:31:55 +0000
Repeater {
id: spreadRepeater
objectName: "spreadRepeater" nManager
delegate: TransformedSpre adDelegate {
id: appDelegate
objectName: "appDelegate" + index
This can easily be done by ensuring it is never drawn.
=== modified file 'qml/Stages/
--- qml/Stages/
+++ qml/Stages/
@@ -403,7 +403,6 @@
- model: root.applicatio