The Sound Menu

Code review comment for lp:~nick-dedekind/indicator-sound/slider-labels

  1. slider-labels
  2. Merge into trunk.14.10
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

> Looks good but these strings need to be wrapped in _() for i18n, e.g.:
>
> - foo.create_slider_menu_item ("Microphone Volume", "indicator.mic-volume",
> ...
> + foo.create_slider_menu_item (_("Microphone Volume"), "indicator.mic-volume",
> ...

Thanks. Done

« Back to merge proposal