indicator-power

Merge lp:~nick-dedekind/indicator-power/lp1240756 into lp:indicator-power/14.04

  1. lp1240756
  2. Merge into trunk.14.04
Proposed by Nick Dedekind
Status: Merged
Approved by: Charles Kerr
Approved revision: 213
Merged at revision: 212
Proposed branch: lp:~nick-dedekind/indicator-power/lp1240756
Merge into: lp:indicator-power/14.04
Diff against target: 12 lines (+1/-1)
1 file modified
src/service.c (+1/-1)
To merge this branch: bzr merge lp:~nick-dedekind/indicator-power/lp1240756
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+193117@code.launchpad.net

Commit message

Removed Label from brightness slider.

Description of the change

Removed Label from brightness slider.
https://wiki.ubuntu.com/Power#Indicator

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:212
http://jenkins.qa.ubuntu.com/job/indicator-power-ci/67/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-power-trusty-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-power-trusty-armhf-ci/4
        deb: http://jenkins.qa.ubuntu.com/job/indicator-power-trusty-armhf-ci/4/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/indicator-power-ci/67/rebuild

review: Approve (continuous-integration)
lp:~nick-dedekind/indicator-power/lp1240756 updated
213. By Nick Dedekind

Use NULL for empty string

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:213
http://jenkins.qa.ubuntu.com/job/indicator-power-ci/68/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-power-trusty-amd64-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-power-trusty-armhf-ci/5
        deb: http://jenkins.qa.ubuntu.com/job/indicator-power-trusty-armhf-ci/5/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/indicator-power-ci/68/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/service.c'
2--- src/service.c 2013-10-10 14:24:18 +0000
3+++ src/service.c 2013-10-30 16:51:45 +0000
4@@ -459,7 +459,7 @@
5
6 get_brightness_range (self, &lo, &hi);
7
8- item = g_menu_item_new ("Brightness", "indicator.brightness");
9+ item = g_menu_item_new (NULL, "indicator.brightness");
10 g_menu_item_set_attribute (item, "x-canonical-type", "s", "com.canonical.unity.slider");
11 g_menu_item_set_attribute (item, "min-value", "d", brightness_to_percentage (self, lo));
12 g_menu_item_set_attribute (item, "max-value", "d", brightness_to_percentage (self, hi));

Subscribers

People subscribed via source and target branches