Merge lp:~nextrevision/charms/precise/openvpn/trunk into lp:charms/openvpn
Proposed by
John Patterson
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 6 | ||||
Proposed branch: | lp:~nextrevision/charms/precise/openvpn/trunk | ||||
Merge into: | lp:charms/openvpn | ||||
Diff against target: |
36 lines (+3/-3) 3 files modified
config.yaml (+2/-0) metadata.yaml (+1/-2) revision (+0/-1) |
||||
To merge this branch: | bzr merge lp:~nextrevision/charms/precise/openvpn/trunk | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Marco Ceppi (community) | Approve | ||
Matt Bruzek (community) | +1 | Approve | |
Review via email: mp+202980@code.launchpad.net |
Description of the change
Correctly categorized charm as cache-proxy (a better fit IMHO compared to the previous category 'application', which was also misspelled) and updated config.yaml with defaults on all variables. Also removed the revision file, as it is no longer needed. This charm still does not provide anything with regards to interfaces, and that is still by design until someone comes up with a cool use in that case.
To post a comment you must log in.
# Proof
There is only one outstanding issue when running charm proof:
$ juju charm proof openvpn
I: all charms should provide at least one thing
# Review
+1 review. The changes made in this proposal look good to me.
# Knitpick
None.