Merge lp:~newmaniese/django-pennypress/inlines into lp:django-pennypress

Proposed by Michael Newman
Status: Rejected
Rejected by: Eric Moritz
Proposed branch: lp:~newmaniese/django-pennypress/inlines
Merge into: lp:django-pennypress
To merge this branch: bzr merge lp:~newmaniese/django-pennypress/inlines
Reviewer Review Type Date Requested Status
Eric Moritz never completd Disapprove
Review via email: mp+3672@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Newman (newmaniese) wrote :

Should be ready to go. The keys here are that the interface is extensible for additional renderers (like ReST as was already discussed) and that this system will be able to provide hooks for additional validation and lookups from story pages. I hope that the views dictionary should be able to accomplish this. I think that the code to register the inlines is relatively topical and shouldn't be very difficult to create inlines for models.

Revision history for this message
Eric Moritz (ericmoritz) wrote :

This is awesome. I think it works great so far.

I really should of defined a spec before you got started. I'm sorry about that. Running this thing is a learning process for me.

There's some other things I'd like to accomplish with the inlines system, such as a form widget and field that models can use in their admin forms.

Refer to the spec I associated with the Blueprint.

Thanks,
Eric.

Revision history for this message
Eric Moritz (ericmoritz) wrote :

Needs some more work still. We should of fleshed out the spec before I let you go off and develop this blueprint.

review: Needs Resubmitting
Revision history for this message
Eric Moritz (ericmoritz) :
review: Disapprove
Revision history for this message
Eric Moritz (ericmoritz) wrote :

This was never completed so I implemented it in the ~ericmoritz/django-pennypress/inlines branch

review: Disapprove (never completd)

Unmerged revisions

52. By Michael Newman

Adds the documentation for the inlines app

51. By Michael Newman

Adds a few more tests to check for bad xml

50. By Michael Newman

Adds a base class for the inline nodes and extends the validation of the inlines to actually query the inlines directly. Also adds a validate convenience method for checking text directly. Also changes how we do imports for the inline renderers and forces the convention of the modules to use Node

49. By Michael Newman

Merges to trunk r45

48. By Michael Newman

merges to current trunk

47. By Michael Newman

Tests the exceptions and fixes a few typos that the tests caught

46. By Michael Newman

Merge with the current pep8 branch

45. By Michael Newman

Adds an inlines template filter to process inlines from in a template, also a get_inline template tag that allows for in template loading of inlines based on types and kwargs. Simple test included.

44. By Michael Newman

Gets the inlines code meeting the pep8 tests introduced in the last merge

43. By Michael Newman

merge of the pep8 branch

Subscribers

People subscribed via source and target branches