Merge lp:~newmaniese/django-pennypress/inlines into lp:django-pennypress
Status: | Rejected |
---|---|
Rejected by: | Eric Moritz |
Proposed branch: | lp:~newmaniese/django-pennypress/inlines |
Merge into: | lp:django-pennypress |
To merge this branch: | bzr merge lp:~newmaniese/django-pennypress/inlines |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Eric Moritz | never completd | Disapprove | |
Review via email: mp+3672@code.launchpad.net |
Unmerged revisions
- 52. By Michael Newman
-
Adds the documentation for the inlines app
- 51. By Michael Newman
-
Adds a few more tests to check for bad xml
- 50. By Michael Newman
-
Adds a base class for the inline nodes and extends the validation of the inlines to actually query the inlines directly. Also adds a validate convenience method for checking text directly. Also changes how we do imports for the inline renderers and forces the convention of the modules to use Node
- 49. By Michael Newman
-
Merges to trunk r45
- 48. By Michael Newman
-
merges to current trunk
- 47. By Michael Newman
-
Tests the exceptions and fixes a few typos that the tests caught
- 46. By Michael Newman
-
Merge with the current pep8 branch
- 45. By Michael Newman
-
Adds an inlines template filter to process inlines from in a template, also a get_inline template tag that allows for in template loading of inlines based on types and kwargs. Simple test included.
- 44. By Michael Newman
-
Gets the inlines code meeting the pep8 tests introduced in the last merge
- 43. By Michael Newman
-
merge of the pep8 branch
Should be ready to go. The keys here are that the interface is extensible for additional renderers (like ReST as was already discussed) and that this system will be able to provide hooks for additional validation and lookups from story pages. I hope that the views dictionary should be able to accomplish this. I think that the code to register the inlines is relatively topical and shouldn't be very difficult to create inlines for models.