Merge lp:~newell-jensen/maas/fix-1629430 into lp:~maas-committers/maas/trunk

[Newell Jensen]

Change `have been` to `are transitioning to` to reflect that the nodes are actually transitioning into this new state.

[Blake Rouse (blake-rouse)]

review: Needs Information

[Newell Jensen (newell-jensen)]

Replied inline.

[Newell Jensen (newell-jensen)]

Replied to my reply for extra information.

[Blake Rouse (blake-rouse)]

Check to see if those are used anywhere else in MAAS. I believe they are not and only used in the UI. If so then change the remaining 4 to work.

[Newell Jensen (newell-jensen)]

> Check to see if those are used anywhere else in MAAS. I believe they are not
> and only used in the UI. If so then change the remaining 4 to work.

After some more thought I think that changing 'have been' to 'are transitioning to' is better as it will work with the other action display sentences as well.

[Blake Rouse (blake-rouse)]

Sounds good.

review: Approve

=== modified file 'src/maasserver/static/partials/nodes-list.html'
--- src/maasserver/static/partials/nodes-list.html	2016-11-08 14:05:47 +0000
+++ src/maasserver/static/partials/nodes-list.html	2016-11-14 19:28:39 +0000
@@ -180,7 +180,7 @@
                 <p class="page-header__message" data-ng-show="hasActionsInProgress('nodes')">
                     <i class="icon icon--loading u-animation--spin"></i>
                     {$ tabs.nodes.actionProgress.completed $} of {$ tabs.nodes.actionProgress.total $}
-                    nodes have been {$ tabs.nodes.actionOption.sentence $}.
+                    nodes are transitioning to {$ tabs.nodes.actionOption.sentence $}.
                 </p>
                 <p class="page-header__message page-header__message--error"
                    data-ng-repeat="(error, nodes) in tabs.nodes.actionProgress.errors">