Merge lp:~newell-jensen/maas/fix-1557589 into lp:~maas-committers/maas/trunk

Proposed by Newell Jensen
Status: Merged
Approved by: Newell Jensen
Approved revision: no longer in the source branch.
Merged at revision: 4783
Proposed branch: lp:~newell-jensen/maas/fix-1557589
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 20 lines (+2/-1)
1 file modified
src/maasserver/models/node.py (+2/-1)
To merge this branch: bzr merge lp:~newell-jensen/maas/fix-1557589
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Review via email: mp+289083@code.launchpad.net

Commit message

Use node.split_arch to handle case when architecture is None. Tests already provide coverage.

To post a comment you must log in.
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/maasserver/models/node.py'
2--- src/maasserver/models/node.py 2016-03-14 18:47:35 +0000
3+++ src/maasserver/models/node.py 2016-03-15 18:30:32 +0000
4@@ -986,6 +986,7 @@
5 root_mounted = False
6 root_on_bcache = False
7 boot_mounted = False
8+ arch, subarch = self.split_arch()
9
10 for block_device in self.blockdevice_set.all():
11 if block_device.is_boot_disk():
12@@ -1026,7 +1027,7 @@
13 "This node cannot be deployed because it cannot boot from a "
14 "bcache volume. Mount /boot on a non-bcache device to be "
15 "able to deploy this node.")
16- if (not boot_mounted and "arm64" in self.architecture and
17+ if (not boot_mounted and arch == "arm64" and
18 self.get_bios_boot_method() != "uefi"):
19 issues.append(
20 "This node cannot be deployed because it needs a separate "