Merge lp:~newell-jensen/maas/fix-1465353 into lp:maas/trunk

Proposed by Newell Jensen on 2015-06-15
Status: Merged
Approved by: Newell Jensen on 2015-06-15
Approved revision: 4021
Merged at revision: 4022
Proposed branch: lp:~newell-jensen/maas/fix-1465353
Merge into: lp:maas/trunk
Diff against target: 25 lines (+2/-2)
2 files modified
src/maasserver/api/nodegroups.py (+1/-1)
src/maasserver/api/tests/test_nodegroup.py (+1/-1)
To merge this branch: bzr merge lp:~newell-jensen/maas/fix-1465353
Reviewer Review Type Date Requested Status
Christian Reis Approve on 2015-06-15
Mike Pontillo 2015-06-15 Approve on 2015-06-15
Review via email: mp+261997@code.launchpad.net

Commit Message

Fix typo s/mcsm/mscm for the MSCM that is blocking probe_and_enlist_hardware from working properly.

To post a comment you must log in.
Clark Laughlin (clark-laughlin) wrote :

Worked for me

Mike Pontillo (mpontillo) wrote :

Looks good.

review: Approve
Mike Pontillo (mpontillo) wrote :

Also, my apologies; looks like I'm the one who introduced this! Sorry about that.

Christian Reis (kiko) wrote :

Doh! I'm sorry this isn't caught by our own Moonshot testing; hoping Sean gets a fix in for that.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/maasserver/api/nodegroups.py'
2--- src/maasserver/api/nodegroups.py 2015-05-18 18:06:15 +0000
3+++ src/maasserver/api/nodegroups.py 2015-06-15 18:32:27 +0000
4@@ -499,7 +499,7 @@
5 prefix_filter=prefix_filter, accept_all=accept_all)
6 elif model == 'ucsm':
7 self.do_probe_and_enlist_ucsm(nodegroup, request, user)
8- elif model == 'mcsm':
9+ elif model == 'mscm':
10 self.do_probe_and_enlist_mscm(nodegroup, request, user)
11 elif model == 'msftocs':
12 self.do_probe_and_enlist_msftocs(nodegroup, request, user)
13
14=== modified file 'src/maasserver/api/tests/test_nodegroup.py'
15--- src/maasserver/api/tests/test_nodegroup.py 2015-05-18 18:06:15 +0000
16+++ src/maasserver/api/tests/test_nodegroup.py 2015-06-15 18:32:27 +0000
17@@ -553,7 +553,7 @@
18 'op': self.endpoint,
19 # The deprecated version of the API doesn't need the
20 # 'model' key, but it will simply be ignored.
21- 'model': 'mcsm',
22+ 'model': 'mscm',
23 'host': host,
24 'username': username,
25 'password': password,