Merge lp:~newell-jensen/curtin/fix-bug-1367489 into lp:~curtin-dev/curtin/trunk

Proposed by Newell Jensen
Status: Merged
Merged at revision: 169
Proposed branch: lp:~newell-jensen/curtin/fix-bug-1367489
Merge into: lp:~curtin-dev/curtin/trunk
Diff against target: 19 lines (+6/-2)
1 file modified
curtin/commands/install.py (+6/-2)
To merge this branch: bzr merge lp:~newell-jensen/curtin/fix-bug-1367489
Reviewer Review Type Date Requested Status
Blake Rouse (community) Approve
Review via email: mp+234159@code.launchpad.net

Commit message

Logging Stage.run method subprocess execution output with curtin logger.

Description of the change

Subprocess execution output in the Stage.run method within commands/install.py was not logging to the curtin logger. Logging the output has been added to the curtin logger if it is needed in the future.

To post a comment you must log in.
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'curtin/commands/install.py'
2--- curtin/commands/install.py 2014-09-09 15:12:06 +0000
3+++ curtin/commands/install.py 2014-09-10 17:33:46 +0000
4@@ -124,9 +124,13 @@
5 cmd, stdout=writer, stderr=writer, env=env, shell=shell)
6 # sp.stdout and sp.stderr are written to parent process stdout
7 while sp.poll() is None:
8- sys.stdout.write(reader.read())
9+ msg = reader.read()
10+ sys.stdout.write(msg)
11+ LOG.info(msg)
12 time.sleep(0.25)
13- sys.stdout.write(reader.read())
14+ msg = reader.read()
15+ sys.stdout.write(msg)
16+ LOG.info(msg)
17
18
19 def apply_power_state(pstate):

Subscribers

People subscribed via source and target branches