netplan:try-command

Last commit made on 2018-04-17
Get this branch:
git clone -b try-command https://git.launchpad.net/netplan

Branch merges

Branch information

Name:
try-command
Repository:
lp:netplan

Recent commits

66a7368... by Mathieu Trudel-Lapierre on 2018-04-17

terminal: disable echo while we're waiting for timeout/user input

Signed-off-by: Mathieu Trudel-Lapierre <email address hidden>

27eebab... by Mathieu Trudel-Lapierre on 2018-04-17

terminal: correct handling of save/restore for terminal flags/settings

Signed-off-by: Mathieu Trudel-Lapierre <email address hidden>

87dfbcd... by Mathieu Trudel-Lapierre on 2018-04-17

'netplan try': linting fixes

610b4f6... by Mathieu Trudel-Lapierre on 2018-04-17

'netplan try': make sure to only try removing virtual devices

Signed-off-by: Mathieu Trudel-Lapierre <email address hidden>

26b6bb0... by Mathieu Trudel-Lapierre on 2018-04-17

'netplan try': attempt to revert newly added virtual devices

Signed-off-by: Mathieu Trudel-Lapierre <email address hidden>

3d83f90... by Mathieu Trudel-Lapierre on 2018-04-16

tests: fix ConfigManager tests for the empty dict case

Signed-off-by: Mathieu Trudel-Lapierre <email address hidden>

0863b9e... by Mathieu Trudel-Lapierre on 2018-04-16

configmanager: more fixes to parsing/merging configs

Signed-off-by: Mathieu Trudel-Lapierre <email address hidden>

15c73f9... by Mathieu Trudel-Lapierre on 2018-04-16

'netplan try': Don't need to explicitly import ConfigurationError

netplan.configmanager.ConfigurationError is potentially raised by
'netplan apply', but we already catch and handle Exception appropriately.

Signed-off-by: Mathieu Trudel-Lapierre <email address hidden>

10e4113... by Mathieu Trudel-Lapierre on 2018-04-16

'netplan try': do a better job at merging and checking for unsupported keys

We need to be really careful when merging config, as dicts could just be
replaced -- what we really want is to replace individual keys were applicable,
and be explicit about any settings we can't revert.

Signed-off-by: Mathieu Trudel-Lapierre <email address hidden>

a8576fd... by Mathieu Trudel-Lapierre on 2018-04-16

'netplan try': better handle reversion when 'netplan apply' fails

The generate step can still fail if the config is invalid; only the call to
generate checks that (and I'd rather keep it that way). So, check for failure
in generate, which used to simply exit (which would break things with a backup
left around, but no reversion done), and instead throw an exception we can
catch and then actually process the revert.

Signed-off-by: Mathieu Trudel-Lapierre <email address hidden>