Merge lp:~neric27/midori/cflags_in_c_extensions into lp:midori

Proposed by Eric Le Lay
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6578
Merged at revision: 6578
Proposed branch: lp:~neric27/midori/cflags_in_c_extensions
Merge into: lp:midori
Diff against target: 27 lines (+11/-3)
1 file modified
extensions/CMakeLists.txt (+11/-3)
To merge this branch: bzr merge lp:~neric27/midori/cflags_in_c_extensions
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+208968@code.launchpad.net

Commit message

Set proper CFLAGS for vala and c files when compiling extensions

To post a comment you must log in.
Revision history for this message
Paweł Forysiuk (tuxator) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extensions/CMakeLists.txt'
2--- extensions/CMakeLists.txt 2014-03-01 17:55:02 +0000
3+++ extensions/CMakeLists.txt 2014-03-02 16:17:23 +0000
4@@ -69,12 +69,20 @@
5 target_link_libraries(${UNIT_SRC}
6 ${LIBMIDORI}
7 )
8- set_target_properties(${UNIT_SRC} PROPERTIES
9- COMPILE_FLAGS ${VALA_CFLAGS}
10- )
11 install(TARGETS ${UNIT_SRC}
12 LIBRARY DESTINATION ${EXTENSIONDIR}
13 )
14+ # extensions with vala code get the lenient VALA_CFLAGS
15+ # others get the usual CFLAGS with -Wall and -Werror
16+ if (UNIT_FILES_VALA)
17+ set_target_properties(${UNIT_SRC} PROPERTIES
18+ COMPILE_FLAGS ${VALA_CFLAGS}
19+ )
20+ else ()
21+ set_target_properties(${UNIT_SRC} PROPERTIES
22+ COMPILE_FLAGS ${CFLAGS}
23+ )
24+ endif ()
25 endif ()
26 endif ()
27 endforeach ()

Subscribers

People subscribed via source and target branches

to all changes: