lp:~neon/phonon/gstreamer

Created by Philip Muškovac and last modified
Get this branch:
bzr branch lp:~neon/phonon/gstreamer

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Deprecated Projected Neon
Project:
Phonon
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at https://invent.kde.org/libraries/phonon-gstreamer.

The next import is scheduled to run .

Last successful import was .

Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 15 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-17 and finished taking 15 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-17 and finished taking 15 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-17 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 15 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-17 and finished taking 10 seconds — see the log

Recent revisions

2666. By Laurent Montel <email address hidden>

Adapt build system for building against qt6

2665. By Laurent Montel <email address hidden>

Use override keyword

2664. By Méven Car <email address hidden>

VideoWidget prevent warnings

Such as:
(dolphin:443671): GStreamer-Video-CRITICAL **: 09:44:16.741: gst_navigation_send_key_event: assertion 'g_strcmp0 (event, "key-press") == 0 || g_strcmp0 (event, "key-release") == 0' failed

Ref: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/1139#note_1384347

2663. By David Edmundson <email address hidden>

Only create window handles for actual windows

winId() creates a platform window for the given widget. This makes sense
for the topmost widget in a tree, we can't assume the parent widget is
the topmost widget.

Doing this on XCB is confusing and wrong, but apparently harmless. Doing
this on wayland causes issues as we promote the parent window to a
subsurface but never show that window leaving things in a bizarre
corrupt state that leads to content not updating.

BUG: 445196

2662. By Christophe Giboudeaux <email address hidden>

Fix typos found by codespell

GIT_SILENT

2661. By Michael Pyne <email address hidden>

Fix unhandled switch conditions.

AudioVideoCapture seemed easy enough. The BluRay URI I'm less sure of, I
saw bluray:// and br:// online. But only mplayer seemed to use br:// so
I went with bluray://

2660. By Michael Pyne <email address hidden>

Remove usage of deprecated Qt methods.

The only thing in here that's more than trivial is the QFlags removal of
its constructor from `int` for Phonon::EffectParameter::Hints. Its
replacement was only added in Qt 5.15.

However using { } and allowing the compiler to infer default
initialization as Qt docs hint at seems to still work fine and should
also be compatible with older Qt. I think.

2659. By Michael Pyne <email address hidden>

Fix warning about use of variable-length array [-Wvla].

This C-interfacing code already uses too much malloc/free so rather than
mallocing the `details` array I opted to turn it into a QVector. The
remaining changes work to avoid some needless QString/gchar conversion.

2658. By Michael Pyne <email address hidden>

Add C++11 override declarations to known virtual overrides.

This eliminates 683 compiler warnings. I use Q_DECL_OVERRIDE to let Qt
do the heavy lifting of working with old compilers.

The override entries were as recommended by the compiler. I gave them
all basic sanity checks but I don't have in-depth knowledge of the
interfaces here.

2657. By Pino Toscano

cmake: remove use of old PHONON_BUILD_PHONON4QT5

Assuming it is always true now, simplify the setting of
BUILD_X11RENDERER so it is enabled only when Qt5X11Extras is found
(definitely not on Windows).

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.