lp:~neon/libkcddb/master

Created by Gaurav Chaturvedi and last modified
Get this branch:
bzr branch lp:~neon/libkcddb/master

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Deprecated Projected Neon
Project:
KDE CDDB library
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at https://invent.kde.org/multimedia/libkcddb.

The next import is scheduled to run .

Last successful import was .

Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 15 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 15 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-12 and finished taking 15 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-17 and finished taking 15 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-16 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-15 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-12 and finished taking 15 seconds — see the log

Recent revisions

692. By Nicolas Fella <email address hidden>

Add gitignore

691. By Heiko Becker <email address hidden>

Add Gitlab Linux CI

690. By Frank Schäfer <email address hidden>

AsyncMusicBrainzLookup: minor coding style fixes/unification

689. By Frank Schäfer <email address hidden>

AsyncMusicBrainzLookup: fix a crash and a memory leak

From the documentation of QThread::~QThread():
"... Note that deleting a QThread object will not stop the execution of the
 thread it manages. Deleting a running QThread (i.e. isFinished() returns false)
 will probably result in a program crash.
 Wait for the finished() signal before deleting the QThread."

The destructor of class AsyncMusicBrainzLookup currently just deletes the lookup
thread object and does _not_ wait for the running thread to finish.
If it is called while the lookup thread is still running, a crash occurs.

In addition to that, we are leaking the memory of a previously instanciated
lookup thread object if the lookup() method is called multiple times.

To maintain the current behavior of the destructor (non-blocking) and the
lookup() method (always start a new lookup without canceling pending lookups),
solve both issues by making the lookup thread object self-destructive.
As part of the solution the lookup thread is modifed to deliver the lookup results
directly with the "lookupFinished" signal. This has two benefits:
1.) the queued signal-slot connection avoids thread synchronization/locking issues
2.) some class members become obsolete

688. By Frank Schäfer <email address hidden>

AsyncMusicBrainzTest: add tests to unveil crashes as reported in bug 336678

687. By Friedrich W. H. Kossebau <email address hidden>

Explicitly call ki18n_install(po)

GIT_SILENT

686. By Friedrich W. H. Kossebau <email address hidden>

Port away from Qt's foreach

GIT_SILENT

685. By Friedrich W. H. Kossebau <email address hidden>

Use Q_EMIT instead of emit

GIT_SILENT

684. By Friedrich W. H. Kossebau <email address hidden>

Use more target-centric cmake code

Also move cmake config generation into src/ folder

GIT_SILENT

683. By Friedrich W. H. Kossebau <email address hidden>

Bump min Qt/KF versions to 5.15/5.80

GIT_SILENT

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.