lp:konsole

Created by Philip Muškovac on 2011-01-31 and last modified on 2019-02-22
Get this branch:
bzr branch lp:konsole

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Deprecated Projected Neon
Project:
konsole
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://anongit.kde.org/konsole.git.

The next import is scheduled to run in 5 hours.

Last successful import was 14 minutes ago.

Import started 14 minutes ago on izar and finished 14 minutes ago taking 15 seconds — see the log
Import started 6 hours ago on izar and finished 6 hours ago taking 20 seconds — see the log
Import started 12 hours ago on alnitak and finished 12 hours ago taking 20 seconds — see the log
Import started 18 hours ago on izar and finished 18 hours ago taking 15 seconds — see the log
Import started on 2019-02-22 on alnitak and finished on 2019-02-22 taking 25 seconds — see the log
Import started on 2019-02-22 on izar and finished on 2019-02-22 taking 20 seconds — see the log
Import started on 2019-02-21 on alnitak and finished on 2019-02-21 taking 25 seconds — see the log
Import started on 2019-02-21 on izar and finished on 2019-02-21 taking 20 seconds — see the log
Import started on 2019-02-21 on alnitak and finished on 2019-02-21 taking 20 seconds — see the log
Import started on 2019-02-21 on alnitak and finished on 2019-02-21 taking 20 seconds — see the log

Recent revisions

6349. By mglb 12 hours ago

Replace assert with Q_ASSERT

6348. By mglb 12 hours ago

Improve built-in line/block characters drawing

Summary:
* Fix bold lines (BUG 402415).
* Make drawing pixel-perfect.
* Make line width proportional to font size.
* Move relevant code to separate file and namespace.
* Remove code for checking supported line characters from Character
  class. Information about what is supported is now in one place
  together width drawing code.
* Remove fontembedder/LineFont files (no longer used).
* Add test script for displaying supported characters table.
* Add triple and quadruple dashes (U+2504...U+250B).
* Change shade block characters (U+2591...U+2593) look. When
  antialiasing is turned on, shades are drawn as transculent solid
  rectangles with 25%, 50% and 75% alpha. This matches the characters
  name/description and their usage. Without antialiasing, previous
  method with patterns is used.

**Screenshots**

Font size: 10pt; character width: 8px
{F6602823}

Font size: 11pt; character width: 9px
{F6602824}

Font size: 12pt; character width: 10px
{F6602825}

Font size: 13-14pt; character width: 11px; w/o antialiasing
{F6602826}

Font size: 13-14pt; character width: 11px
{F6602827}

Font size: 15pt; character width: 12px
{F6602828}

Font size: 6-7pt; character width: 5px
{F6602829}

Font size: 8-9pt; character width: 7px; w/o antialiasing
{F6602830}

Font size: 8-9pt; character width: 7px
{F6602831}

Alignment test (8pt)
{F6602832}

Note: Copyrights in LineBlockCharactersDrawer.cpp are based on
`git blame -w src/TerminalDisplay.cpp` executed before moving the code
to a separate file. Years from first/last commit. Authors sorted by
year. Whitespace-only changes were ignored. Maksim's code was commited
by Waldo Bastian who mentioned him as the author in commit message
(see 5062b40dd).

BUG: 402415

Test Plan:
== Common steps for all tests ==

* Open //Edit Current Profile → Appearance//.
* Turn on //Draw intense colors in bold font//.
* Turn off //Use line characters contained in font//.
* (Optional) select a font which is able to display bold characters in
  Konsole (e.g. DejaVu Sans Mono).

== Check characters validity ==

* Run `./tests/line_block_characters_table.py`.
* Open //Edit Current Profile → Appearance//.
* By switching //Use line characters contained in font// on and off,
  compare built-in characters drawing with characters from a font.
  General shape and line directions must be the same. Small offsets,
  line width differences (as long as proportions between lines in
  a character are kept), and quality differences are allowed.

== Review overall quality ==

* Run `./tests/line_block_characters_table.py`.
* Review glyphs quality in different font sizes.
* Open //Edit Current Profile → Appearance//.
* Toggle //Smooth fonts//, review quality again.

== Check alignment ==

* Display `tests/UTF-8-demo.txt`
* At the bottom of the file you can find a few alignment images. Check
  if all lines align properly. If you're unsure how it should look,
  compare it with font characters by turning on //Use line characters
  contained in font// option.

Reviewers: #konsole, #vdg, fvogt, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: hindenburg, sandsmark, fvogt, konsole-devel

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D18735

6347. By Kurt Hindenburg on 2019-02-20

Correct slot called for changing tab text color - not implemented

Previously, the signal was attached to another signal; the actual code
has not been implemented in 10+ years.

CCBUG: https://bugs.kde.org/show_bug.cgi?id=404457

6346. By Kurt Hindenburg on 2019-02-20

Remove old commented out code

6345. By Kurt Hindenburg on 2019-02-20

Correctly set icon when changing default profile in Manage dialog

When changing the default profile, the previous default's profile icon
would not be displayed in the Manage Profiles dialog's row.

6344. By Kurt Hindenburg on 2019-02-20

Use QStringLiteral in two test instances

6343. By Shubham Jangra <email address hidden> on 2019-02-20

Add close tab and create new tab on middle click event

Summary:
Click with the middle mouse click on a tab: close it
Click with the middle click on empty portion of tab bar creates a new tab.
This makes konsole more streamlined with default behavior
found in other tabbed applications like browsers.
GUI option to enable/disable closing tab w/ mouse button. The default
is to have closing tab with button disabled to avoid possible data loss.

Tomaz Canabrava <email address hidden> also coded portion of this.

FEATURE: 398940
FIXED-IN: 19.04
GUI:

Test Plan: {F6618852}

Reviewers: ngraham, hindenburg, tcanabrava

Reviewed By: ngraham, hindenburg

Subscribers: emateli, thsurrel, ngraham, hindenburg, shubham, broulik, konsole-devel

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D15742

6342. By Kurt Hindenburg on 2019-02-19

Update copyright to 2019

6341. By Kurt Hindenburg on 2019-02-16

Change depreciated KAboutData::setProgramIconName()

Use QApplication::setWindowIcon(QIcon::fromTheme()) now

6340. By Kurt Hindenburg on 2019-02-16

Change QStyleOptionViewItemV3 and V4 to QStyleOptionViewItem

QStyleOptionViewItemV3 and QStyleOptionViewItemV4 were depreciated in
Qt 5.7

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.