lp:~neon/kolourpaint/master

Created by Philip Muškovac on 2011-02-23 and last modified on 2019-12-10
Get this branch:
bzr branch lp:~neon/kolourpaint/master

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Deprecated Projected Neon
Project:
kolourpaint
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://anongit.kde.org/kolourpaint.git.

The next import is scheduled to run in 3 hours.

Last successful import was 2 hours ago.

Import started 2 hours ago on izar and finished 2 hours ago taking 20 seconds — see the log
Import started 8 hours ago on izar and finished 8 hours ago taking 25 seconds — see the log
Import started 14 hours ago on izar and finished 14 hours ago taking 15 seconds — see the log
Import started 20 hours ago on alnitak and finished 20 hours ago taking 20 seconds — see the log
Import started on 2019-12-11 on izar and finished on 2019-12-11 taking 15 seconds — see the log
Import started on 2019-12-11 on alnitak and finished on 2019-12-11 taking 20 seconds — see the log
Import started on 2019-12-11 on izar and finished on 2019-12-11 taking 15 seconds — see the log
Import started on 2019-12-11 on izar and finished on 2019-12-11 taking 15 seconds — see the log
Import started on 2019-12-10 on izar and finished on 2019-12-10 taking 20 seconds — see the log
Import started on 2019-12-10 on alnitak and finished on 2019-12-10 taking 20 seconds — see the log

Recent revisions

2081. By Jonathan Riddell on 2019-12-10

Change KDE_APPLICATIONS_VERSION to RELEASE_SERVICE_VERSION https://phabricator.kde.org/T11933
GIT_SILENT

2080. By Yuri Chornoivan <email address hidden> on 2019-12-07

Use URLs with transport encryption

2079. By Yuri Chornoivan <email address hidden> on 2019-12-07

Fix minor typos

2078. By David Faure on 2019-12-06

Port kolourpaint away from Kdeprint::createPrintDialog

Summary: This was the final step to port away from kdelibs4support.

Test Plan: The print dialog still has the 3rd widget with 2 radiobuttons like before.

Reviewers: broulik, andreagenor, tcanabrava, vkrause

Reviewed By: vkrause

Maniphest Tasks: T11576

Differential Revision: https://phabricator.kde.org/D25601

2077. By David Faure on 2019-12-06

Port from KFileDialog to QFileDialog.

Summary:
Tricky because of the embedded widget for save options.
Reused the solution found in kuickshow.

Since QFileDialog implements overwrite checking, kill all
the custom code for doing the same.

Test Plan: Save as (new file), save as (existing file)

Reviewers: broulik, andreagenor, tcanabrava

Reviewed By: tcanabrava

Maniphest Tasks: T11576

Differential Revision: https://phabricator.kde.org/D25482

2076. By David Faure on 2019-11-28

Port away from KImageIO.

Summary:
Same solution (for finding the format string for QImage from the
mimetype) as the one used by Spectacle.

Test Plan:
Saving still works as PNG, JPG (to test multiple extensions),
and WEBP (to test a 4-letter extension).

Reviewers: broulik, andreagenor, tcanabrava, vkrause

Reviewed By: vkrause

Differential Revision: https://phabricator.kde.org/D25600

2075. By David Faure on 2019-11-27

Port kpColorCollection away from KIO::NetAccess

Summary:
While testing "save as" over an existing color file, I noticed
a double confirmation message box. This is because QFileDialog
already takes care of it ==> simplify the code.

Test Plan: Loading colors from submenu, saving as, saving as existing file, loading from file.

Reviewers: broulik, andreagenor, tcanabrava, vkrause

Reviewed By: vkrause

Maniphest Tasks: T11576

Differential Revision: https://phabricator.kde.org/D25480

2074. By David Faure on 2019-11-27

Port the saving code away from NetAccess

Test Plan:
Saving works. Saving as another existing file brings up the
overwrite prompt. Confusingly, "Save as" and chosing the current filename
doesn't, unlike in other apps, but it's on purpose (and actually makes sense).

Reviewers: broulik, andreagenor, tcanabrava

Reviewed By: broulik

Maniphest Tasks: T11576

Differential Revision: https://phabricator.kde.org/D25479

2073. By David Faure on 2019-11-27

Port urlExists() from NetAccess to KIO::NetAccess::exists

Reviewers: broulik, andreagenor, tcanabrava, vkrause

Reviewed By: vkrause

Subscribers: vkrause

Maniphest Tasks: T11576

Differential Revision: https://phabricator.kde.org/D25478

2072. By David Faure on 2019-11-27

Port the Open code away from NetAccess.

Summary:
NetAccess::download used a temp file, to then load that with
QImageReader.

I'm using an in-memory buffer instead, mostly because it's
less code. It should also be faster, at the expense of more
memory usage of course (the PNG data should be less than the
image data anyway).

Test Plan: Opening files still works

Reviewers: broulik, andreagenor, tcanabrava, vkrause

Reviewed By: vkrause

Maniphest Tasks: T11576

Differential Revision: https://phabricator.kde.org/D25477

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.