lp:~neon/extra-cmake-modules/master

Created by Harald Sitter on 2013-05-06 and last modified on 2019-08-19
Get this branch:
bzr branch lp:~neon/extra-cmake-modules/master

Related bugs

Related blueprints

Branch information

Owner:
Deprecated Projected Neon
Project:
extra-cmake-modules
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://anongit.kde.org/extra-cmake-modules.

The next import is scheduled to run in 9 minutes.

Last successful import was 5 hours ago.

Import started 5 hours ago on alnitak and finished 5 hours ago taking 20 seconds — see the log
Import started 13 hours ago on alnitak and finished 13 hours ago taking 20 seconds — see the log
Import started 20 hours ago on alnitak and finished 20 hours ago taking 20 seconds — see the log
Import started on 2019-08-20 on alnitak and finished on 2019-08-20 taking 20 seconds — see the log
Import started on 2019-08-20 on alnitak and finished on 2019-08-20 taking 20 seconds — see the log
Import started on 2019-08-20 on alnitak and finished on 2019-08-20 taking 20 seconds — see the log
Import started on 2019-08-20 on alnitak and finished on 2019-08-20 taking 20 seconds — see the log
Import started on 2019-08-19 on alnitak and finished on 2019-08-19 taking 20 seconds — see the log
Import started on 2019-08-19 on alnitak and finished on 2019-08-19 taking 20 seconds — see the log
Import started on 2019-08-19 on alnitak and finished on 2019-08-19 taking 20 seconds — see the log

Recent revisions

931. By Harald Sitter on 2019-08-19

disable autouic again - it breaks builds

Summary:
autouic (like automoc) assumes that every ui_*.h include statement it finds
relates to a .ui file that needs generating. this is not always true.

e.g. we have software which generates ui_debug.h which is simply
a qloggingcategory header for the UI category of that software which would
then trip up autouic because it would assume there's a .ui file when there
really isn't one.

unfortunately the ui_ assumption cannot be selectively disabled, so we
can't have explicit listing of .ui in source lists

```
set(foo_SRCS foo.cpp foo.ui)
```

without also getting the not particularly compatible include assumptions.
this should be revisited for kf6 since there isn't a technical need for
files to be called ui_*, they could just as well be *_ui or anything else
so as to not clash with autouic assumption.

autorcc does not suffer from this problem so we can leave it enabled, for
now anyway.

Test Plan: sonnet builds again

Reviewers: apol, nicolasfella, cullmann

Reviewed By: apol

Subscribers: kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D23262

930. By Harald Sitter on 2019-08-19

set autorcc and autouic by default

Summary:
I couldn't find any pertinent discussion on the topic but some reviews I
stumbled over did set it on some of our application repos and also wonder
why we don't enable it by default.

autorcc allows more idiomatic use of qrc as they may be used like any
"ordinary" source file and cmake will know what to do with them (namely
compile into relevant cpp for inclusion in target) without the developer
having to worry about anything.

autouic does the same albeit for .ui files.

Test Plan: .qrc files can be added to src list variables and will get automatically generated into cpp files in the binary dir and built into the target

Reviewers: apol

Reviewed By: apol

Subscribers: cgiboudeaux, vkrause, kossebau, apol, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D22805

929. By Volker Krause <email address hidden> on 2019-08-15

Define install location for JAR/AAR files for Android

Summary:
This follows where Qt installs those, and thus androiddeployqt looks for
them. Currently this is hardcoded in knotifications for example, seems
cleaner to have this here.

Reviewers: #build_system, #android, apol

Reviewed By: #android, apol

Subscribers: apol, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D23131

928. By l10n daemon script <email address hidden> on 2019-08-11

GIT_SILENT Upgrade ECM version to 5.62.0.

927. By Friedrich W. H. Kossebau <email address hidden> on 2019-08-05

Add ECMAddQtDesignerPlugin

Summary:
ECMAddQtDesignerPlugin provides two macros that can be used to
replace the usage of the tool kgendesignerplugin from KDesignerPlugin.
This allows to have ECM-using libraries to create Qt Designer plugins without
the need for another separate tool.

For that purpose option structure & defaults are inspired from that one, to
allow simple porting. Main difference is that ECMAddQtDesignerPlugin
expects the widget metadata definition to be done in CMake code,
using a dedicated function, instead of in a ini-style separate ".widgets" file.

Porting of ".widgets" files basically means:
copy content into cmake, transform ini code into arguments to util method.
Key names need a bit of adaption, current names are open for dicussion.

Porting example:
```
[KActionSelector]
IncludeFile=kactionselector.h
ToolTip=A widget for selecting and arranging actions/objects
Group=Views (KF5)
```
gets
```
ecm_qtdesignerplugin_widget(KActionSelector
    INCLUDE_FILE kactionselector.h
    TOOLTIP "A widget for selecting and arranging actions/objects"
    GROUP "Views (KF5)"
)
```

Reviewers: #build_system, #frameworks

Subscribers: apol, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D22724

926. By Aleix Pol on 2019-07-29

android: Allow overriding ANDROID_ARCH and ANDROID_ARCH_ABI as envvars

925. By Aleix Pol on 2019-07-25

Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh

Summary:
It's especially when KDE_INSTALL_USE_QT_SYS_PATHS=OFF that the different environment variables will have to be initialised.
This adds a message that should tell users about the script so they have a hint of what is going on.

Reviewers: #frameworks, albertvaka, cgiboudeaux

Reviewed By: albertvaka, cgiboudeaux

Subscribers: cgiboudeaux, albertvaka, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D22580

924. By Aleix Pol on 2019-07-23

Provide a more sensible CMAKE_INSTALL_PREFIX default

Summary: If no prefix is passed, use ECM's by default, instead of defaulting to /usr/local which isn't optimal in any case.

Reviewers: cgiboudeaux

Reviewed By: cgiboudeaux

Subscribers: cgiboudeaux, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D22676

923. By David Faure on 2019-07-23

Make the default build type "Debug" when compiling a git checkout.

Summary:
The idea comes from
https://blog.kitware.com/cmake-and-the-default-build-type/
but I adapted it to leave it empty for tarballs, to avoid messing up
distribution packaging.

The goal is to make this more sensible for [new] developers who just
run cmake and end up with a "no debug symbols, no optimizations" build,
i.e. the one and only completely useless combination of those two flags.

Possible risk: distributions who compile from git checkouts...

Test Plan: "mkdir build ; cd build ; cmake .." in kblog leads to CMAKE_BUILD_TYPE=Debug

Reviewers: kde-buildsystem, cgiboudeaux

Reviewed By: cgiboudeaux

Subscribers: cgiboudeaux, apol, kde-frameworks-devel

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D22667

922. By l10n daemon script <email address hidden> on 2019-07-13

GIT_SILENT Upgrade ECM version to 5.61.0.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.