lp:amarok

Created by Philip Muškovac on 2011-03-01 and last modified on 2019-10-04
Get this branch:
bzr branch lp:amarok

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Deprecated Projected Neon
Project:
Amarok
Status:
Development

Import details

Import Status: Reviewed

This branch is an import of the HEAD branch of the Git repository at git://anongit.kde.org/amarok.

The next import is scheduled to run in 4 hours.

Last successful import was 1 hour ago.

Import started 1 hour ago on alnitak and finished 1 hour ago taking 30 seconds — see the log
Import started 7 hours ago on izar and finished 7 hours ago taking 30 seconds — see the log
Import started 13 hours ago on alnitak and finished 13 hours ago taking 30 seconds — see the log
Import started 19 hours ago on izar and finished 19 hours ago taking 25 seconds — see the log
Import started on 2019-10-17 on izar and finished on 2019-10-17 taking 30 seconds — see the log
Import started on 2019-10-17 on alnitak and finished on 2019-10-17 taking 30 seconds — see the log
Import started on 2019-10-16 on izar and finished on 2019-10-16 taking 25 seconds — see the log
Import started on 2019-10-16 on alnitak and finished on 2019-10-16 taking 30 seconds — see the log
Import started on 2019-10-16 on alnitak and finished on 2019-10-16 taking 30 seconds — see the log
Import started on 2019-10-16 on alnitak and finished on 2019-10-16 taking 30 seconds — see the log

Recent revisions

32249. By Wolfgang Bauer <email address hidden> on 2019-10-04

Register Play/Pause as global shortcut again

Commit 0b2b243b removed the call to KGlobalAccel::setGlobalShortcut()
because it registered Space as global shortcut, which of course is a bad
idea.
But that made it impossible to set up a global shortcut at all (and made
an existing one have no effect).

To fix this, add it back and register an empty key, like the KDE4 code
does.

BUG: 373590
Differential Revision: https://phabricator.kde.org/D24381

32248. By Yuri Chornoivan <email address hidden> on 2019-10-04

Fix missing directory separators when saving podcasts to disk

Summary: `SqlPodcastProvider::checkEnclosureLocallyAvailable()` and `SqlPodcastProvider::downloadResult()` strip the trailing slash from the podcast download path, but do not add a directory separator when appending the download filename back to the directory. As a result, downloaded podcast filenames are prefixed with the directory name and stored in the parent directory.

Reviewers: #amarok, heikobecker

Reviewed By: #amarok, heikobecker

Subscribers: heikobecker, #amarok, wbauer, yurchor, amarok-devel

Differential Revision: https://phabricator.kde.org/D24135

32247. By Wolfgang Bauer <email address hidden> on 2019-09-20

Don't delete whole folder when deleting a track

`SqlCollectionLocation::moodFile()` tries to replace the filename's
extension with ".mood" (and prepend a '.') to get the Url of the
moodfile.
But it does that *after* the filename has already been removed from the
Url, so `QUrl::fileName()` gives an empty string and the end result is
actually "/path/to/folder/." which depicts the containing folder.

As a result, when Amarok tries to delete the corresponding moodfile
after a track is deleted, the whole folder gets deleted instead.

To fix this, save the filename in a temporary variable before removing
it, and use that for generating the new filename.

BUG: 411760
Differential Revision: https://phabricator.kde.org/D24040

32246. By Wolfgang Bauer <email address hidden> on 2019-09-19

[TagDialog] Really enable "Open in filemanager" button for local files

`QUrl::QUrl()` expects a full Url including the scheme (unlike
`KUrl::KUrl()` that supports local paths too).
But for local files, `urlString` contains the local path without a
scheme ("file://").

The problem here is that `QUrl` cannot detect that the Url is actually
pointing to a local file if the scheme is missing (according to the Qt
docs, a URL is a local file path if the scheme is "file"), so
`QUrl::isLocalFile()` was always `false` and the "Open in filemanager"
button never got enabled.

So use `QUrl::fromUserInput()` instead to construct the `QUrl`, which
also supports local paths.

Also, to avoid showing the "file://" scheme in the "Location" text field
now, pass `QUrl::PreferLocalFile` to `QUrl::toDisplayString()` as
suggested in the KUrl::pathOrUrl() docs.

Differential Revision: https://phabricator.kde.org/D24043

32245. By Christophe Giboudeaux <email address hidden> on 2019-08-24

Fix a crash when running 'amarok -l /path/to/file'

Summary: BUG: 410870

Test Plan:
amarok -l <somefile>

Before: Assert "you need to call AmarokConfig::instance before using"

After: the file is queued and played.

Reviewers: heikobecker

Reviewed By: heikobecker

Subscribers: #amarok, amarok-devel

Differential Revision: https://phabricator.kde.org/D23326

32244. By l10n daemon script <email address hidden> on 2019-08-20

GIT_SILENT made messages (after extraction)

32243. By l10n daemon script <email address hidden> on 2019-07-31

SVN_SILENT made messages (.desktop file) - always resolve ours

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

32242. By l10n daemon script <email address hidden> on 2019-07-31

GIT_SILENT made messages (after extraction)

32241. By Albert Astals Cid on 2019-07-27

Fix CI build

missing QVector include

32240. By Nate Graham <email address hidden> on 2019-07-26

Use identical internet-services icon
This icon is identical to the applications-internet icon at the small size used
here, but is more appropriate to use because it is guaranteed to always be
monochrome, unlike applications-internet which is a colorful category icon
and only had small monochrome versions due to a design oversight that's being
corrected in https://phabricator.kde.org/D22733.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.