Code review comment for lp:~nelson-chu/opencompute/add-ocp-pch-job

Revision history for this message
Jeff Lane  (bladernr) wrote :

https://code.launchpad.net/~bladernr/opencompute/checkbox-merge-nelsons-pch-jobs/+merge/205811

I rejected your merge proposal and pushed my own. The link is above.

That is basically your branch, but I fixed the quotation mark issue in number 2 above. So your code has now landed in trunk.

I wish there was a cleaner way to do it, but tis is the only way. Next time, I'll just have you fix the issues yourself and re-submit.

Thanks for the submission, the code should be merged in soon once Tarmac picks it up.

« Back to merge proposal