Merge lp:~nelson-chu/opencompute/add-ocp-hardware-information-job into lp:opencompute/checkbox

[Nelson Chu]

Add OCP hardware information job

[Jeff Lane  (bladernr)]

Looks good. I don't have anything with a MegaRAID controller so I can't test the megacli script, but that's up to you.

For future reference, you don't have to delete and re-add files when you want to rename them. 'bzr rename' will do the trick.

And thanks for catching that missing .in description.

[Jeff Lane  (bladernr)]

Needs Fixing. You need to do one more thing though... and I have a feeling you'll need to do this for all your merge requests.

You need to edit the file debian/changelog and follow the format you see contained inside.

Always put your changelog entries under your name and use a brief summary. Do NOT change the version or date stamp info and always put your entries in the top most stanza of the changelog.

For example, you should change the change log to add something like this:

 [ Nelson Chu ]
 * data/whitelists/opencompute-certify-local.whitelist - Added new jobs to certification whitelist
 * jobs/TC-001-0002-Platform_Controller_Hub.txt.in - renamed file to match correct naming scheme
 * jobs/TC-003-0001-Hardware_Information.txt.in - added new jobs for Hardware Info test cases
 * scripts/bios_info - new script to gather bios data
 * scripts/disk_info - new script to gather disk information
 * scripts/raid_info - new script to get info on MegaRAID storage devices
 * jobs/local.txt.in - Added job to parse new hardware information job file

And please do likewise with all your other merge requests.

review: Needs Fixing

[lp:~nelson-chu/opencompute/add-ocp-hardware-information-job]

2171. By Nelson Chu on 2014-03-18

Update debian/changelog file

[Nelson Chu (nelson-chu)]

I had modify debian/changelog
please help me to review it
thanks

review: Needs Resubmitting

[Jeff Lane  (bladernr)]

Terriffic... thanks!

review: Approve

=== modified file 'data/whitelists/opencompute-certify-local.whitelist'
--- data/whitelists/opencompute-certify-local.whitelist	2014-02-13 07:32:54 +0000
+++ data/whitelists/opencompute-certify-local.whitelist	2014-03-18 07:53:32 +0000
@@ -45,3 +45,11 @@
 __TC-001-0002-Platform_Controller_Hub__
 TC-001-0002-001-SATA_port
 TC-001-0002-002-USB_2.0
+__TC-003-0001-Hardware_Information__
+TC-003-0001-001-CPU_Information
+TC-003-0001-002-Memory_Information
+TC-003-0001-003-Disk_Information
+TC-003-0001-004-BIOS_Information
+TC-003-0001-005-ME_Information
+TC-003-0001-006-NIC_Information
+TC-003-0001-007-RAID_Card_Information

=== modified file 'debian/changelog'
--- debian/changelog	2014-02-21 09:49:16 +0000
+++ debian/changelog	2014-03-18 07:53:32 +0000
@@ -1,6 +1,14 @@
 checkbox (1.16.13~OCP) UNRELEASED; urgency=low
 
   [ Nelson Chu ]
+  * data/whitelists/opencompute-certify-local.whitelist - Added Hardware
+    Information jobs to OCP certification whitelist
+  * jobs/TC-003-0001-Hardware_Information.txt - Added new jobs for Hardware
+    Information test cases
+  * jobs/local.txt.in - Added job to parse new Hardware Information job file
+  * scripts/disk_info - new script to gather disk infomation
+  * scripts/bios_info - new script to gather BIOS infomation
+  * scripts/raid_info - new script to gather RAID infomation
   * data/whitelists/opencompute-certify-local.whitelist - Added PCH jobs to
     OCP certification whitelist
   * jobs/TC-001-0002-Platform_Controller_Hub.txt - Added new jobs for PCH

=== added file 'jobs/TC-001-0002-Platform_Controller_Hub.txt.in'
--- jobs/TC-001-0002-Platform_Controller_Hub.txt.in	1970-01-01 00:00:00 +0000
+++ jobs/TC-001-0002-Platform_Controller_Hub.txt.in	2014-03-18 07:53:32 +0000
@@ -0,0 +1,13 @@
+plugin: shell
+name: TC-001-0002-001-SATA_port
+command: check_sata_port
+description:
+ 1. Use dmesg command to gather SATA information.
+ 2. Criteria: SATA port speed up to 6.0Gps.
+
+plugin: shell
+name: TC-001-0002-002-USB_2.0
+command: check_usb_port
+description:
+ 1. Use dmesg command to gather USB information.
+ 2. Criteria: USB version must be 2.0.

=== removed file 'jobs/TC-001-0002-Platform_Controller_Hub.txt.in'
--- jobs/TC-001-0002-Platform_Controller_Hub.txt.in	2014-02-13 07:32:54 +0000
+++ jobs/TC-001-0002-Platform_Controller_Hub.txt.in	1970-01-01 00:00:00 +0000
@@ -1,13 +0,0 @@
-plugin: shell
-name: TC-001-0002-001-SATA_port
-command: check_sata_port
-description:
- 1. Use dmesg command to gather SATA information.
- 2. Criteria: SATA port speed up to 6.0Gps.
-
-plugin: shell
-name: TC-001-0002-002-USB_2.0
-command: check_usb_port
-description:
- 1. Use dmesg command to gather USB information.
- 2. Criteria: USB version must be 2.0.

=== added file 'jobs/TC-003-0001-Hardware_Information.txt.in'
--- jobs/TC-003-0001-Hardware_Information.txt.in	1970-01-01 00:00:00 +0000
+++ jobs/TC-003-0001-Hardware_Information.txt.in	2014-03-18 07:53:32 +0000
@@ -0,0 +1,57 @@
+plugin: shell
+name: TC-003-0001-001-CPU_Information
+command: echo "Refers to TC-001-0001-001-CPU_Information"
+description:
+ Refers to TC-001-0001-001-CPU_Information
+
+plugin: shell
+name: TC-003-0001-002-Memory_Information
+command: echo "Refers to TC-001-0001-003-Memory_Information"
+description:
+ Refers to TC-001-0001-003-Memory_Information
+
+plugin: shell
+name: TC-003-0001-003-Disk_Information
+requires: package.name == 'lshw'
+user: root
+command: disk_info
+description:
+ 1. Use lshw command to gather disk information. 
+ 2. The program will output disk type, vendor, product, capacity.
+ 3. Criteria: must be able to retrieve disk information.
+
+plugin: shell
+name: TC-003-0001-004-BIOS_Information
+requires: package.name == 'lshw'
+user: root
+command: bios_info
+description:
+ 1. Use lshw command to gather BIOS information. 
+ 2. The program will output BIOS vendor, version and release date.
+ 3. Criteria: must be able to retrieve BIOS information.
+
+plugin: shell
+name: TC-003-0001-005-ME_Information
+command: echo "Refers to TC-002-0010-001-Inventory_Infomation"
+description:
+ Refers to TC-002-0010-001-Inventory_Infomation
+
+plugin: shell
+name: TC-003-0001-006-NIC_Information
+command: network_device_info
+description:
+ 1. Use udevadm command to gather NIC information.
+ 2. The program will output Interface, product, vendor, driver, device path.
+ 3. Criteria: must be able to retrieve NIC information.
+
+plugin: shell
+name: TC-003-0001-007-RAID_Card_Information
+requires:
+ package.name == 'megacli'
+ package.name == 'megactl'
+user: root
+command: raid_info
+description:
+ 1. Use megasasctl command to gather LSI RAID card information.
+ 2. The program will output adapter, product name, memory, BBU, serial no.
+ 3. Criteria: All information listed in item 2 must have value to show that RAID card exists.

=== modified file 'jobs/local.txt.in'
--- jobs/local.txt.in	2014-02-13 07:32:54 +0000
+++ jobs/local.txt.in	2014-03-18 07:53:32 +0000
@@ -123,3 +123,10 @@
 command:
  shopt -s extglob
  cat $CHECKBOX_SHARE/jobs/TC-001-0002-Platform_Controller_Hub.txt?(.in)
+
+name: __TC-003-0001-Hardware_Information__
+plugin: local
+_description: Verify hardware information
+command:
+  shopt -s extglob
+  cat $CHECKBOX_SHARE/jobs/TC-003-0001-Hardware_Information.txt?(.in)

=== added file 'scripts/bios_info'
--- scripts/bios_info	1970-01-01 00:00:00 +0000
+++ scripts/bios_info	2014-03-18 07:53:32 +0000
@@ -0,0 +1,61 @@
+#!/usr/bin/env python3
+"""
+Copyright (C) 2010-2013 by Cloud Computing Center for Mobile Applications
+Industrial Technology Research Institute
+
+bios_info
+  1. Use lshw command to gather BIOS information.
+  2. The program will output BIOS vendor, version and release date.
+  3. Criteria: must be able to retrieve BIOS information.
+
+Authors
+  Nelson Chu <[e-mail]>
+
+This program is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License version 3,
+as published by the Free Software Foundation.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+"""
+
+import os
+import sys
+import xml.etree.ElementTree as ET
+from subprocess import check_output
+
+def main():
+    attribute = ['vendor', 'version', 'date']
+    command = 'lshw -xml'
+    with open(os.devnull, "w") as NULL:
+       hwinfo_xml = check_output(command, stderr=NULL, shell=True)
+    root = ET.fromstring(hwinfo_xml)
+
+    # Parse lshw XML for gathering BIOS information.
+    bios_info = root.findall(".//node[@id='firmware']")
+
+    if not bios_info:
+        print("Cannot parse any BIOS information.", file=sys.stderr)
+        return 10
+
+    for bios in bios_info:
+        for attr in attribute:
+            if bios.find(attr) is None:
+                print(("Cannot find BIOS %s") %attr, file=sys.stderr)
+                return 20
+
+        for attr in attribute:
+            if attr == 'date':
+                print(("Release date=\"%s\"") %bios.find(attr).text)
+                continue
+            print(("%s=\"%s\"") %(attr.capitalize(), bios.find(attr).text))
+    return 0
+
+if __name__ == '__main__':
+    sys.exit(main())

=== added file 'scripts/disk_info'
--- scripts/disk_info	1970-01-01 00:00:00 +0000
+++ scripts/disk_info	2014-03-18 07:53:32 +0000
@@ -0,0 +1,65 @@
+#!/usr/bin/env python3
+"""
+Copyright (C) 2010-2013 by Cloud Computing Center for Mobile Applications
+Industrial Technology Research Institute
+
+disk_info
+  1. Use lshw command to gather disk information.
+  2. The program will output disk type, vendor, product, capacity.
+  3. Criteria: must be able to retrieve disk information.
+
+Authors
+  Nelson Chu <[e-mail]>
+
+This program is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License version 3,
+as published by the Free Software Foundation.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+"""
+
+import sys
+import xml.etree.ElementTree as ET
+from subprocess import Popen, PIPE
+
+def main():
+    attribute = ['description', 'vendor', 'product', 'size']
+    command = 'lshw -xml'
+    hwinfo_xml = Popen(command, stdout=PIPE, stderr=PIPE,
+                       shell=True).communicate()[0]
+    root = ET.fromstring(hwinfo_xml)
+
+    # Parse lshw XML for gathering disk information.
+    disk_list = root.findall(".//node[@class='disk']")
+
+    if not disk_list:
+        print("Cannot parse any disk information.", file=sys.stderr)
+        return 10
+
+    for disk in disk_list:
+        for attr in attribute:
+            if disk.find(attr) is None:
+                print(("Cannot found disk %s") %attr, file=sys.stderr)
+                return 20
+
+        disk_size = int(disk.find('size').text) / (1000**3)
+        for attr in attribute:
+            if attr == 'description':
+                print(("Type=\"%s\"") %disk.find(attr).text)
+                continue
+            elif attr == 'size':
+                print(("%s=\"%dGB\"") %(attr.capitalize(), disk_size))
+                continue
+            else:
+                print(("%s=\"%s\"") %(attr.capitalize(), disk.find(attr).text))
+    return 0
+
+if __name__ == '__main__':
+    sys.exit(main())

=== added file 'scripts/raid_info'
--- scripts/raid_info	1970-01-01 00:00:00 +0000
+++ scripts/raid_info	2014-03-18 07:53:32 +0000
@@ -0,0 +1,51 @@
+#!/bin/bash
+#
+# Copyright (C) 2010-2013 by Cloud Computing Center for Mobile Applications
+# Industrial Technology Research Institute
+#
+# raid_info
+#   1. Use megasasctl command to gather LSI RAID card information.
+#   2. The program will output adapter, product name, memory, BBU, serial no.
+#   3. Criteria: All information listed in item 2 must have value to show that
+#                RAID card exists.
+#
+# Authors
+#   Nelson Chu <[e-mail]>
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 3,
+# as published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+
+check_return_code() {
+    if [ "${1}" -ne "0" ]; then
+        echo "ERROR: ${2}" >&2
+        exit ${1}
+    fi
+}
+
+output=`megacli -CfgDsply -Aall|grep -E \
+    'Adapter:|Product Name:|Memory:|BBU:|Serial No:'`
+check_return_code $? "There is no LSI MegaRAID SAS card found."
+
+n=0
+echo "$output" | {
+    while IFS= read -r line; do
+	echo "$line"
+	n=$(($n + 1))
+    done
+
+    if [ "$n" -ne 5 ]; then
+	check_return_code 10 "RAID card attributes are not correct."
+    fi
+
+    exit 0
+}