Merge lp:~negronjl/charm-tools/review-queue-charmers-group-juju-docs into lp:~charmers/charm-tools/trunk

[Juan L. Negron]

[lp:~negronjl/charm-tools/review-queue-charmers-group-juju-docs]

140. By Juan L. Negron on 2012-05-22

Added use of itertools ... thx hazmat

=== modified file 'scripts/review-queue'
--- scripts/review-queue	2012-05-21 03:46:53 +0000
+++ scripts/review-queue	2012-05-22 17:54:18 +0000
@@ -3,10 +3,11 @@
 from launchpadlib.launchpad import Launchpad
 from operator import itemgetter
 import datetime
+import itertools
 
 def calculate_age(from_date = None):
-	if not from_date:
-		return None
+    if not from_date:
+        return None
 
 
 def format_as_table(data,
@@ -71,53 +72,65 @@
 
 
 def charm_review_queue():
-        print "Connecting to launchpad..."
-	lp = Launchpad.login_anonymously('charm-tools', 'production', version='devel', launchpadlib_dir='~/.cache/launchpadlib')
-	charm = lp.distributions['charms']
-        print "Querying launchpad for bugs ..."
-	bugs = charm.searchTasks(tags=['new-formula', 'new-charm'], tags_combinator="Any", status=['New', 'Confirmed', 'Triaged', 'In Progress', 'Fix Committed'])
-	charmers = lp.people['charmers']
-        print "Querying launchpad for proposals ..."
-	proposals = charmers.getRequestedReviews(status="Needs review")
-	queue = list()
-	max_summary_length = 50
-	for bug in bugs.entries:
-		entry_summary = bug['title'].split('"')[1].strip()
-		entry_age = datetime.datetime.utcnow() - datetime.datetime.strptime(bug['date_created'].split('+')[0], "%Y-%m-%dT%H:%M:%S.%f")
-		entry = {
-		'date_created' : bug['date_created'].split("T")[0],
-		'age' : str(entry_age).split('.')[0],
-		'summary' : (entry_summary[:max_summary_length] + '...') if len(entry_summary) > max_summary_length else entry_summary,
-		'item' : bug['web_link'],
-		'status' : bug['status'],
-		}
-		queue.append(entry)
-	for proposal in proposals.entries:
-		proposal_summary = proposal['description']
-		proposal_age = datetime.datetime.utcnow() - datetime.datetime.strptime(proposal['date_created'].split('+')[0], "%Y-%m-%dT%H:%M:%S.%f")
-		if proposal_summary is None:
-			proposal_summary = "Proposal"
-		entry = {
-		'date_created' : proposal['date_created'].split("T")[0],
-		'age' : str(proposal_age).split('.')[0],
-		'summary' : (proposal_summary[:max_summary_length] + '...') if len(proposal_summary) > max_summary_length else proposal_summary,
-		'item' : proposal['web_link'],
-		'status' : proposal['queue_status'],
-		}
-		queue.append(entry)
-	return(sorted(queue, key=lambda k: k['date_created']))
+    print "Connecting to launchpad..."
+    lp = Launchpad.login_anonymously('charm-tools', 'production', version='devel', launchpadlib_dir='~/.cache/launchpadlib')
+    charm = lp.distributions['charms']
+    charmers = lp.people['charmers']
+    charm_contributors = lp.people['charm-contributors']
+    
+    print "Querying launchpad for bugs ..."
+    bugs = charm.searchTasks(tags=['new-formula', 'new-charm'], tags_combinator="Any", status=['New', 'Confirmed', 'Triaged', 'In Progress', 'Fix Committed'])
+    charmers_bugs = charmers.searchTasks(status=['New', 'Confirmed', 'Triaged', 'In Progress', 'Fix Committed'])
+    
+    print "Querying launchpad for proposals ..."
+    proposals = charmers.getRequestedReviews(status="Needs review")
+    charm_contributors_proposals = charm_contributors.getRequestedReviews(status="Needs review")
+    
+    print "Building review_queue ..."
+    queue = list()
+    max_summary_length = 50
+    
+    # Bugs in charms distribution and charmers group
+    for bug in itertools.chain( bugs.entries, charmers_bugs.entries ):
+        entry_summary = bug['title'].split('"')[1].strip()
+        entry_age = datetime.datetime.utcnow() - datetime.datetime.strptime(bug['date_created'].split('+')[0], "%Y-%m-%dT%H:%M:%S.%f")
+        entry = {
+        'date_created' : bug['date_created'].split("T")[0],
+        'age' : str(entry_age).split('.')[0],
+        'summary' : (entry_summary[:max_summary_length] + '...') if len(entry_summary) > max_summary_length else entry_summary,
+        'item' : bug['web_link'],
+        'status' : bug['status'],
+        }
+        queue.append(entry)
+        
+    # Merge proposals in charmers group
+    for proposal in itertools.chain(proposals.entries, charm_contributors_proposals.entries):
+        proposal_summary = proposal['description']
+        proposal_age = datetime.datetime.utcnow() - datetime.datetime.strptime(proposal['date_created'].split('+')[0], "%Y-%m-%dT%H:%M:%S.%f")
+        if proposal_summary is None:
+            proposal_summary = "Proposal"
+        entry = {
+        'date_created' : proposal['date_created'].split("T")[0],
+        'age' : str(proposal_age).split('.')[0],
+        'summary' : (proposal_summary[:max_summary_length] + '...') if len(proposal_summary) > max_summary_length else proposal_summary,
+        'item' : proposal['web_link'],
+        'status' : proposal['queue_status'],
+        }
+        queue.append(entry)
+
+    return(sorted(queue, key=lambda k: k['date_created']))
 
 def main():
-	review_queue = charm_review_queue()
-	keys = ['date_created', 'age', 'summary', 'item', 'status' ]
-	headers = ['Date Created', 'Age', 'Summary', 'Item', 'Status']
-	if type(review_queue) == type([]) and len(review_queue) > 0:
-		print format_as_table(review_queue, 
-		                      keys, 
-		                      header = headers,
-		                      sort_by_key = 'date_created',
-		                      sort_order_reverse = False)
+    review_queue = charm_review_queue()
+    keys = ['date_created', 'age', 'summary', 'item', 'status' ]
+    headers = ['Date Created', 'Age', 'Summary', 'Item', 'Status']
+    if type(review_queue) == type([]) and len(review_queue) > 0:
+        print format_as_table(review_queue, 
+                              keys, 
+                              header = headers,
+                              sort_by_key = 'date_created',
+                              sort_order_reverse = False)
 
 
 if __name__ == "__main__":
-	main()
+    main()