Code review comment for lp:~nbrinza/zorba/bugs2

Revision history for this message
Nicolae Brinza (nbrinza) wrote :

It's a duration. It does not have a start/end date. So you cannot possibly know if you're in a leap year.

I've searched a bit, but I cannot find the spec where it says how to perform the duration normalization, but the code in Duration::normalize() assumes a year has 60 * 60 * 24 * 30 * 12 seconds.

« Back to merge proposal